Skip to contentSkip to conversation

webp: new package

PATCH New gilles.talis at gmail.com 2 participants 4 messages Jan 16, 2013 – Jan 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webp: new package

From: Gilles Talis <[email protected]>

WebP is a new image format that provides lossless and lossy compression for images on the web

---
 package/Config.in      |    1 +
 package/webp/Config.in |    7 +++++++
 package/webp/webp.mk   |   22 ++++++++++++++++++++++
 3 files changed, 30 insertions(+), 0 deletions(-)
 create mode 100644 package/webp/Config.in
 create mode 100644 package/webp/webp.mk
package/Config.in +1 -0
index ba03b3c..1e8c4da 100644
@@ -433,6 +433,7 @@ source "package/pango/Config.in"
 source "package/pixman/Config.in"
 source "package/tiff/Config.in"
 source "package/webkit/Config.in"
+source "package/webp/Config.in"
 source "package/zxing/Config.in"
 endmenu
 
package/webp/Config.in new file +7 -0
new file mode 100644
index 0000000..a2acdff
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_WEBP
+	bool "webp"
+	help
+	  WebP is a new image format that provides lossless and
+	  lossy compression for images on the web
+
+	  https://developers.google.com/speed/webp/
package/webp/webp.mk new file +22 -0
new file mode 100644
index 0000000..3dcb13c
@@ -0,0 +1,22 @@
+#####################################################################
+#
+# webp
+#
+#####################################################################
+
+WEBP_VERSION = 0.2.1
+WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
+WEBP_SITE = https://webp.googlecode.com/files
+WEBP_LICENSE = BSD-3c
+WEBP_LICENSE_FILES = COPYING
+WEBP_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_LIBPNG),y)
+WEBP_DEPENDENCIES += libpng
+WEBP_CONF_ENV += ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config
+endif
+
+WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg)
+WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)
+
+$(eval $(autotools-package))
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 webp: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"gilles" == gilles talis <[email protected]> writes:

gilles> From: Gilles Talis <[email protected]> gilles> WebP is a new image format that provides lossless gilles> and lossy compression for images on the web

gilles> +##################################################################### gilles> +#
gilles> +# webp
gilles> +#
gilles> +##################################################################### gilles> +
gilles> +WEBP_VERSION = 0.2.1
gilles> +WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz
gilles> +WEBP_SITE = https://webp.googlecode.com/files
gilles> +WEBP_LICENSE = BSD-3c
gilles> +WEBP_LICENSE_FILES = COPYING
gilles> +WEBP_INSTALL_STAGING = YES
gilles> +
gilles> +ifeq ($(BR2_PACKAGE_LIBPNG),y)
gilles> +WEBP_DEPENDENCIES += libpng
gilles> +WEBP_CONF_ENV += ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config gilles> +endif

So what happens when you don't have libpng enabled but do have libpng-config on the host? Is there no explicit configure options to turn off png support (alternatively, point LIBPNG_CONFIG to /bin/false or similar).

gilles> +
gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg) gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)

Same here. You don't depend on host-pkgconf, so it presumably doesn't use that to figure out availability of jpeg/tiff.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 webp: new package

Dear Peter,

Quoted 8 lines · Peter Korsgaard
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"gilles" == gilles talis <[email protected]> writes:

gilles> From: Gilles Talis <[email protected]> gilles> WebP is a new image format that provides lossless gilles> and lossy compression for images on the web

gilles>

+#####################################################################

Quoted 4 lines

gilles> +#
gilles> +# webp
gilles> +#
gilles>

+#####################################################################

Quoted 11 lines

gilles> +
gilles> +WEBP_VERSION = 0.2.1
gilles> +WEBP_SOURCE = libwebp-$(WEBP_VERSION).tar.gz gilles> +WEBP_SITE = https://webp.googlecode.com/files
gilles> +WEBP_LICENSE = BSD-3c
gilles> +WEBP_LICENSE_FILES = COPYING
gilles> +WEBP_INSTALL_STAGING = YES
gilles> +
gilles> +ifeq ($(BR2_PACKAGE_LIBPNG),y) gilles> +WEBP_DEPENDENCIES += libpng
gilles> +WEBP_CONF_ENV +=

ac_cv_path_LIBPNG_CONFIG=$(STAGING_DIR)/usr/bin/libpng-config

Quoted 6 lines

gilles> +endif

So what happens when you don't have libpng enabled but do have libpng-config on the host? Is there no explicit configure options to turn off png support (alternatively, point LIBPNG_CONFIG to /bin/false or similar).

There's no way to disable any of the options mentioned in that patch (PNG, JPEG, TIFF).

in my setup, the "configure" step returns cross-compilation errors, thus removes PNG from the available options.

I hesitated quite a bit before embedding LIBPNG_CONFIG within BR2_PACKAGE_LIBPNG flag. My first intention was to force this config to always point to the staging dir. Is that what you are suggesting?

Quoted 7 lines

gilles> +
gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg) gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)

Same here. You don't depend on host-pkgconf, so it presumably doesn't use that to figure out availability of jpeg/tiff.

Same here. I can force the paths to JPEG and TIFF include and lib to always point to staging dir. Was my first intention, but it seemed to work out fine without doing that. Do you think it would be preferrable to force these paths?

thanks
Gilles.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130121/8ce93d4d/attachment.html>

#3 lore raw

PATCH 1/1 webp: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gilles" == Gilles Talis <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 5 lines

?gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_JPEG),jpeg) ?gilles> +WEBP_DEPENDENCIES += $(if $(BR2_PACKAGE_TIFF),tiff)

Same here. You don't depend on host-pkgconf, so it presumably doesn't use that to figure out availability of jpeg/tiff.

Gilles> Same here. I can force the paths to JPEG and TIFF include and Gilles> lib to always point to staging dir. Was my first intention, but Gilles> it seemed to work out fine without doing that. Do you think it Gilles> would be preferrable to force these paths?

I'm concerned it will fail if you build for the same architecture as your host (E.G. for a PC), haven't enabled png/tiff/jpeg in buildroot but DO have the development libraries installed on the host.

I'll give it a test later today.

Signature · 1 line
Bye, Peter Korsgaard