kirkwood: Add iconnect support
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 kirkwood: Add iconnect support
Andrew Lunn <[email protected]> writes:
Hi,
Quoted 7 lines
Quoted 6 lines
Review
Quoted 4 lines
+
(quoted diff) +3
-0+#define ICONNECT_BLINK_HALF_PERIOD 100 + +static int iconnect_blink_set(unsigned gpio, int state,
__init?
Quoted 7 lines
Hi Jason
It is correct without
__init. This function will get called when you play with/sys/class/leds/*/trigger.However, this is the second public instance of this function, it is also in
mach-orion5x/dns323-setup.c.
yeah, I know. I initially planned to send a patchset adding iconnect support and putting this function into something like gpio.c but I forgot about it when converting my first iconnect patch into DT. Any objection about sending a patch doing that once I manage to merge the iconnect support (and of course, in this case, feel free to remind me of it if I forget to do it ) ?
Arnaud
PATCH 1/1 kirkwood: Add iconnect support
Quoted 19 lines · Arnaud Patard
Andrew Lunn <[email protected]> writes:
Hi,
Quoted 7 lines
Quoted 6 lines
Review
Quoted 4 lines
+
(quoted diff) +3
-0+#define ICONNECT_BLINK_HALF_PERIOD 100 + +static int iconnect_blink_set(unsigned gpio, int state,
__init?Quoted 7 lines
Hi Jason
It is correct without
__init. This function will get called when you play with/sys/class/leds/*/trigger.However, this is the second public instance of this function, it is also in
mach-orion5x/dns323-setup.c.
Quoted 6 lines
yeah, I know. I initially planned to send a patchset adding iconnect support and putting this function into something like
gpio.cbut I forgot about it when converting my first iconnect patch into DT. Any objection about sending a patch doing that once I manage to merge the iconnect support (and of course, in this case, feel free to remind me of it if I forget to do it ) ?
I'd prefer to have the fixes first, then base new stuff off of the fix.
thx,
Jason.