Skip to contentSkip to conversation

vub300: fix module parameter.

PATCH Applied Rusty Russell 3 participants 5 messages Dec 15, 2011 – Dec 20, 2011 MMC, SD and SDIO

lore
Share & tools
lore

Rusty Russell

author
#0 lore raw

PATCH 4/15 vub300: fix module parameter.

You didn't mean this to be a bool.

Cc Tony Olech <[email protected]>
Cc Chris Ball <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rusty Russell <[email protected]>
---
 drivers/mmc/host/vub300.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/vub300.c +1 -1
@@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
 static int firmware_rom_wait_states = 0x1C;
 #endif
 
-module_param(firmware_rom_wait_states, bool, 0644);
+module_param(firmware_rom_wait_states, int, 0644);
 MODULE_PARM_DESC(firmware_rom_wait_states,
 		 "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
#1 lore raw

You are right.
I don't know how that slipped through
Tony Olech

Quoted 27 lines · Rusty Russell

You didn't mean this to be a bool.

Cc Tony Olech <[email protected]>
Cc Chris Ball <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rusty Russell <[email protected]>
---
 drivers/mmc/host/vub300.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/vub300.c +1 -2
@@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
 static int firmware_rom_wait_states = 0x1C;
 #endif
 
-module_param(firmware_rom_wait_states, bool, 0644);
+module_param(firmware_rom_wait_states, int, 0644);
 MODULE_PARM_DESC(firmware_rom_wait_states,
 		 "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
 
--

To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 3 lines · Tony Olech

You are right.
I don't know how that slipped through
Tony Olech

I'm assuming that means you're taking this? Otherwise, please give me an acked-by.

Thanks,
Rusty.

#3 lore raw

Hi Rusty,

Quoted 8 lines · Rusty Russell
Quoted 3 lines · Tony Olech

You are right.
I don't know how that slipped through
Tony Olech

I'm assuming that means you're taking this? Otherwise, please give me an acked-by.

Thanks, I'll send this for 3.2 with Tony's ACK.

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
Acked-by Acked-by
#4 lore raw
In reply to Tony Olech
Quoted 15 lines · Rusty Russell

You didn't mean this to be a bool.

Cc Tony Olech <[email protected]>
Cc Chris Ball <[email protected]>
Cc [email protected]
Cc [email protected]
Signed-off-by Rusty Russell <[email protected]>
---
 drivers/mmc/host/vub300.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/host/vub300.c static int firmware_rom_wait_states = 0x

Quoted 9 lines
drivers/mmc/host/vub300.c +1 -2
@@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
 static int firmware_rom_wait_states = 0x1C;
 #endif
 
-module_param(firmware_rom_wait_states, bool, 0644);
+module_param(firmware_rom_wait_states, int, 0644);
 MODULE_PARM_DESC(firmware_rom_wait_states,
 		 "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
 
--

You are right.
I don't know how that slipped through

Acked-by Tony Olech <[email protected]>
Acked-by Tony Olech <[email protected]>