twl4030: keypad: Hooks for board specific suspend-resume
PATCH 2/3 twl4030: keypad: Hooks for board specific suspend-resume
This patch adds hooks to support board specific implementation during the suspend and resume operations.
The TWL4030 can be connected to multiple boards. Without these hooks, board specific macros will be required in a generic driver.
--- drivers/input/keyboard/twl4030_keypad.c | 10 ++++++++++ include/linux/i2c/twl.h | 12 ++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-)
drivers/input/keyboard/twl4030_keypad.c +10 -0
@@ -442,11 +442,21 @@ static int __devexit twl4030_kp_remove(struct platform_device *pdev)#ifdef CONFIG_PM static int twl4030_kp_suspend (struct platform_device *pdev,pm_message_t state) { +struct twl4030_keypad_data *pdata = pdev->dev.platform_data; + +if (pdata->on_suspend) + pdata->on_suspend (pdata->pm_state); +return 0 ; }static int twl4030_kp_resume (struct platform_device *pdev) { +struct twl4030_keypad_data *pdata = pdev->dev.platform_data; + +if (pdata->on_resume) + pdata->on_resume (pdata->pm_state); +return 0 ; }#else
include/linux/i2c/twl.h +12 -0
@@ -487,6 +487,18 @@ struct twl4030_keypad_data {unsigned rows;unsigned cols;bool rep; +#ifdef CONFIG_PM +/* +* Board specific information required during suspend, resume. +* E.g. configuration as wake-up source. +*/ +void *pm_state; +/* +* Hooks for board specific execution during suspend, resume. +*/ +void (*on_suspend)(void *pstate); +void (*on_resume)(void *pstate); +#endif };enum twl4030_usb_mode {
Signature · 1 line
1.6.2.2
Quoted 8 lines · Sanjeev Premi
This patch adds hooks to support board specific implementation during the suspend and resume operations.
The TWL4030 can be connected to multiple boards. Without these hooks, board specific macros will be required in a generic driver.
Signed-off-by Sanjeev Premi <[email protected]>
Looks ok, but I think you should drop the 'on_' prefix in function pointer names.
Kevin
Quoted 61 lines
--- drivers/input/keyboard/twl4030_keypad.c | 10 ++++++++++ include/linux/i2c/twl.h | 12 ++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-)drivers/input/keyboard/twl4030_keypad.c +10
-0@@ -442,11 +442,21 @@ static int __devexit twl4030_kp_remove(struct platform_device *pdev)#ifdef CONFIG_PM static int twl4030_kp_suspend (struct platform_device *pdev,pm_message_t state) { +struct twl4030_keypad_data *pdata = pdev->dev.platform_data; + +if (pdata->on_suspend) + pdata->on_suspend (pdata->pm_state); +return 0 ; }static int twl4030_kp_resume (struct platform_device *pdev) { +struct twl4030_keypad_data *pdata = pdev->dev.platform_data; + +if (pdata->on_resume) + pdata->on_resume (pdata->pm_state); +return 0 ; }#else include/linux/i2c/twl.h +12
-0@@ -487,6 +487,18 @@ struct twl4030_keypad_data {unsigned rows;unsigned cols;bool rep; +#ifdef CONFIG_PM +/* +* Board specific information required during suspend, resume. +* E.g. configuration as wake-up source. +*/ +void *pm_state; +/* +* Hooks for board specific execution during suspend, resume. +*/ +void (*on_suspend)(void *pstate); +void (*on_resume)(void *pstate); +#endif };enum twl4030_usb_mode {Signature · 6 lines
1.6.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 17 lines
-----Original Message-----
From: Kevin Hilman [mailto:[email protected]]
Sent: Friday, February 05, 2010 3:19 AM
To: Premi, Sanjeev
Cc: [email protected]
Subject: Re: [PATCH 2/3] twl4030: keypad: Hooks for board specific suspend-resumeQuoted 7 lines · Sanjeev Premi
This patch adds hooks to support board specific implementation during the suspend and resume operations.
The TWL4030 can be connected to multiple boards. Without these hooks, board specific macros will be required in a generic driver.
Quoted 7 lines
Quoted 1 line
Signed-off-by Sanjeev Premi <[email protected]>Looks ok, but I think you should drop the '
on_' prefix in function pointer names.Kevin
Will re-submit this patch after change.
~sanjeev
[snip]--[snip]