RFC: kill msdos and vfat modules?
There's almost no code left in the msdos and vfat modules with all the guts in the shared fat module. Shouldn't we just do away with the vfat and msdos modules and just provide module aliases in the main fat module?
Quoted 4 lines · Christoph Hellwig
There's almost no code left in the msdos and vfat modules with all the guts in the shared fat module. Shouldn't we just do away with the vfat and msdos modules and just provide module aliases in the main fat module?
I have no objection to it if it works. Maybe, one concern is the order of detection (rootfs, /proc/filesystems) when it's not moudle. (however, probably it's not hard to control).
Thanks.
Signature · 1 line
OGAWA Hirofumi <[email protected]>
Quoted 8 lines · OGAWA Hirofumi
Quoted 4 lines
There's almost no code left in the msdos and vfat modules with all the guts in the shared fat module. Shouldn't we just do away with the vfat and msdos modules and just provide module aliases in the main fat module?
I have no objection to it if it works. Maybe, one concern is the order of detection (rootfs,
/proc/filesystems) when it's not moudle. (however, probably it's not hard to control).
For the non-modular case detection order is already determined by link order, so nothing would change, at least if we still keep config options to allow for 8.3 vs vfat naming. Then again the former is so simple that we could always compile it in anyway.
Quoted 6 lines · Christoph Hellwig
Quoted 5 lines · OGAWA Hirofumi
Quoted 4 lines
There's almost no code left in the msdos and vfat modules with all the guts in the shared fat module. Shouldn't we just do away with the vfat and msdos modules and just provide module aliases in the main fat module?
Quoted 8 lines
Quoted 3 lines
I have no objection to it if it works. Maybe, one concern is the order of detection (rootfs,
/proc/filesystems) when it's not moudle. (however, probably it's not hard to control).For the non-modular case detection order is already determined by link order, so nothing would change, at least if we still keep config options to allow for 8.3 vs vfat naming. Then again the former is so simple that we could always compile it in anyway.
If modules was merged to one, msdos and vfat in fs/Makefile will be merged too. If so, it will not define the link order anymore. Anyway, nothing would be hard, but, I guess there is the change which need to care.
Signature · 1 line
OGAWA Hirofumi <[email protected]>