Skip to contentSkip to conversation

USB HID: Missing keys on Gyration Media Center Universal Remote Control

DISCUSSION Philippe Troin 2 participants 7 messages Jun 17, 2008 – Aug 1, 2008 HID

lore
Share & tools
lore
#0 lore raw

Jiri & all,

What's the status on this bug?

I used this patch for 2.6.24:

drivers/hid/hid-input.c +23 -0
index 0b27da7..fc6e77e 100644
@@ -802,6 +802,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 		case HID_UP_LOGIVENDOR:
 			set_bit(EV_REP, input->evbit);
 			switch(usage->hid & HID_USAGE) {
+				case 0x000: map_key_clear(KEY_TV);
 				/* Reported on Logitech Ultra X Media Remote */
 				case 0x004: map_key_clear(KEY_AGAIN);		break;
 				case 0x00d: map_key_clear(KEY_HOME);		break;
@@ -1039,6 +1040,28 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 	}
 
+	/* "Sleep" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			((usage->hid & HID_USAGE_PAGE) == HID_UP_GENDESK) &&
+			((usage->hid & 0xf0) == 0x80)  &&
+			((usage->hid & 0xf) == 0x2)) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+	/* "TV" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			((usage->hid & HID_USAGE_PAGE) == HID_UP_LOGIVENDOR) &&
+			((usage->hid & HID_USAGE) == 0x0000)) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+
 	/* Handling MS keyboards special buttons */
 	if (IS_MS_KB(hid) && usage->hid == (HID_UP_MSVENDOR | 0xff05)) {
 		int key = 0;

It was working fine.

With 2.6.25.6, I've been trying to use the following patch. It's a slight modification of a patch posted previously by Jiri.

drivers/hid/hid-input-quirks.c +21 -0
diff -ru vanilla.orig/drivers/hid/hid-input-quirks.c vanilla/drivers/hid/hid-input-quirks.c
@@ -418,6 +418,27 @@
 		input_event(input, usage->type, REL_WHEEL, -value);
 		return 1;
 	}
+	/* "Sleep" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+	    (usage->hid & HID_USAGE_PAGE) == HID_UP_GENDESK &&
+	    (usage->hid & 0xf0) == 0x80 &&
+	    (usage->hid & 0xf) == 0x2) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return 0;
+	}
+	/* "TV" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+	    (usage->hid & HID_USAGE_PAGE) == HID_UP_LOGIVENDOR &&
+	    (usage->hid & HID_USAGE) == 0x0000) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return 0;
+	}
 	return 0;
 }
 
drivers/hid/hid-input.c +6 -1
diff -ru vanilla.orig/drivers/hid/hid-input.c vanilla/drivers/hid/hid-input.c
@@ -724,7 +724,12 @@
 
 		case HID_UP_LOGIVENDOR:
 
-			goto ignore;
+		  set_bit(EV_REP, input->evbit);
+		  switch(usage->hid & HID_USAGE) {
+		  	case 0x027: map_key_clear(KEY_TV); break;
+		  	default: goto ignore;
+		  };
+		  break;
 		
 		case HID_UP_PID:
 

However this patch does not seem to work at all:

* the Power button keeps repeating the power key once pressed

* the home (windows MCE green button) and the four keys below it (shortcuts to movies, music, photos, tv) do not work.

Is there anything I can help with to get a working patch?

Thanks,
Phil.

#1 lore raw
Quoted 44 lines · Philippe Troin

Jiri & all,
What's the status on this bug?
I used this patch for 2.6.24:

drivers/hid/hid-input.c +23 -0
index 0b27da7..fc6e77e 100644
@@ -802,6 +802,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 		case HID_UP_LOGIVENDOR:
 			set_bit(EV_REP, input->evbit);
 			switch(usage->hid & HID_USAGE) {
+				case 0x000: map_key_clear(KEY_TV);
 				/* Reported on Logitech Ultra X Media Remote */
 				case 0x004: map_key_clear(KEY_AGAIN);		break;
 				case 0x00d: map_key_clear(KEY_HOME);		break;
@@ -1039,6 +1040,28 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 	}
 
+	/* "Sleep" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			((usage->hid & HID_USAGE_PAGE) == HID_UP_GENDESK) &&
+			((usage->hid & 0xf0) == 0x80)  &&
+			((usage->hid & 0xf) == 0x2)) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+	/* "TV" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			((usage->hid & HID_USAGE_PAGE) == HID_UP_LOGIVENDOR) &&
+			((usage->hid & HID_USAGE) == 0x0000)) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+
 	/* Handling MS keyboards special buttons */
 	if (IS_MS_KB(hid) && usage->hid == (HID_UP_MSVENDOR | 0xff05)) {
 		int key = 0;
Quoted 1 line

It was working fine.

Hi,

The patch didn't add complete support for this device, there still has been problem with "TV" key, and I have asked Adolfo to perform a test with debugging patch, but there seems to be no response so far [1]

Adolfo (added to CC), has there been any progress, so that we could proceed with merging the patch adding proper support for this HW?

Thanks,

[1]

Signature · 2 lines
Jiri Kosina
SUSE Labs
#2 lore raw
Quoted 50 lines · Jiri Kosina
Quoted 44 lines · Philippe Troin

Jiri & all,
What's the status on this bug?
I used this patch for 2.6.24:

drivers/hid/hid-input.c +23 -0
index 0b27da7..fc6e77e 100644
@@ -802,6 +802,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
 		case HID_UP_LOGIVENDOR:
 			set_bit(EV_REP, input->evbit);
 			switch(usage->hid & HID_USAGE) {
+				case 0x000: map_key_clear(KEY_TV);
 				/* Reported on Logitech Ultra X Media Remote */
 				case 0x004: map_key_clear(KEY_AGAIN);		break;
 				case 0x00d: map_key_clear(KEY_HOME);		break;
@@ -1039,6 +1040,28 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 	}
 
+	/* "Sleep" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			((usage->hid & HID_USAGE_PAGE) == HID_UP_GENDESK) &&
+			((usage->hid & 0xf0) == 0x80)  &&
+			((usage->hid & 0xf) == 0x2)) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+	/* "TV" key */
+	if (hid->vendor == 0x0c16 && hid->product == 0x0002 &&
+			((usage->hid & HID_USAGE_PAGE) == HID_UP_LOGIVENDOR) &&
+			((usage->hid & HID_USAGE) == 0x0000)) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return;
+	}
+
 	/* Handling MS keyboards special buttons */
 	if (IS_MS_KB(hid) && usage->hid == (HID_UP_MSVENDOR | 0xff05)) {
 		int key = 0;
Quoted 1 line

It was working fine.

Hi,

Quoted 3 lines

The patch didn't add complete support for this device, there still has been problem with "TV" key, and I have asked Adolfo to perform a test with debugging patch, but there seems to be no response so far [1]

For me, as I mentionned, there are 6 keys not working with or without the patch (home, tv, photo, movies, music, and another key for which I do not have a description), in addition to the power key repeating for ever once pressed.

Quoted 2 lines

Adolfo (added to CC), has there been any progress, so that we could proceed with merging the patch adding proper support for this HW?

I could also help debugging/testing.

Phil.

#3 lore raw
In reply to Philippe Troin
Quoted 7 lines · Philippe Troin

However this patch does not seem to work at all:
* the Power button keeps repeating the power key once pressed

* the home (windows MCE green button) and the four keys below it (shortcuts to movies, music, photos, tv) do not work.

Is there anything I can help with to get a working patch?

Please compile your kernel with 'CONFIG_HID_DEBUG', modprobe the 'hid' module with 'debug=2' parameter, and send me the output that appears is dmesg output when you press the non-working keys.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
#4 lore raw
Quoted 3 lines · Jiri Kosina

Please compile your kernel with 'CONFIG_HID_DEBUG', modprobe the 'hid' module with 'debug=2' parameter, and send me the output that appears is dmesg output when you press the non-working keys.

debug=2 didn't work. dmesg said:

hid: `2' invalid for parameter debug.

With debug=1, I get the following output.

But first, info:

kernel 2.6.25.6 - no extra patches

/proc/bus/usb/devices

T:  Bus=05 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  2 Spd=1.5 MxCh= 0
D:  Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS= 8 #Cfgs=  1
P:  Vendor=0c16 ProdID=0002 Rev= 2.20
S:  Manufacturer=Gyration
S:  Product=Gyration RF Technology Receiver

C:* #Ifs= 2 Cfg#= 1 Atr=a0 MxPwr= 98mA
I:* If#= 0 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=01 Prot=01 Driver=(none)
E: Ad=81(I) Atr=03(Int.) MxPS= 8 Ivl=10ms
I:* If#= 1 Alt= 0 #EPs= 1 Cls=03(HID ) Sub=01 Prot=02 Driver=(none)
E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=10ms

There are 6 six keys which do not work at all:

* "MCE Home key - green button"

First time pressed:

drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 00 00

Second and subsequent times pressed:

drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 0d 00
hid-debug: input ffbc.000d = 1 drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 00 00
hid-debug: input ffbc.000d = 0

* "Pictures" shortcut button

drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 49 00
hid-debug: input ffbc.0049 = 1 drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 00 00
hid-debug: input ffbc.0049 = 0

* "TV" shortcut button

drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 46 00
hid-debug: input ffbc.0046 = 1 drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 00 00
hid-debug: input ffbc.0046 = 0

* "Music" shortcut button

drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 47 00
hid-debug: input ffbc.0047 = 1 drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 00 00
hid-debug: input ffbc.0047 = 0

* "Movies" shortcut button

drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 4a 00
hid-debug: input ffbc.004a = 1 drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 00 00
hid-debug: input ffbc.004a = 0

* "Live TV" button

drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 25 00
hid-debug: input ffbc.0025 = 1 drivers/hid/hid-core.c: report (size 3) (numbered) drivers/hid/hid-core.c: report 6 (size 2) = 00 00
hid-debug: input ffbc.0025 = 0

Also, the "Power" button keeps repeating once pressed:

drivers/hid/hid-core.c: report (size 2) (numbered) drivers/hid/hid-core.c: report 3 (size 1) = 82
hid-debug: input GenericDesktop.SystemPowerDown = 0
hid-debug: input GenericDesktop.SystemSleep = 1
hid-debug: input GenericDesktop.SystemWakeUp = 0

There you are.
Let me know if there is anything else I can do.

Phil.

#5 lore raw

For the record, the enclosed patch makes the remote work for me.

Phil.

X-From-Line: [email protected] Tue Jul 1 09:24:49 2008
Return-Path: <[email protected]>
Received: from dwalker1.mvista.com (gateway-1237.mvista.com [63.81.120.158])

	by old-tantale.fifi.org (8.9.3p2/8.9.3/Debian 8.9.3-21) with ESMTP id JAA14827
	for <[email protected]>; Tue, 1 Jul 2008 09:24:48 -0700
X-Authentication-Warning: old-tantale.fifi.org: Host gateway-1237.mvista.com [63.81.120.158] claimed to be dwalker1.mvista.com
Received: from dwalker1.mvista.com (localhost.localdomain [127.0.0.1])
	by dwalker1.mvista.com (8.14.1/8.14.1) with ESMTP id m61GOC0O014533;
	Tue, 1 Jul 2008 09:24:12 -0700
Received: (from dwalker@localhost)
	by dwalker1.mvista.com (8.14.1/8.14.1/Submit) id m61GOBx4014532;
	Tue, 1 Jul 2008 09:24:11 -0700

From: Daniel Walker <[email protected]>
To: Jiri Kosina <[email protected]>
Cc: Philippe Troin <[email protected]>, "Adolfo R. Brandes" <[email protected]>,
[email protected]
Subject: [PATCH] hid: gyration remote support
Date: Tue, 1 Jul 2008 09:24:11 -0700
X-Gnus-Mail-Source: directory:~/priv/gnus/procmail
Message-Id: <[email protected]>
X-Mailer: git-send-email 1.5.5.1.1.g0dfaf8
Lines: 67
Xref: old-tantale.fifi.org misc:34763

This adds in a quirk for the additional un-mapped buttons on the gyration MCE remote.

Defines are now alphabetical.

---
 drivers/hid/hid-input-quirks.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)
drivers/hid/hid-input-quirks.c +28 -0
index 4c2052c..e6a937a 100644
@@ -89,6 +89,29 @@ static int quirk_logitech_ultrax_remote(struct hid_usage *usage, struct input_de
 	return 1;
 }
 
+static int quirk_gyration_remote(struct hid_usage *usage, struct input_dev *input,
+			      unsigned long **bit, int *max)
+{
+	if ((usage->hid & HID_USAGE_PAGE) != HID_UP_LOGIVENDOR)
+		return 0;
+
+	set_bit(EV_REP, input->evbit);
+	switch(usage->hid & HID_USAGE) {
+		/* Reported on Gyration MCE Remote */
+		case 0x00d: map_key_clear(KEY_HOME);		break;
+		case 0x024: map_key_clear(KEY_DVD);		break;
+		case 0x025: map_key_clear(KEY_PVR);		break;
+		case 0x046: map_key_clear(KEY_MEDIA);		break;
+		case 0x047: map_key_clear(KEY_MP3);		break;
+		case 0x049: map_key_clear(KEY_CAMERA);		break;
+		case 0x04a: map_key_clear(KEY_VIDEO);		break;
+
+		default:
+			return 0;
+	}
+	return 1;
+}
+
 static int quirk_chicony_tactical_pad(struct hid_usage *usage, struct input_dev *input,
 			      unsigned long **bit, int *max)
 {
@@ -303,6 +326,9 @@ static int quirk_sunplus_wdesktop(struct hid_usage *usage, struct input_dev *inp
 #define VENDOR_ID_EZKEY				0x0518
 #define DEVICE_ID_BTC_8193			0x0002
 
+#define VENDOR_ID_GYRATION			0x0c16
+#define DEVICE_ID_GYRATION_REMOTE		0x0002
+
 #define VENDOR_ID_LOGITECH			0x046d
 #define DEVICE_ID_LOGITECH_RECEIVER		0xc101
 #define DEVICE_ID_S510_RECEIVER			0xc50c
@@ -337,6 +363,8 @@ static const struct hid_input_blacklist {
 
 	{ VENDOR_ID_EZKEY, DEVICE_ID_BTC_8193, quirk_btc_8193 },
 
+	{ VENDOR_ID_GYRATION, DEVICE_ID_GYRATION_REMOTE, quirk_gyration_remote },
+
 	{ VENDOR_ID_LOGITECH, DEVICE_ID_LOGITECH_RECEIVER, quirk_logitech_ultrax_remote },
 	{ VENDOR_ID_LOGITECH, DEVICE_ID_S510_RECEIVER, quirk_logitech_wireless },
 	{ VENDOR_ID_LOGITECH, DEVICE_ID_S510_RECEIVER_2, quirk_logitech_wireless },
Signature · 37 lines
1.5.5.1.1.g0dfaf8



X-From-Line: [email protected]  Tue Jul  1 09:24:49 2008
Return-Path: <[email protected]>
Received: from dwalker1.mvista.com (gateway-1237.mvista.com [63.81.120.158])
	by old-tantale.fifi.org (8.9.3p2/8.9.3/Debian 8.9.3-21) with ESMTP id JAA14828
	for <[email protected]>; Tue, 1 Jul 2008 09:24:48 -0700
X-Authentication-Warning: old-tantale.fifi.org: Host gateway-1237.mvista.com [63.81.120.158] claimed to be dwalker1.mvista.com
Received: from dwalker1.mvista.com (localhost.localdomain [127.0.0.1])
	by dwalker1.mvista.com (8.14.1/8.14.1) with ESMTP id m61GOCIU014537;
	Tue, 1 Jul 2008 09:24:12 -0700
Received: (from dwalker@localhost)
	by dwalker1.mvista.com (8.14.1/8.14.1/Submit) id m61GOCEg014536;
	Tue, 1 Jul 2008 09:24:12 -0700
From: Daniel Walker <[email protected]>
To: Jiri Kosina <[email protected]>
Cc: Philippe Troin <[email protected]>, "Adolfo R. Brandes" <[email protected]>,
        [email protected]
Subject: [PATCH] hid: gyration sleep button quirk
Date: Tue,  1 Jul 2008 09:24:12 -0700
X-Gnus-Mail-Source: directory:~/priv/gnus/procmail
Message-Id: <[email protected]>
X-Mailer: git-send-email 1.5.5.1.1.g0dfaf8
In-Reply-To: <[email protected]>
References: <[email protected]>
Lines: 34
Xref: old-tantale.fifi.org misc:34762

This patch is based on one provided by Jiri Kosina to handle the sleep
button. I just added some cleanup and integrated it into my series.

Signed-off-by: Daniel Walker <[email protected]>
---
 drivers/hid/hid-input-quirks.c |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
drivers/hid/hid-input-quirks.c +12 -0
index e6a937a..16feea0 100644
@@ -466,6 +466,18 @@ int hidinput_event_quirks(struct hid_device *hid, struct hid_field *field, struc
 		input_event(input, usage->type, REL_WHEEL, -value);
 		return 1;
 	}
+
+	/* Gyration MCE remote "Sleep" key */
+	if (hid->vendor == VENDOR_ID_GYRATION &&
+	    hid->product == DEVICE_ID_GYRATION_REMOTE &&
+	    (usage->hid & HID_USAGE_PAGE) == HID_UP_GENDESK &&
+	    (usage->hid & 0xff) == 0x82) {
+		input_event(input, usage->type, usage->code, 1);
+		input_sync(input);
+		input_event(input, usage->type, usage->code, 0);
+		input_sync(input);
+		return 1;
+	}
 	return 0;
 }
 
Signature · 1 line
1.5.5.1.1.g0dfaf8
#6 lore raw
Quoted 1 line · Philippe Troin

For the record, the enclosed patch makes the remote work for me.

Hi Philippe,

all the code needed to support this remote control should already be merged in Linus' tree.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs