Skip to contentSkip to conversation

remove error meesage in usb_ohci.c when debug is enabled

PATCH New Gururaja Hebbar K R 2 participants 2 messages Apr 3, 2008 – Apr 6, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove error meesage in usb_ohci.c when debug is enabled

Hi,

In u-boot-1.3.1\drivers\usb\usb_ohci.c driver, if debug is enabled (#define DEBUG), make comes out with an error as below.

<snip>
<snip>
<snip>
arm-none-linux-gnueabi-gcc -g -Os -fno-strict-aliasing -fno-common
-ffixed-r8 -msoft-float -D__KERNEL__ -DTEXT_BASE=0x200000 -I/home/guru/project/u_boot/Ubuild/include2 -I/home/guru/project/u_boot/Ubuild/include -I/home/guru/project/u_boot/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /home/guru/project/original/arm-2007q3/bin/../lib/gcc/arm-none-linux-gnu eabi/4.2.1/include -pipe -DCONFIG_ARM -D__ARM__ -march=armv4 -mabi=apcs-gnu -mno-thumb-interwork -Wall -Wstrict-prototypes -c -o /home/guru/project/u_boot/Ubuild/drivers/usb/usb_ohci.o usb_ohci.c usb_ohci.c: In function 'ohci_dump':
usb_ohci.c:513: error: invalid storage class for function 'sohci_return_job'
usb_ohci.c:552: error: invalid storage class for function 'sohci_get_current_frame_number'
usb_ohci.c:569: error: invalid storage class for function 'ep_int_ballance'
usb_ohci.c:591: error: invalid storage class for function 'ep_2_n_interval'
usb_ohci.c:604: error: invalid storage class for function 'ep_rev' usb_ohci.c:619: error: invalid storage class for function 'ep_link' usb_ohci.c:690: error: invalid storage class for function 'periodic_unlink'
usb_ohci.c:711: error: invalid storage class for function 'ep_unlink' usb_ohci.c:774: error: invalid storage class for function 'ep_add_ed' usb_ohci.c:823: error: invalid storage class for function 'td_fill' usb_ohci.c:872: error: invalid storage class for function 'td_submit_job'
usb_ohci.c:944: error: invalid storage class for function 'dl_transfer_length'
usb_ohci.c:969: error: invalid storage class for function 'dl_reverse_done_list'
usb_ohci.c:1010: error: invalid storage class for function 'dl_done_list'
usb_ohci.c:1212: error: invalid storage class for function 'ohci_submit_rh_msg'
usb_ohci.c:1584: error: invalid storage class for function 'hc_reset' usb_ohci.c:1632: error: invalid storage class for function 'hc_start' usb_ohci.c:1697: error: invalid storage class for function 'hc_interrupt'
usb_ohci.c:1777: error: invalid storage class for function 'hc_release_ohci'
usb_ohci.c:1923: error: expected declaration or statement at end of input
make[1]: *** [/home/guru/project/u_boot/Ubuild/drivers/usb/usb_ohci.o] Error 1
make[1]: Leaving directory `/home/guru/project/u_boot/u-boot/drivers/usb'
make: *** [/home/guru/project/u_boot/Ubuild/drivers/usb/libusb.a] Error 2

This is due to a missing } for function ohci_dump @ line 408.

Below patch corrects the same.

Comments are welcome.

Regards
Gururaja

Signed off by: Gururaja Hebbar <[email protected]>

usb_ohci.c renamed from usb_ohci_orig.c +1 -1
@@ -414,7 +414,7 @@ static void ohci_dump (ohci_t *controlle
 		ep_print_int_eds (controller, "hcca");
 	dbg ("hcca frame #%04x", controller->hcca->frame_no);
 	ohci_dump_roothub (controller, 1);
-
+}
 #endif /* DEBUG */
 
 

/*----------------------------------------------------------------------
---*

#1 lore raw

PATCH 1/1 remove error meesage in usb_ohci.c when debug is enabled

Quoted 2 lines · Gururaja Hebbar K R

In u-boot-1.3.1\drivers\usb\usb_ohci.c driver, if debug is enabled (#define DEBUG), make comes out with an error as below.

I appreciate your help, but this has already been fixed here:

commit 2596f5b9d353ff3e4387a3325d05740f16958038

Author: Stefan Roese <[email protected]>
Date:   Wed Mar 5 12:29:32 2008 +0100

usb: Add CFG_OHCI_USE_NPS to common USB-OHCI driver

This patch adds CFG_OHCI_USE_NPS to the common USB-OHCI driver. This way a board just needs to define this new option to enable the "force
NoPowerSwitching mode" instead of adding new CPU/architecture defines
to the USB source itself.

This new option will be used first with the new AMCC 460EX Canyonlands
board port, which will be posted in a few days.

This patch also fixes a small compilation problem when DEBUG is enabled.

Quoted 5 lines

This is due to a missing } for function ohci_dump @ line 408.

Below patch corrects the same.

Comments are welcome.

Please make sure to base any patches on the newest top of git version of u-boot.

Best regards

Markus Klotzbuecher

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de