Skip to contentSkip to conversation

PXA27x USB (new) OHCI support

PATCH New Rodolfo Giometti 2 participants 5 messages Mar 6, 2007 – Apr 3, 2007

lore
Share & tools
lore

Rodolfo Giometti

author
#0 lore raw

PATCH 1/1 PXA27x USB (new) OHCI support

PXA: pxa27x USB OHCI support

Signed-off-by Rodolfo Giometti <[email protected]>

---
-------------- next part --------------

README +1 -0
index 8affdd3..7c1c88e 100644
@@ -248,6 +248,7 @@ The following options need to be configu
 		CONFIG_SA1110
 		CONFIG_ARM7
 		CONFIG_PXA250
+		CONFIG_PXA27X
 		CONFIG_CPU_MONAHANS
 
 		MicroBlaze based CPUs:
cpu/pxa/usb.c +13 -2
index 5d273cb..4ef3ac7 100644
@@ -24,15 +24,21 @@
 #include <common.h>
 
 #if defined(CONFIG_USB_OHCI_NEW) && defined(CFG_USB_OHCI_CPU_INIT)
-# ifdef CONFIG_CPU_MONAHANS
+# if defined(CONFIG_CPU_MONAHANS) || defined(CONFIG_PXA27X)
 
 #include <asm/arch/pxa-regs.h>
 
 int usb_cpu_init()
 {
+#if defined(CONFIG_CPU_MONAHANS)
 	/* Enable USB host clock. */
 	CKENA |= (CKENA_2_USBHOST |  CKENA_20_UDC);
 	udelay(100);
+#endif
+#if defined(CONFIG_PXA27X)
+	/* Enable USB host clock. */
+	CKEN |= CKEN10_USBHOST;
+#endif
 
 	/* Configure Port 2 for Host (USB Client Registers) */
 	UP2OCR = 0x3000c;

@@ -55,7 +61,12 @@ #if 0
 	UHCHR |= UHCHR_PSPL; /* USBHPWR is active low */
 #endif
 
+#if defined(CONFIG_CPU_MONAHANS)
 	UHCHR &= ~UHCHR_SSEP0;
+#endif
+#if defined(CONFIG_PXA27X)
+	UHCHR &= ~UHCHR_SSEP2;
+#endif
 	UHCHR &= ~UHCHR_SSEP1;
 	UHCHR &= ~UHCHR_SSE;
 

@@ -74,5 +85,5 @@ int usb_cpu_init_fail()
 	return 0;
 }
 
-# endif /* CONFIG_CPU_MONAHANS */
+# endif /* defined(CONFIG_CPU_MONAHANS) || defined(CONFIG_PXA27X) */
 #endif /* defined(CONFIG_USB_OHCI) && defined(CFG_USB_OHCI_CPU_INIT) */
author
#1 lore raw

PATCH 1/1 PXA27x USB (new) OHCI support

Hello,

I think also that the following settings should be implemented into platform specific code. That's why my patch:

cpu/pxa/usb.c +0 -3
index 4ef3ac7..cfe82b9 100644
@@ -40,9 +40,6 @@ int usb_cpu_init()
        CKEN |= CKEN10_USBHOST;
 #endif
 
-       /* Configure Port 2 for Host (USB Client Registers) */
-       UP2OCR = 0x3000c;
-
 #if 0
        GPIO2_2 = 0x801; /* USBHPEN - Alt. Fkt. 1 */
        GPIO3_2 = 0x801; /* USBHPWR - Alt. Fkt. 1 */

Ciao,

Rodolfo

Signature · 4 lines
GNU/Linux Solutions                  e-mail:    giometti at enneenne.com
Linux Device Driver                             giometti at gnudd.com
Embedded Systems                     		giometti at linux.it
UNIX programming                     phone:     +39 349 2432127
#2 lore raw

PATCH 1/1 PXA27x USB (new) OHCI support

Dear Rodolfo,

Quoted 2 lines · Rodolfo Giometti

I think also that the following settings should be implemented into platform specific code. That's why my patch:

Yes, you're right, I added #defines to make it Monahans specific.

Best regards

Markus

--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany

#3 lore raw

PATCH 1/1 PXA27x USB (new) OHCI support

In reply to Rodolfo Giometti

Hi Peter,

Quoted 1 line · Rodolfo Giometti

PXA: pxa27x USB OHCI support

I think this patch is more USB than ARM specific. If you agree, I'll take care it.

Regards

Markus

--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany