ALSA: hda: cs35l56: Fix lifecycle of codec pointer
PATCH 1/1 ALSA: hda: cs35l56: Fix lifecycle of codec pointer
The codec should be cleared when the amp driver is unbound and when resuming it should be tested to prevent loading firmware into the device and ALSA in a partially configured system state.
Signed-off-by Simon Trimmer <[email protected]>
--- sound/pci/hda/cs35l56_hda.c | 5 +++++ 1 file changed, 5 insertions(+)
sound/pci/hda/cs35l56_hda.c +5 -0
@@ -735,6 +735,8 @@ static void cs35l56_hda_unbind(struct device *dev, struct device *master, void *if (comps[cs35l56->index].dev == dev)memset (&comps[cs35l56->index],0 ,sizeof (*comps)); + cs35l56->codec =NULL ; +dev_dbg (cs35l56->base.dev,"Unbound\n" ); }
@@ -840,6 +842,9 @@ static int cs35l56_hda_system_resume(struct device *dev) cs35l56->suspended = false; +if (!cs35l56->codec) +return 0 ; + ret =cs35l56_is_fw_reload_needed (&cs35l56->base);dev_dbg (cs35l56->base.dev,"fw_reload_needed: %d\n" , ret);if (ret >0 ) {
Signature · 1 line
2.34.1
Takashi Iwai
AppliedQuoted 6 lines · Simon Trimmer
The codec should be cleared when the amp driver is unbound and when resuming it should be tested to prevent loading firmware into the device and ALSA in a partially configured system state.
Signed-off-by Simon Trimmer <[email protected]>
Thanks, applied.
Takashi