Skip to contentSkip to conversation

tests/avocado: add machine:none tag to version.py

PATCH In review Fabiano Rosas 2 participants 4 messages Dec 15, 2022 – Jan 9, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/avocado: add machine:none tag to version.py

This test currently fails when run on a host for which the QEMU target has no default machine set:

ERROR| Output: qemu-system-aarch64: No machine specified, and there is no default

---
 tests/avocado/version.py | 1 +
 1 file changed, 1 insertion(+)
tests/avocado/version.py +1 -0
index ded7f039c1..dd775955eb 100644
@@ -15,6 +15,7 @@
 class Version(QemuSystemTest):
     """
     :avocado: tags=quick
+    :avocado: tags=machine:none
     """
     def test_qmp_human_info_version(self):
         self.vm.add_args('-nodefaults')
Signature · 1 line
2.35.3
#1 lore raw
Quoted 16 lines · Fabiano Rosas

This test currently fails when run on a host for which the QEMU target has no default machine set:

ERROR| Output: qemu-system-aarch64: No machine specified, and there is no default

---
 tests/avocado/version.py | 1 +
 1 file changed, 1 insertion(+)
tests/avocado/version.py +0 -0
index ded7f039c1..dd775955eb 100644

tests/avocado/version.py line 21

Quoted 7 lines
tests/avocado/version.py +1 -0
@@ -15,6 +15,7 @@
 class Version(QemuSystemTest):
     """
     :avocado: tags=quick
+    :avocado: tags=machine:none
     """
     def test_qmp_human_info_version(self):
         self.vm.add_args('-nodefaults')

Ping

Reviewed-by on v1 1/1
#2 lore raw
In reply to Fabiano Rosas
Quoted 16 lines · Fabiano Rosas

This test currently fails when run on a host for which the QEMU target has no default machine set:

ERROR| Output: qemu-system-aarch64: No machine specified, and there is no default

---
  tests/avocado/version.py | 1 +
  1 file changed, 1 insertion(+)
tests/avocado/version.py +0 -0
index ded7f039c1..dd775955eb 100644

tests/avocado/version.py line 21

Quoted 7 lines
tests/avocado/version.py +1 -0
@@ -15,6 +15,7 @@
  class Version(QemuSystemTest):
      """
      :avocado: tags=quick
+    :avocado: tags=machine:none
      """
      def test_qmp_human_info_version(self):
          self.vm.add_args('-nodefaults')

Looking at previous attempt in https://lore.kernel.org/qemu-devel/[email protected]/

* tests/avocado/empty_cpu_model.py

Forced via vm.add_args('-machine', 'none')

tags=machine:none would be cleaner.

* tests/avocado/info_usernet.py and
* tests/avocado/vnc.py

-> Fixed by 5104b73824 ("tests/avocado: set -machine none for userfwd and vnc tests")

* tests/avocado/version.py

-> This patch

* tests/avocado/migration.py

=> Missing

Maybe we can squash to this patch?

Meanwhile:

#3 lore raw
Quoted 40 lines · Philippe Mathieu-Daudé
Quoted 16 lines · Fabiano Rosas

This test currently fails when run on a host for which the QEMU target has no default machine set:

ERROR| Output: qemu-system-aarch64: No machine specified, and there is no default

---
  tests/avocado/version.py | 1 +
  1 file changed, 1 insertion(+)
tests/avocado/version.py +0 -0
index ded7f039c1..dd775955eb 100644

tests/avocado/version.py line 21

Quoted 7 lines
tests/avocado/version.py +1 -0
@@ -15,6 +15,7 @@
  class Version(QemuSystemTest):
      """
      :avocado: tags=quick
+    :avocado: tags=machine:none
      """
      def test_qmp_human_info_version(self):
          self.vm.add_args('-nodefaults')

Looking at previous attempt in
https://lore.kernel.org/qemu-devel/[email protected]/

* tests/avocado/empty_cpu_model.py

Forced via vm.add_args('-machine', 'none')

tags=machine:none would be cleaner.

* tests/avocado/info_usernet.py and
* tests/avocado/vnc.py

-> Fixed by 5104b73824 ("tests/avocado: set -machine none for userfwd and vnc tests")

Quoted 7 lines

* tests/avocado/version.py

   -> This patch

* tests/avocado/migration.py

=> Missing

I think the migration test is a bit harder because the machine type would probably influnce the test. We would have to find a way to specificy the different -machine options for each architecture. Or a way of saying "use default machine, except for arm".

Quoted 5 lines

Maybe we can squash to this patch?

Meanwhile:

Thanks