Skip to contentSkip to conversation

dmaengine: xilinx_dma: call of_node_put() when breaking out of for_each_child_of_node()

PATCH In review Liu Shixin 2 participants 2 messages Nov 22, 2022

Subsystems (2)
lore
Share & tools
lore

Liu Shixin

author
#0 lore raw

PATCH 1/1 dmaengine: xilinx_dma: call of_node_put() when breaking out of for_each_child_of_node()

Since for_each_child_of_node() will increase the refcount of node, we need to call of_node_put() manually when breaking out of the iteration.

Fixes 9cd4360de609 ("dma: Add Xilinx AXI Video Direct Memory Access Engine driver support")
---
 drivers/dma/xilinx/xilinx_dma.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/dma/xilinx/xilinx_dma.c +3 -1
index 8cd4e69dc7b4..766017570488 100644
@@ -3141,8 +3141,10 @@ static int xilinx_dma_probe(struct platform_device *pdev)
 	/* Initialize the channels */
 	for_each_child_of_node(node, child) {
 		err = xilinx_dma_child_probe(xdev, child);
-		if (err < 0)
+		if (err < 0) {
+			of_node_put(child);
 			goto error;
+		}
 	}
 
 	if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) {
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Liu" == Liu Shixin <[email protected]> writes:

Since for_each_child_of_node() will increase the refcount of node, we need to call of_node_put() manually when breaking out of the iteration.

Fixes 9cd4360de609 ("dma: Add Xilinx AXI Video Direct Memory Access Engine driver support")
Quoted 23 lines
---
 drivers/dma/xilinx/xilinx_dma.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/dma/xilinx/xilinx_dma.c +3 -1
index 8cd4e69dc7b4..766017570488 100644
@@ -3141,8 +3141,10 @@ static int xilinx_dma_probe(struct platform_device *pdev)
 	/* Initialize the channels */
 	for_each_child_of_node(node, child) {
 		err = xilinx_dma_child_probe(xdev, child);
-		if (err < 0)
+		if (err < 0) {
+			of_node_put(child);
 			goto error;
+		}
 	}
 
 	if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) {
Signature · 1 line
2.25.1
Signature · 1 line
Bye, Peter Korsgaard