Skip to contentSkip to conversation

SMB client testing wiki

DISCUSSION Tom Talpey 2 participants 7 messages Aug 26, 2022 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Tom Talpey

author reviewer
#0 lore raw

The testing wiki page was last updated almost a year ago.
https://wiki.samba.org/index.php/Xfstesting-cifs

Is there an updated list of tests expected to pass, and/or any update for the scripting? Anything else I need to run in a basic local environment, to test smb3.ko client to ksmbd.ko and Samba servers on a pair of test machines?

Thanks for any suggestions.

Tom.

#1 lore raw
Quoted 4 lines · Tom Talpey

Is there an updated list of tests expected to pass, and/or any update for the scripting? Anything else I need to run in a basic local environment, to test smb3.ko client to ksmbd.ko and Samba servers on a pair of test machines?

For the testing environment, I'd say there is nothing special. Just create two shares in both samba and ksmbd servers and specify them in local.config when running xfstests. We usually name them as 'test' and 'scratch', respectively.

For testing SMB3 over samba, you would have something like this in your local.config:

[smb3samba]
FSTYP=cifs
TEST_DEV=//tom.samba/test
TEST_DIR=/mnt/test TEST_FS_MOUNT_OPTS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks' export MOUNT_OPTIONS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks' export SCRATCH_DEV=//tom.samba/scratch
export SCRATCH_MNT=/mnt/scratch

and then run xfstests

./check -s smb3samba ...

author reviewer
#2 lore raw
Quoted 24 lines · Paulo Alcantara
Quoted 4 lines · Tom Talpey

Is there an updated list of tests expected to pass, and/or any update for the scripting? Anything else I need to run in a basic local environment, to test smb3.ko client to ksmbd.ko and Samba servers on a pair of test machines?

For the testing environment, I'd say there is nothing special. Just create two shares in both samba and ksmbd servers and specify them in local.config when running xfstests. We usually name them as 'test' and 'scratch', respectively.

For testing SMB3 over samba, you would have something like this in your local.config:

   [smb3samba]
   FSTYP=cifs
   TEST_DEV=//tom.samba/test
   TEST_DIR=/mnt/test
   TEST_FS_MOUNT_OPTS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
   export MOUNT_OPTIONS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
   export SCRATCH_DEV=//tom.samba/scratch
   export SCRATCH_MNT=/mnt/scratch
Quoted 3 lines

and then run xfstests

   ./check -s smb3samba ...

Easy enough! How do I know if it "passes" though? My understanding is that a bunch of tests are expected to fail, or at least warn. Do I need to test a clean client, then compare results? Or am I misunderstanding, and FSTYP=cifs is taking care of it?

I'll probably be specifying vers=3.1.1 :)

Are MFS symlinks required to run the tests? That's a surprise.

Tom.

#3 lore raw
Quoted 4 lines · Tom Talpey

Easy enough! How do I know if it "passes" though? My understanding is that a bunch of tests are expected to fail, or at least warn. Do I need to test a clean client, then compare results? Or am I misunderstanding, and FSTYP=cifs is taking care of it?

That's a really good question. We have a pre-defined list of tests that get run by a specfic SMB version, server, if multichannel, etc.

Steve might send you the list of pre-defined tests that get run on our buildbot so you can try it out. He usually keeps those lists up-to-date.

author reviewer
#4 lore raw
Quoted 9 lines · Paulo Alcantara
Quoted 4 lines · Tom Talpey

Easy enough! How do I know if it "passes" though? My understanding is that a bunch of tests are expected to fail, or at least warn. Do I need to test a clean client, then compare results? Or am I misunderstanding, and FSTYP=cifs is taking care of it?

That's a really good question. We have a pre-defined list of tests that get run by a specfic SMB version, server, if multichannel, etc.

Yeah, there are a few exclusion files on the wiki, but they look really old. Also, I cannot believe that "vers=3.0" is the proper default, as linked there!!!

Quoted 3 lines

Steve might send you the list of pre-defined tests that get run on our buildbot so you can try it out. He usually keeps those lists up-to-date.

The buildbot doesn't do RDMA, or I'd consider that. But it's a lot more convenient to have a local harness either way.

Thanks!

Tom.

#5 lore raw
Quoted 9 lines · Tom Talpey
Quoted 7 lines · Paulo Alcantara
Quoted 4 lines · Tom Talpey

Easy enough! How do I know if it "passes" though? My understanding is that a bunch of tests are expected to fail, or at least warn. Do I need to test a clean client, then compare results? Or am I misunderstanding, and FSTYP=cifs is taking care of it?

Quoted 6 lines
Quoted 2 lines

That's a really good question. We have a pre-defined list of tests that get run by a specfic SMB version, server, if multichannel, etc.

Yeah, there are a few exclusion files on the wiki, but they look really old. Also, I cannot believe that "vers=3.0" is the proper default, as linked there!!!

Yeah :-( We should definitely update it.

Quoted 6 lines
Quoted 3 lines

Steve might send you the list of pre-defined tests that get run on our buildbot so you can try it out. He usually keeps those lists up-to-date.

The buildbot doesn't do RDMA, or I'd consider that. But it's a lot more convenient to have a local harness either way.

It currently doesn't, unfortunately. You could at least get the same set of tests that run over 3.1.1 against samba and/or ksmbd and then change mount options to get RDMA enabled. And of course, let us know when you get it working and let's add it to our buildbot as well ;-)

A message that is not in the archive (sent off-list or not yet received): CAH2r5msqW0RnNxETt=2Ec3Eq3o+RFgR+bQB6DFoCvBaNE2Hx4A@mail.gmail.com

author reviewer
#7 lore raw

Well ok, but my question is really about what to run and how to be sure I'm not breaking anything. I want to test my SMB Direct patch(es) so I'd focus on 3.1.1.

Or, can I say "it didn't oops, ship it"? :)

Tom.

Quoted 34 lines · Steve French

Nite that vers=3.0 can be much slower in some cases (like encryption) than default (or default for version 3 or higher ie vers=3 or vers=3.1.1)

On Fri, Aug 26, 2022, 09:55 Paulo Alcantara <[email protected] <mailto:[email protected]>> wrote:

Tom Talpey <[email protected] <mailto:[email protected]>> writes:

> Is there an updated list of tests expected to pass, and/or > any update for the scripting? Anything else I need to run in > a basic local environment, to test smb3.ko client to ksmbd.ko > and Samba servers on a pair of test machines?

For the testing environment, I'd say there is nothing special.  Just create two shares in both samba and ksmbd servers and specify them in local.config when running xfstests.  We usually name them as 'test' and 'scratch', respectively.

For testing SMB3 over samba, you would have something like this in your local.config:

  [smb3samba]
  FSTYP=cifs
  TEST_DEV=//tom.samba/test
  TEST_DIR=/mnt/test

TEST_FS_MOUNT_OPTS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
  export
MOUNT_OPTIONS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
  export SCRATCH_DEV=//tom.samba/scratch
  export SCRATCH_MNT=/mnt/scratch

and then run xfstests

  ./check -s smb3samba ...