Skip to contentSkip to conversation

support/docker: document the use Gitlab registry (branch yem/docker-gitlab-registry)

PATCH In review Yann E. MORIN 3 participants 8 messages Nov 23, 2021 – Dec 11, 2021

lore
Share & tools
lore
#0 lore raw

cover support/docker: document the use Gitlab registry (branch yem/docker-gitlab-registry)

Hello All!

This two-patch series changes our Dockerfile to directly use the Gitlab registry, and drop references to the Docker hub, as we no longer use it.

Regards,
Yann E. MORIN.

----------------------------------------------------------------
Yann E. MORIN (2):
support/docker: don't use sudo to build support/docker: drop use of Docker hub, use Gitlab registry

 support/docker/Dockerfile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/2 support/docker: don't use sudo to build

On a properly setup machine, it is totally useless to use sudo to run docker; it is very bad practice. Instead, users really should add themselves to the docker group.

Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 support/docker/Dockerfile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
support/docker/Dockerfile +2 -2
index 2aee129668..57445d5cd1 100644
@@ -1,7 +1,7 @@
 # This Dockerfile generates the docker image that gets used by Gitlab CI
 # To build it (YYYYMMDD.HHMM is the current date and time in UTC):
-#   sudo docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
-#   sudo docker push buildroot/base:YYYYMMDD.HHMM
+#   docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
+#   docker push buildroot/base:YYYYMMDD.HHMM
 
 # We use a specific tag for the base image *and* the corresponding date
 # for the repository., so do not forget to update the apt-sources.list
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v1 1/2
#2 lore raw

Re: [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build

Hello Yann,

Le 23/11/2021 à 21:56, Yann E. MORIN a écrit :

Quoted 16 lines

On a properly setup machine, it is totally useless to use sudo to run docker; it is very bad practice. Instead, users really should add themselves to the docker group.

Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 support/docker/Dockerfile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
support/docker/Dockerfile +0 -0
index 2aee129668..57445d5cd1 100644

support/docker/Dockerfile line 4

Quoted 6 lines
support/docker/Dockerfile +2 -2
@@ -1,7 +1,7 @@
 # This Dockerfile generates the docker image that gets used by Gitlab CI
 # To build it (YYYYMMDD.HHMM is the current date and time in UTC):
-#   sudo docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
-#   sudo docker push buildroot/base:YYYYMMDD.HHMM
+#   docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
+#   docker push buildroot/base:YYYYMMDD.HHMM

Best regards,
Romain

support/docker/Dockerfile

Quoted 4 lines
support/docker/Dockerfile +0 -0
 # We use a specific tag for the base image *and* the corresponding date
 # for the repository., so do not forget to update the apt-sources.list
 

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Re: [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build

In reply to Yann E. MORIN
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

On a properly setup machine, it is totally useless to use sudo to run docker; it is very bad practice. Instead, users really should add themselves to the docker group.

Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH 1/2] support/docker: don't use sudo to build

In reply to Yann E. MORIN
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

On a properly setup machine, it is totally useless to use sudo to run docker; it is very bad practice. Instead, users really should add themselves to the docker group.

Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Committed to 2021.02.x and 2021.08.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw

PATCH 2/2 support/docker: drop use of Docker hub, use Gitlab registry

In reply to Yann E. MORIN

Now that our pipelines are using the Docker image from the Gitlab registry, there is no longer any reason to push the image to the Docker hub.

Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 support/docker/Dockerfile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
support/docker/Dockerfile +2 -2
index 57445d5cd1..ad8704873c 100644
@@ -1,7 +1,7 @@
 # This Dockerfile generates the docker image that gets used by Gitlab CI
 # To build it (YYYYMMDD.HHMM is the current date and time in UTC):
-#   docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
-#   docker push buildroot/base:YYYYMMDD.HHMM
+#   docker build -t registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM support/docker
+#   docker push registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM
 
 # We use a specific tag for the base image *and* the corresponding date
 # for the repository., so do not forget to update the apt-sources.list
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v1 2/2
#6 lore raw

Re: [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry

Hello Yann,

Le 23/11/2021 à 21:56, Yann E. MORIN a écrit :

Quoted 16 lines

Now that our pipelines are using the Docker image from the Gitlab registry, there is no longer any reason to push the image to the Docker hub.

Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 support/docker/Dockerfile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
support/docker/Dockerfile +0 -0
index 57445d5cd1..ad8704873c 100644

support/docker/Dockerfile line 4

Quoted 6 lines
support/docker/Dockerfile +2 -2
@@ -1,7 +1,7 @@
 # This Dockerfile generates the docker image that gets used by Gitlab CI
 # To build it (YYYYMMDD.HHMM is the current date and time in UTC):
-#   docker build -t buildroot/base:YYYYMMDD.HHMM support/docker
-#   docker push buildroot/base:YYYYMMDD.HHMM
+#   docker build -t registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM support/docker
+#   docker push registry.gitlab.com/buildroot.org/buildroot/base:YYYYMMDD.HHMM

Best regards,
Romain

support/docker/Dockerfile

Quoted 4 lines
support/docker/Dockerfile +0 -0
 # We use a specific tag for the base image *and* the corresponding date
 # for the repository., so do not forget to update the apt-sources.list
 

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#7 lore raw

Re: [Buildroot] [PATCH 2/2] support/docker: drop use of Docker hub, use Gitlab registry

In reply to Yann E. MORIN
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Now that our pipelines are using the Docker image from the Gitlab registry, there is no longer any reason to push the image to the Docker hub.

Cc Romain Naour <[email protected]>
Cc Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot