Skip to contentSkip to conversation

package/libarchive: security bump to version 3.4.2

PATCH New Fabrice Fontaine 4 participants 9 messages Feb 28, 2020 – May 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 package/libarchive: security bump to version 3.4.2

- Fix CVE-2020-9308: archive_read_support_format_rar5.c in libarchive before 3.4.2 attempts to unpack a RAR5 file with an invalid or corrupted header (such as a header size of zero), leading to a SIGSEGV or possibly unspecified other impact.
- Add new mbedtls optional dependency and use --with-nettle to enable nettle support, see
https://github.com/libarchive/libarchive/commit/f96a71144b7725ca4a94d84bd27d7dca8c2f58d2

---
Changes v1 -> v2:
- Add --without-mbedtls to host variant

 package/libarchive/libarchive.hash |  2 +-
 package/libarchive/libarchive.mk   | 11 ++++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)
package/libarchive/libarchive.hash +1 -1
index b01d6368a5..9da4eb3baa 100644
@@ -1,4 +1,4 @@
 # From https://www.libarchive.de/downloads/sha256sums
-sha256  fcf87f3ad8db2e4f74f32526dee62dd1fb9894782b0a503a89c9d7a70a235191  libarchive-3.4.1.tar.gz
+sha256  b60d58d12632ecf1e8fad7316dc82c6b9738a35625746b47ecdcaf4aed176176  libarchive-3.4.2.tar.gz
 # Locally computed:
 sha256  e1e3d4ba9d0b0ccba333b5f5539f7c6c9a3ef3d57a96cd165d2c45eaa1cd026d  COPYING
package/libarchive/libarchive.mk +10 -1
index e256b72289..b7ae5fb0cf 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBARCHIVE_VERSION = 3.4.1
+LIBARCHIVE_VERSION = 3.4.2
 LIBARCHIVE_SITE = https://www.libarchive.de/downloads
 LIBARCHIVE_INSTALL_STAGING = YES
 LIBARCHIVE_LICENSE = BSD-2-Clause, BSD-3-Clause, CC0-1.0, OpenSSL, Apache-2.0
@@ -84,8 +84,16 @@ else
 LIBARCHIVE_CONF_OPTS += --without-lzo2
 endif
 
+ifeq ($(BR2_PACKAGE_MBEDTLS),y)
+LIBARCHIVE_DEPENDENCIES += mbedtls
+LIBARCHIVE_CONF_OPTS += --with-mbedtls
+else
+LIBARCHIVE_CONF_OPTS += --without-mbedtls
+endif
+
 ifeq ($(BR2_PACKAGE_NETTLE),y)
 LIBARCHIVE_DEPENDENCIES += nettle
+LIBARCHIVE_CONF_OPTS += --with-nettle
 else
 LIBARCHIVE_CONF_OPTS += --without-nettle
 endif
@@ -123,6 +131,7 @@ HOST_LIBARCHIVE_CONF_OPTS = \
 	--without-libiconv-prefix \
 	--without-xml2 \
 	--without-lzo2 \
+	--without-mbedtls \
 	--without-nettle \
 	--without-openssl \
 	--without-lzma
Signature · 1 line
2.25.0
#1 lore raw

PATCH v2 2/3 package/libarchive: add lz4 optional dependency

lz4 is available since version 3.2.0 and
https://github.com/libarchive/libarchive/commit/724f3f918e509ddca60ce62fad696d7621d3623d

---
 package/libarchive/libarchive.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/libarchive/libarchive.mk +7 -0
index b7ae5fb0cf..d07f0776a6 100644
@@ -78,6 +78,12 @@ else
 LIBARCHIVE_CONF_OPTS += --without-xml2
 endif
 
+ifeq ($(BR2_PACKAGE_LZ4),y)
+LIBARCHIVE_DEPENDENCIES += lz4
+else
+LIBARCHIVE_CONF_OPTS += --without-lz4
+endif
+
 ifeq ($(BR2_PACKAGE_LZO),y)
 LIBARCHIVE_DEPENDENCIES += lzo
 else
@@ -130,6 +136,7 @@ HOST_LIBARCHIVE_CONF_OPTS = \
 	--without-expat \
 	--without-libiconv-prefix \
 	--without-xml2 \
+	--without-lz4 \
 	--without-lzo2 \
 	--without-mbedtls \
 	--without-nettle \
Signature · 1 line
2.25.0
#2 lore raw

PATCH v2 2/3 package/libarchive: add lz4 optional dependency

Quoted 13 lines · On Fri, 28 Feb 2020 23:12:35 +0100 Fabrice Fontaine…

lz4 is available since version 3.2.0 and
https://github.com/libarchive/libarchive/commit/724f3f918e509ddca60ce62fad696d7621d3623d

---
 package/libarchive/libarchive.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/libarchive/libarchive.mk +0 -0
index b7ae5fb0cf..d07f0776a6 100644

package/libarchive/libarchive.mk else · line 82

Quoted 5 lines
package/libarchive/libarchive.mk +2 -0
@@ -78,6 +78,12 @@ else
 LIBARCHIVE_CONF_OPTS += --without-xml2
 endif
 
+ifeq ($(BR2_PACKAGE_LZ4),y)
+LIBARCHIVE_DEPENDENCIES += lz4

I've added an explicit --with-lz4 here and applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v2 2/3 package/libarchive: add lz4 optional dependency

Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 16 lines · On Fri, 28 Feb 2020 23:12:35 +0100 Fabrice Fontaine…

lz4 is available since version 3.2.0 and
https://github.com/libarchive/libarchive/commit/724f3f918e509ddca60ce62fad696d7621d3623d

---
package/libarchive/libarchive.mk | 7 +++++++

1 file changed, 7 insertions(+)
package/libarchive/libarchive.mk +0 -0
index b7ae5fb0cf..d07f0776a6 100644
@@ -78,6 +78,12 @@ else

LIBARCHIVE_CONF_OPTS += --without-xml2
endif

Quoted 4 lines

package/libarchive/libarchive.mk else · line 82

Quoted 2 lines
package/libarchive/libarchive.mk +2 -0
+ifeq ($(BR2_PACKAGE_LZ4),y)
+LIBARCHIVE_DEPENDENCIES += lz4

I've added an explicit --with-lz4 here and applied. Thanks!

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH v2 3/3 package/libarchive: add zstd optional dependency

In reply to Fabrice Fontaine

zstd is available since version 3.3.3 and
https://github.com/libarchive/libarchive/commit/26838cf5c17642f57192753cc5c3880b16b65ba3

---
 package/libarchive/libarchive.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
package/libarchive/libarchive.mk +8 -1
index d07f0776a6..c3fe63526a 100644
@@ -116,6 +116,12 @@ else
 LIBARCHIVE_CONF_OPTS += --without-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_ZSTD),y)
+LIBARCHIVE_DEPENDENCIES += zstd
+else
+LIBARCHIVE_CONF_OPTS += --without-zstd
+endif
+
 # libarchive requires LZMA with thread support in the toolchain
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS)$(BR2_PACKAGE_XZ),yy)
 LIBARCHIVE_DEPENDENCIES += xz
@@ -141,7 +147,8 @@ HOST_LIBARCHIVE_CONF_OPTS = \
 	--without-mbedtls \
 	--without-nettle \
 	--without-openssl \
-	--without-lzma
+	--without-lzma \
+	--without-zstd
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
2.25.0
#5 lore raw

PATCH v2 3/3 package/libarchive: add zstd optional dependency

Quoted 7 lines · On Fri, 28 Feb 2020 23:12:36 +0100 Fabrice Fontaine…

zstd is available since version 3.3.3 and
https://github.com/libarchive/libarchive/commit/26838cf5c17642f57192753cc5c3880b16b65ba3

---
 package/libarchive/libarchive.mk | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

I applied this one... and then reverted because in the mean time another patch from Thomas DS was merged, which was doing the same thing.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH v2 3/3 package/libarchive: add zstd optional dependency

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Quoted 3 lines · On Fri, 28 Feb 2020 23:12:36 +0100 Fabrice Fontaine…

zstd is available since version 3.3.3 and
https://github.com/libarchive/libarchive/commit/26838cf5c17642f57192753cc5c3880b16b65ba3

Quoted 7 lines
Quoted 4 lines

---
package/libarchive/libarchive.mk | 9 ++++++++-

1 file changed, 8 insertions(+), 1 deletion(-)

I applied this one... and then reverted because in the mean time another patch from Thomas DS was merged, which was doing the same thing.

Committed to 2020.02.x + the partial revert, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH v2 1/3 package/libarchive: security bump to version 3.4.2

In reply to Fabrice Fontaine

Fabrice, All,

On 2020-02-28 23:12 +0100, Fabrice Fontaine spake thusly:

Quoted 9 lines

- Fix CVE-2020-9308: archive_read_support_format_rar5.c in libarchive before 3.4.2 attempts to unpack a RAR5 file with an invalid or corrupted header (such as a header size of zero), leading to a SIGSEGV or possibly unspecified other impact.
- Add new mbedtls optional dependency and use --with-nettle to enable nettle support, see
https://github.com/libarchive/libarchive/commit/f96a71144b7725ca4a94d84bd27d7dca8c2f58d2

I applied to master, but I forcefulyl disable the new optional dependency to mbedtls for master (as it is a new feature).

Care to resend a update patch that just adds the new mbedtls dependency?

Thanks!

Regards,
Yann E. MORIN.

Quoted 63 lines

---
Changes v1 -> v2:
- Add --without-mbedtls to host variant

 package/libarchive/libarchive.hash |  2 +-
 package/libarchive/libarchive.mk   | 11 ++++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)
package/libarchive/libarchive.hash +1 -1
index b01d6368a5..9da4eb3baa 100644
@@ -1,4 +1,4 @@
 # From https://www.libarchive.de/downloads/sha256sums
-sha256  fcf87f3ad8db2e4f74f32526dee62dd1fb9894782b0a503a89c9d7a70a235191  libarchive-3.4.1.tar.gz
+sha256  b60d58d12632ecf1e8fad7316dc82c6b9738a35625746b47ecdcaf4aed176176  libarchive-3.4.2.tar.gz
 # Locally computed:
 sha256  e1e3d4ba9d0b0ccba333b5f5539f7c6c9a3ef3d57a96cd165d2c45eaa1cd026d  COPYING
package/libarchive/libarchive.mk +10 -1
index e256b72289..b7ae5fb0cf 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBARCHIVE_VERSION = 3.4.1
+LIBARCHIVE_VERSION = 3.4.2
 LIBARCHIVE_SITE = https://www.libarchive.de/downloads
 LIBARCHIVE_INSTALL_STAGING = YES
 LIBARCHIVE_LICENSE = BSD-2-Clause, BSD-3-Clause, CC0-1.0, OpenSSL, Apache-2.0
@@ -84,8 +84,16 @@ else
 LIBARCHIVE_CONF_OPTS += --without-lzo2
 endif
 
+ifeq ($(BR2_PACKAGE_MBEDTLS),y)
+LIBARCHIVE_DEPENDENCIES += mbedtls
+LIBARCHIVE_CONF_OPTS += --with-mbedtls
+else
+LIBARCHIVE_CONF_OPTS += --without-mbedtls
+endif
+
 ifeq ($(BR2_PACKAGE_NETTLE),y)
 LIBARCHIVE_DEPENDENCIES += nettle
+LIBARCHIVE_CONF_OPTS += --with-nettle
 else
 LIBARCHIVE_CONF_OPTS += --without-nettle
 endif
@@ -123,6 +131,7 @@ HOST_LIBARCHIVE_CONF_OPTS = \
 	--without-libiconv-prefix \
 	--without-xml2 \
 	--without-lzo2 \
+	--without-mbedtls \
 	--without-nettle \
 	--without-openssl \
 	--without-lzma
Signature · 6 lines
2.25.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#8 lore raw

PATCH v2 1/3 package/libarchive: security bump to version 3.4.2

In reply to Fabrice Fontaine
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

- Fix CVE-2020-9308: archive_read_support_format_rar5.c in libarchive before 3.4.2 attempts to unpack a RAR5 file with an invalid or corrupted header (such as a header size of zero), leading to a SIGSEGV or possibly unspecified other impact.
- Add new mbedtls optional dependency and use --with-nettle to enable nettle support, see
https://github.com/libarchive/libarchive/commit/f96a71144b7725ca4a94d84bd27d7dca8c2f58d2

Quoted 4 lines

---
Changes v1 -> v2:
- Add --without-mbedtls to host variant

Committed to 2019.11.x, thanks.

According to https://security-tracker.debian.org/tracker/CVE-2020-9308,
the rar5 support was only added in 3.4.0, so the 3.3.3 version we have in 2019.02.x is not affected.

Signature · 1 line
Bye, Peter Korsgaard