Skip to contentSkip to conversation

package/swupdate: add optional systemd dependency

PATCH New James Hilliard 3 participants 5 messages Mar 30, 2020 – Apr 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/swupdate: add optional systemd dependency

Fixes:
core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
27 | #include <systemd/sd-daemon.h>

      |          ^~~~~~~~~~~~~~~~~~~~~
---
 package/swupdate/swupdate.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/swupdate/swupdate.mk +4 -0
index 237a44e233..2b51edb66d 100644
@@ -110,6 +110,10 @@ SWUPDATE_MAKE_ENV += HAVE_MBEDTLS=n
 endif
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+SWUPDATE_DEPENDENCIES += systemd
+endif
+
 ifeq ($(BR2_PACKAGE_UBOOT_TOOLS),y)
 SWUPDATE_DEPENDENCIES += uboot-tools
 SWUPDATE_MAKE_ENV += HAVE_LIBUBOOTENV=y
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/swupdate: add optional systemd dependency

Quoted 4 lines · On Sun, 29 Mar 2020 18:26:49 -0600 James Hilliard <[email protected]>…

Fixes:
core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
27 | #include <systemd/sd-daemon.h>

      |          ^~~~~~~~~~~~~~~~~~~~~

Under what situations/configurations to you have this build failure. Because I don't immediately see how adding an optional dependency can fix such a build failure.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/swupdate: add optional systemd dependency

Quoted 4 lines · Thomas Petazzoni

On Sun, 29 Mar 2020 18:26:49 -0600
James Hilliard <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

Fixes:
core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
27 | #include <systemd/sd-daemon.h>

      |          ^~~~~~~~~~~~~~~~~~~~~

Under what situations/configurations to you have this build failure. Because I don't immediately see how adding an optional dependency can fix such a build failure.

It happens when this is enabled:
https://github.com/sbabic/swupdate/blob/2019.11/Kconfig#L104-L110

Quoted 8 lines

Thanks,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw

PATCH 1/1 package/swupdate: add optional systemd dependency

In reply to James Hilliard
Quoted 9 lines · On Sun, 29 Mar 2020 18:26:49 -0600 James Hilliard <[email protected]>…

Fixes:
core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
27 | #include <systemd/sd-daemon.h>

      |          ^~~~~~~~~~~~~~~~~~~~~
---
 package/swupdate/swupdate.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master with an extended commit log. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/swupdate: add optional systemd dependency

In reply to James Hilliard
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"James" == James Hilliard <[email protected]> writes:

Fixes:
core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
27 | #include <systemd/sd-daemon.h>

      |          ^~~~~~~~~~~~~~~~~~~~~

Committed to 2020.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard