Skip to contentSkip to conversation

modem-manager: depend on host-libglib2

PATCH New Aleksander Morgado 3 participants 4 messages Jun 16, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 modem-manager: depend on host-libglib2

The build requires the gdbus-codegen tool from glib2, which isn't installed in target.

---

Hey,

I'm getting build failures like this one reported via email:
http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log

Not truly sure if this is the correct fix for the issue, but it looks like it could be?

What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.

Cheers!

---
 package/modem-manager/modem-manager.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/modem-manager/modem-manager.mk +1 -1
index aa27dc9ce5..41e37bd655 100644
@@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2
 MODEM_MANAGER_INSTALL_STAGING = YES
 MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
 

--
2.22.0

#1 lore raw

PATCH 1/1 modem-manager: depend on host-libglib2

Hi Aleksander,

Quoted 26 lines · Aleksander Morgado

The build requires the gdbus-codegen tool from glib2, which isn't installed in target.

---

Hey,

I'm getting build failures like this one reported via email:
http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log

Not truly sure if this is the correct fix for the issue, but it looks like it could be?

What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.

Cheers!

---
 package/modem-manager/modem-manager.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/modem-manager/modem-manager.mk +0 -0
index aa27dc9ce5..41e37bd655 100644

package/modem-manager/modem-manager.mk MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz · line 12

Quoted 5 lines
package/modem-manager/modem-manager.mk +1 -1
@@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2

libglib2 depends on host-libglib2 already. So technically this doesn't change anything.

Have you verified that the build failure is fixed with your patch applied?

package/modem-manager/modem-manager.mk MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz · line 14

Quoted 2 lines
package/modem-manager/modem-manager.mk +0 -0
 MODEM_MANAGER_INSTALL_STAGING = YES
 MODEM_MANAGER_CONF_OPTS = --disable-more-warnings

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

#2 lore raw

PATCH 1/1 modem-manager: depend on host-libglib2

Quoted 36 lines · Aleksander Morgado
Quoted 26 lines

The build requires the gdbus-codegen tool from glib2, which isn't installed in target.

---

Hey,

I'm getting build failures like this one reported via email:
http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log

Not truly sure if this is the correct fix for the issue, but it looks like it could be?

What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.

Cheers!

---
 package/modem-manager/modem-manager.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/modem-manager/modem-manager.mk +0 -0
index aa27dc9ce5..41e37bd655 100644

package/modem-manager/modem-manager.mk MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz · line 12

Quoted 5 lines
package/modem-manager/modem-manager.mk +1 -1
@@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2

libglib2 depends on host-libglib2 already. So technically this doesn't change anything.

Quoted 3 lines

Have you verified that the build failure is fixed with your patch applied?

See, I wasn't getting the build failure locally anyway myself... so this was kind of a blind attempt of fixing this, which looks like it's totally wrong :D

I got pointed to this not-yet-commited patch, which explains my issue and why only gdbus-codegen (provided by gio) was failing and not glib-mkenums (provided by glib):
https://patchwork.ozlabs.org/patch/1115572/

The MM build failure will definitely go away once that patch is merged, sorry for the noise!

Signature · 2 lines
Aleksander
https://aleksander.es
#3 lore raw

PATCH 1/1 modem-manager: depend on host-libglib2

In reply to Baruch Siach

Baruch, Aleksander, Al,

On 2019-06-16 13:23 +0300, Baruch Siach spake thusly:

Quoted 3 lines · Aleksander Morgado
Quoted 2 lines

The build requires the gdbus-codegen tool from glib2, which isn't installed in target.

As I explained on IRC, this is already the case, via the dbus-glib -> libglib2 -? host-libglib2 dependency chain.

So, as Baruch notes, this patch would probably not solve the issue.

Instead, we have a patch that should fix the issue:

    https://patchwork.ozlabs.org/patch/1115572/

Regards,
Yann E. MORIN.

Quoted 48 lines
Quoted 23 lines

---

Hey,

I'm getting build failures like this one reported via email:
http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log

Not truly sure if this is the correct fix for the issue, but it looks like it could be?

What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.

Cheers!

---
 package/modem-manager/modem-manager.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/modem-manager/modem-manager.mk +0 -0
index aa27dc9ce5..41e37bd655 100644

package/modem-manager/modem-manager.mk MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz · line 12

Quoted 5 lines
package/modem-manager/modem-manager.mk +1 -1
@@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
 MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
 MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2

libglib2 depends on host-libglib2 already. So technically this doesn't change anything.

Have you verified that the build failure is fixed with your patch applied?

package/modem-manager/modem-manager.mk MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz · line 14

Quoted 2 lines
package/modem-manager/modem-manager.mk +0 -0
 MODEM_MANAGER_INSTALL_STAGING = YES
 MODEM_MANAGER_CONF_OPTS = --disable-more-warnings

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'