Skip to contentSkip to conversation

package/mender: fixing init script naming

PATCH New Angelo Compagnucci 2 participants 4 messages Feb 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mender: fixing init script naming

The installed systemv script should be name S42mender and not S04mender.

---
 package/mender/mender.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/mender/mender.mk +2 -2
index 0d71938..ae5bcb8 100644
@@ -70,8 +70,8 @@ define MENDER_INSTALL_INIT_SYSTEMD
 endef
 
 define MENDER_INSTALL_INIT_SYSV
-	$(INSTALL) -D -m 755 package/mender/S04mender \
-		$(TARGET_DIR)/etc/init.d/S04mender
+	$(INSTALL) -D -m 755 package/mender/S42mender \
+		$(TARGET_DIR)/etc/init.d/S42mender
 endef
 
 $(eval $(golang-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/mender: fixing init script naming

Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Angelo" == Angelo Compagnucci <[email protected]> writes:

The installed systemv script should be name S42mender and not S04mender.

You forgot to explain _WHY_, E.G. that mender needs the network to be up before it starts (presumably?)

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/mender: fixing init script naming

Quoted 7 lines · Peter Korsgaard
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Angelo" == Angelo Compagnucci <[email protected]> writes:

The installed systemv script should be name S42mender and not S04mender.

You forgot to explain _WHY_, E.G. that mender needs the network to be up before it starts (presumably?)

It's simply a bug, the init script is already named that way!

Quoted 3 lines

--
Bye, Peter Korsgaard

#3 lore raw

PATCH 1/1 package/mender: fixing init script naming

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Angelo" == Angelo Compagnucci <[email protected]> writes:

Quoted 1 line · Peter Korsgaard
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Angelo" == Angelo Compagnucci <[email protected]> writes:

The installed systemv script should be name S42mender and not S04mender.

You forgot to explain _WHY_, E.G. that mender needs the network to be up before it starts (presumably?)

It's simply a bug, the init script is already named that way!

Ahh, ok - That wasn't clear from the description. Committed with the commit log tweaked, thanks.

Signature · 1 line
Bye, Peter Korsgaard