minizip: fix display of comment

PATCH New Fabrice Fontaine 2 participants 7 messages Dec 2, 2018

Share & tools

Fabrice Fontaine

author

2018-12-02 10:24 UTC #0 lore raw

PATCH 1/1 minizip: fix display of comment

Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "minizip needs a toolchain w/ threads, wchar"

Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)

Signed-off-by Fabrice Fontaine <[email protected]>

---
 package/minizip/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/minizip/Config.in +1 -1

index 4bc12a0d7e..ff8b5b209a 100644
@@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
 
 comment "minizip needs a toolchain w/ threads, wchar"
 	depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

Signature · 1 line

2.17.1

Baruch Siach

2018-12-02 10:32 UTC #1 lore raw

PATCH 1/1 minizip: fix display of comment

Hi Fabrice,

Quoted 3 lines · Fabrice Fontaine

Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "minizip needs a toolchain w/ threads, wchar"

Why is it wrong? This dependency is meant to hide the comment in the !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) case.

Quoted 13 lines

Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/minizip/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/minizip/Config.in +0 -0
index 4bc12a0d7e..ff8b5b209a 100644

package/minizip/Config.in config BR2_PACKAGE_MINIZIP_DEMOS · line 24

Quoted 6 lines

package/minizip/Config.in +1 -1

@@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
 
 comment "minizip needs a toolchain w/ threads, wchar"
 	depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-	depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Fabrice Fontaine

author

2018-12-02 11:23 UTC #2 lore raw

PATCH 1/1 minizip: fix display of comment

Dear Baruch,

Le dim. 2 d?c. 2018 ? 11:32, Baruch Siach <[email protected]> a ?crit :

Quoted 10 lines

Hi Fabrice,
Quoted 3 lines · Fabrice Fontaine
Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "minizip needs a toolchain w/ threads, wchar"
Why is it wrong? This dependency is meant to hide the comment in the !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) case.

It is wrong because, in commit e13855c48f21eaee07a81f8b02678839be274a45, I added in minizip/Config.in (and in libbsd/Config.in):
config BR2_PACKAGE_MINIZIP
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) # libbsd
[...]
comment "minizip needs a toolchain w/ threads, wchar"

    depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
    depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

As a result, the comment is not displayed with an uclibc toolchain with MMU but without wchar.
So, the user don't know that it has just to select wchar to be able to select minizip.

Quoted 23 lines

Quoted 14 lines
Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/minizip/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/minizip/Config.in +0 -0
index 4bc12a0d7e..ff8b5b209a 100644
package/minizip/Config.in config BR2_PACKAGE_MINIZIP_DEMOS · line 24
Quoted 6 lines
package/minizip/Config.in +1 -1
@@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
 
 comment "minizip needs a toolchain w/ threads, wchar"
      depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-     depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+     depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
      depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
baruch

Quoted 4 lines

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Best Regards,

Fabrice

Baruch Siach

2018-12-02 11:56 UTC #3 lore raw

PATCH 1/1 minizip: fix display of comment

Hi Fabrice,

Quoted 18 lines · Fabrice Fontaine

Le dim. 2 d?c. 2018 ? 11:32, Baruch Siach <[email protected]> a ?crit :
Quoted 10 lines
Hi Fabrice,
Quoted 3 lines · Fabrice Fontaine
Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "minizip needs a toolchain w/ threads, wchar"
Why is it wrong? This dependency is meant to hide the comment in the !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) case.
It is wrong because, in commit e13855c48f21eaee07a81f8b02678839be274a45, I added in minizip/Config.in (and in libbsd/Config.in):
config BR2_PACKAGE_MINIZIP
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) # libbsd
[...]
comment "minizip needs a toolchain w/ threads, wchar"

Quoted 7 lines

    depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
    depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
As a result, the comment is not displayed with an uclibc toolchain with MMU but without wchar.
So, the user don't know that it has just to select wchar to be able to select minizip.

I always find negative logic confusing, so let's do it one step at a time.

In the case of non wchar uClibc toolchain with MMU:

The expression

  depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU

is true because both conditions are true.

The expression

  depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

is also true because the right condition (!BR2_USE_WCHAR) is true.

End result: the comment is displayed.

What is the issue you are fixing here?

The same question applies to your libbsd patch.

baruch

Quoted 19 lines

Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)

Signed-off-by Fabrice Fontaine <[email protected]>

---
 package/minizip/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/minizip/Config.in +1 -1

index 4bc12a0d7e..ff8b5b209a 100644
@@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
 
 comment "minizip needs a toolchain w/ threads, wchar"
      depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-     depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+     depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
      depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Fabrice Fontaine

author

2018-12-02 12:07 UTC #4 lore raw

PATCH 1/1 minizip: fix display of comment

Dear Baruch
Le dim. 2 d?c. 2018 ? 12:56, Baruch Siach <[email protected]> a ?crit :

Quoted 33 lines

Hi Fabrice,
Quoted 18 lines · Fabrice Fontaine
Le dim. 2 d?c. 2018 ? 11:32, Baruch Siach <[email protected]> a ?crit :
Quoted 10 lines
Hi Fabrice,
Quoted 3 lines · Fabrice Fontaine
Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "minizip needs a toolchain w/ threads, wchar"
Why is it wrong? This dependency is meant to hide the comment in the !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) case.
It is wrong because, in commit e13855c48f21eaee07a81f8b02678839be274a45, I added in minizip/Config.in (and in libbsd/Config.in):
config BR2_PACKAGE_MINIZIP
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) # libbsd
[...]
comment "minizip needs a toolchain w/ threads, wchar"
Quoted 7 lines
    depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
    depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
As a result, the comment is not displayed with an uclibc toolchain with MMU but without wchar.
So, the user don't know that it has just to select wchar to be able to select minizip.
I always find negative logic confusing, so let's do it one step at a time.

Quoted 7 lines

In the case of non wchar uClibc toolchain with MMU:
The expression
  depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
is true because both conditions are true.

Nope, in case of uClibc toolchain with MMU, BR2_USE_MMU is true and so !BR2_USE_MMU is false. So the latest condition is false.

Quoted 29 lines

The expression
  depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
is also true because the right condition (!BR2_USE_WCHAR) is true.
End result: the comment is displayed.
What is the issue you are fixing here?
The same question applies to your libbsd patch.
baruch
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/minizip/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/minizip/Config.in +0 -0
index 4bc12a0d7e..ff8b5b209a 100644
@@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
 

Quoted 10 lines

Quoted 5 lines
Quoted 5 lines
package/minizip/Config.in config BR2_PACKAGE_MINIZIP_DEMOS · line 24
Quoted 5 lines
package/minizip/Config.in +1 -1
 comment "minizip needs a toolchain w/ threads, wchar"
      depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-     depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+     depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
      depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Best Regards,

Fabrice

Baruch Siach

2018-12-02 13:41 UTC #5 lore raw

PATCH 1/1 minizip: fix display of comment

Hi Fabrice,

Quoted 30 lines · Fabrice Fontaine

Le dim. 2 d?c. 2018 ? 12:56, Baruch Siach <[email protected]> a ?crit :
Quoted 29 lines
Quoted 15 lines · Fabrice Fontaine
Le dim. 2 d?c. 2018 ? 11:32, Baruch Siach <[email protected]> a ?crit :
Quoted 7 lines
Quoted 3 lines · Fabrice Fontaine
Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "minizip needs a toolchain w/ threads, wchar"
Why is it wrong? This dependency is meant to hide the comment in the !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) case.
It is wrong because, in commit e13855c48f21eaee07a81f8b02678839be274a45, I added in minizip/Config.in (and in libbsd/Config.in):
config BR2_PACKAGE_MINIZIP
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) # libbsd
[...]
comment "minizip needs a toolchain w/ threads, wchar"
Quoted 7 lines
    depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
    depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
As a result, the comment is not displayed with an uclibc toolchain with MMU but without wchar.
So, the user don't know that it has just to select wchar to be able to select minizip.
I always find negative logic confusing, so let's do it one step at a time.
In the case of non wchar uClibc toolchain with MMU:

Quoted 7 lines

Quoted 5 lines
The expression
  depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
is true because both conditions are true.
Nope, in case of uClibc toolchain with MMU, BR2_USE_MMU is true and so !BR2_USE_MMU is false. So the latest condition is false.

You are right. Sorry for the noise.

baruch

Quoted 33 lines

Quoted 33 lines
The expression
  depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
is also true because the right condition (!BR2_USE_WCHAR) is true.
End result: the comment is displayed.
What is the issue you are fixing here?
The same question applies to your libbsd patch.
baruch
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/minizip/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/minizip/Config.in +1 -1
index 4bc12a0d7e..ff8b5b209a 100644
@@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
 
 comment "minizip needs a toolchain w/ threads, wchar"
      depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-     depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+     depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
      depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Fabrice Fontaine

author

2018-12-02 13:44 UTC #6 lore raw

PATCH 1/1 minizip: fix display of comment

Le dim. 2 d?c. 2018 ? 14:41, Baruch Siach <[email protected]> a ?crit :

Quoted 36 lines

Hi Fabrice,
Quoted 32 lines · Fabrice Fontaine
Le dim. 2 d?c. 2018 ? 12:56, Baruch Siach <[email protected]> a ?crit :
Quoted 31 lines
Quoted 15 lines · Fabrice Fontaine
Le dim. 2 d?c. 2018 ? 11:32, Baruch Siach <[email protected]> a ?crit :
Quoted 7 lines
Quoted 3 lines · Fabrice Fontaine
Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "minizip needs a toolchain w/ threads, wchar"
Why is it wrong? This dependency is meant to hide the comment in the !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) case.
It is wrong because, in commit e13855c48f21eaee07a81f8b02678839be274a45, I added in minizip/Config.in (and in libbsd/Config.in):
config BR2_PACKAGE_MINIZIP
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU) # libbsd
[...]
comment "minizip needs a toolchain w/ threads, wchar"
Quoted 7 lines
    depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
    depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
As a result, the comment is not displayed with an uclibc toolchain with MMU but without wchar.
So, the user don't know that it has just to select wchar to be able to select minizip.
I always find negative logic confusing, so let's do it one step at a time.
In the case of non wchar uClibc toolchain with MMU:
The expression

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
  depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
is true because both conditions are true.
Nope, in case of uClibc toolchain with MMU, BR2_USE_MMU is true and so !BR2_USE_MMU is false. So the latest condition is false.
You are right. Sorry for the noise.

That's fine, I should have made it right the first time ;-)

Quoted 31 lines

baruch
Quoted 28 lines
Quoted 28 lines
The expression
  depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
is also true because the right condition (!BR2_USE_WCHAR) is true.
End result: the comment is displayed.
What is the issue you are fixing here?
The same question applies to your libbsd patch.
baruch
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/minizip/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/minizip/Config.in +0 -0
index 4bc12a0d7e..ff8b5b209a 100644
@@ -20,5 +20,5 @@ config BR2_PACKAGE_MINIZIP_DEMOS
 

Quoted 10 lines

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
package/minizip/Config.in config BR2_PACKAGE_MINIZIP_DEMOS · line 24
Quoted 5 lines
package/minizip/Config.in +1 -1
 comment "minizip needs a toolchain w/ threads, wchar"
      depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
-     depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+     depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
      depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Fabrice