Skip to contentSkip to conversation

uboot-tools: requires host gcc 4.7+

PATCH New Baruch Siach 2 participants 6 messages Aug 7, 2018 – Aug 10, 2018

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/1 uboot-tools: requires host gcc 4.7+

U-Boot now adds -std=gnu11 when building its build utilities, like fixdep. This option is only supported since gcc version 4.7.

https://gcc.gnu.org/gcc-4.7/changes.html

Fixes:
http://autobuild.buildroot.net/results/ea0/ea09b614a3c10d494939d9551c0c3bfca4626ece/
http://autobuild.buildroot.net/results/f8e/f8efd9af4d86c51fe4f5afe44db9abf9adc5718f/
http://autobuild.buildroot.net/results/c0a/c0ab35c3cb46f84863fe20c0ee92ecc2379578b6/

Cc Matt Weber <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/uboot-tools/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/uboot-tools/Config.in +4 -0
index 63a058e8562a..78a8b66c4d97 100644
@@ -1,10 +1,14 @@
 config BR2_PACKAGE_UBOOT_TOOLS
 	bool "u-boot tools"
+	depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11
 	help
 	  Companion tools for Das U-Boot bootloader.
 
 	  http://www.denx.de/wiki/U-Boot/WebHome
 
+comment "u-boot tools needs host gcc >= 4.7"
+	depends on !BR2_HOST_GCC_AT_LEAST_4_7
+
 if BR2_PACKAGE_UBOOT_TOOLS
 
 config BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 uboot-tools: requires host gcc 4.7+

Quoted 23 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

U-Boot now adds -std=gnu11 when building its build utilities, like fixdep. This option is only supported since gcc version 4.7.

https://gcc.gnu.org/gcc-4.7/changes.html

Fixes:
http://autobuild.buildroot.net/results/ea0/ea09b614a3c10d494939d9551c0c3bfca4626ece/
http://autobuild.buildroot.net/results/f8e/f8efd9af4d86c51fe4f5afe44db9abf9adc5718f/
http://autobuild.buildroot.net/results/c0a/c0ab35c3cb46f84863fe20c0ee92ecc2379578b6/

Cc Matt Weber <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/uboot-tools/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/uboot-tools/Config.in +0 -0
index 63a058e8562a..78a8b66c4d97 100644

package/uboot-tools/Config.in line 3

Quoted 3 lines
package/uboot-tools/Config.in +1 -0
@@ -1,10 +1,14 @@
 config BR2_PACKAGE_UBOOT_TOOLS
 	bool "u-boot tools"
+	depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11

What about host-uboot-tools?

Signature · 1 line
Bye, Peter Korsgaard
author
#2 lore raw

PATCH 1/1 uboot-tools: requires host gcc 4.7+

Hi Peter,

Quoted 18 lines · Peter Korsgaard
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

U-Boot now adds -std=gnu11 when building its build utilities, like fixdep. This option is only supported since gcc version 4.7.

https://gcc.gnu.org/gcc-4.7/changes.html

Fixes:
http://autobuild.buildroot.net/results/ea0/ea09b614a3c10d494939d9551c0c3bfca4626ece/
http://autobuild.buildroot.net/results/f8e/f8efd9af4d86c51fe4f5afe44db9abf9adc5718f/
http://autobuild.buildroot.net/results/c0a/c0ab35c3cb46f84863fe20c0ee92ecc2379578b6/

Cc Matt Weber <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/uboot-tools/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
Quoted 10 lines

package/uboot-tools/Config.in line 3

Quoted 8 lines
package/uboot-tools/Config.in +1 -0
index 63a058e8562a..78a8b66c4d97 100644
@@ -1,10 +1,14 @@
 config BR2_PACKAGE_UBOOT_TOOLS
 	bool "u-boot tools"
+	depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11

What about host-uboot-tools?

The only config symbols that builds host-uboot-tools is BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on BR2_HOST_GCC_AT_LEAST_4_7, right?

AFAIU, there is no way to directly make host packages depend on Kconfig symbols.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#3 lore raw

PATCH 1/1 uboot-tools: requires host gcc 4.7+

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 5 lines

package/uboot-tools/Config.in line 3

Quoted 3 lines

config BR2_PACKAGE_UBOOT_TOOLS

package/uboot-tools/Config.in +1 -0
 	bool "u-boot tools"
+	depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11

What about host-uboot-tools?

Quoted 6 lines

The only config symbols that builds host-uboot-tools is BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on BR2_HOST_GCC_AT_LEAST_4_7, right?

AFAIU, there is no way to directly make host packages depend on Kconfig symbols.

Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and a number of places where it is selected?

Signature · 1 line
Bye, Peter Korsgaard
author
#4 lore raw

PATCH 1/1 uboot-tools: requires host gcc 4.7+

Hi Peter,

Quoted 11 lines · Peter Korsgaard
Quoted 10 lines
Quoted 6 lines

package/uboot-tools/Config.in line 3

Quoted 4 lines
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

config BR2_PACKAGE_UBOOT_TOOLS

package/uboot-tools/Config.in +1 -0
 	bool "u-boot tools"
+	depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11

What about host-uboot-tools?

The only config symbols that builds host-uboot-tools is BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on BR2_HOST_GCC_AT_LEAST_4_7, right?

Quoted 5 lines
Quoted 2 lines

AFAIU, there is no way to directly make host packages depend on Kconfig symbols.

Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and a number of places where it is selected?

I see. I'll run another build just to verify that -std=gnu11 is used in host-uboot-tools, and send another patch.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#5 lore raw

PATCH 1/1 uboot-tools: requires host gcc 4.7+

Hi Peter,

Quoted 12 lines · Baruch Siach
Quoted 11 lines · Peter Korsgaard
Quoted 10 lines
Quoted 6 lines

package/uboot-tools/Config.in line 3

Quoted 4 lines
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

config BR2_PACKAGE_UBOOT_TOOLS

package/uboot-tools/Config.in +1 -0
 	bool "u-boot tools"
+	depends on BR2_HOST_GCC_AT_LEAST_4_7 # -std=gnu11

What about host-uboot-tools?

The only config symbols that builds host-uboot-tools is BR2_PACKAGE_XVISOR_CREATE_UBOOT_IMAGE. So we should make it depend on BR2_HOST_GCC_AT_LEAST_4_7, right?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

AFAIU, there is no way to directly make host packages depend on Kconfig symbols.

Ehh, but we do have a Config.in.host / BR2_PACKAGE_HOST_UBOOT_TOOLS, and a number of places where it is selected?

I see. I'll run another build just to verify that -std=gnu11 is used in host-uboot-tools, and send another patch.

It turns out that host-uboot-tools is not affected. That's because we force host CFLAGS in HOST_UBOOT_TOOLS_MAKE_OPTS. I posted a patch that does the same for uboot-tools, and marked this patch as Rejected.

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -