Skip to contentSkip to conversation

ARM: mvebu: add reference to ETH connectors for A385-AP

PATCH New Thomas Petazzoni 5 participants 5 messages Nov 17, 2015 – Nov 23, 2015 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mvebu: add reference to ETH connectors for A385-AP

This commit adds some comments to the Armada 385 AP Device Tree description to indicate which Ethernet interface matches which physical connector on the board.

This is especially useful on this board, since the mapping between the logical interface names and the physical ports is not very straightforward. It also doesn't match the numbering of the interfaces done by U-Boot:

U-Boot interface | Linux interface | Physical port
-----------------+-----------------+--------------

   egiga0         |     eth2        |   CON4
   egiga1         |     eth0        |   CON2
   egiga2         |     eth1        |   CON3

-----------------+-----------------+--------------

---
 arch/arm/boot/dts/armada-385-db-ap.dts | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/boot/dts/armada-385-db-ap.dts +3 -0
index 4047621..408b813 100644
@@ -132,18 +132,21 @@
 				};
 			};
 
+			/* CON3 */
 			ethernet at 30000 {
 				status = "okay";
 				phy = <&phy2>;
 				phy-mode = "sgmii";
 			};
 
+			/* CON2 */
 			ethernet at 34000 {
 				status = "okay";
 				phy = <&phy1>;
 				phy-mode = "sgmii";
 			};
 
+			/* CON4 */
 			ethernet at 70000 {
 				pinctrl-names = "default";
 
Signature · 1 line
2.6.3
#1 lore raw

PATCH 1/1 ARM: mvebu: add reference to ETH connectors for A385-AP

Quoted 11 lines · On Tuesday 17 November 2015 16:53:40 Thomas Petazzoni wrote:

This commit adds some comments to the Armada 385 AP Device Tree description to indicate which Ethernet interface matches which physical connector on the board.

This is especially useful on this board, since the mapping between the logical interface names and the physical ports is not very straightforward. It also doesn't match the numbering of the interfaces done by U-Boot:

U-Boot interface | Linux interface | Physical port
-----------------+-----------------+--------------

Quoted 8 lines
   egiga0         |     eth2        |   CON4
   egiga1         |     eth0        |   CON2
   egiga2         |     eth1        |   CON3

-----------------+-----------------+--------------

Would it be possible to use entries in /aliases to fix the order of the interfaces and make them match the physical ports?

Arnd

#2 lore raw

PATCH 1/1 ARM: mvebu: add reference to ETH connectors for A385-AP

Quoted 17 lines · Arnd Bergmann
Quoted 16 lines · On Tuesday 17 November 2015 16:53:40 Thomas Petazzoni wrote:

This commit adds some comments to the Armada 385 AP Device Tree description to indicate which Ethernet interface matches which physical connector on the board.

This is especially useful on this board, since the mapping between the logical interface names and the physical ports is not very straightforward. It also doesn't match the numbering of the interfaces done by U-Boot:

U-Boot interface | Linux interface | Physical port
-----------------+-----------------+--------------

   egiga0         |     eth2        |   CON4
   egiga1         |     eth0        |   CON2
   egiga2         |     eth1        |   CON3

-----------------+-----------------+--------------

Quoted 6 lines
Quoted 3 lines

Would it be possible to use entries in /aliases to fix the order of the interfaces and make them match the physical ports?

Unfortunately not, and I believe davem is averse to "fixing" this problem in the kernel. It's really problematical, especially if you are running a debian based distro and want to be able to say "I want egiga0 configured like _this_". You're entirely at the mercy of the ordering that the DT compiler decides to place the nodes, and the ordering which the kernel decides to probe the interfaces, etc.

Yes, there's always the ethernet MAC which can be used to identify them, but debian at least doesn't have a way to identify interfaces in its /etc/network/interfaces file by ethernet MAC.

So, use the modern network-manager daemon... umm no, not if you want to use bridging or any of the other such facilities.

This whole area is really very annoying.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#3 lore raw

PATCH 1/1 ARM: mvebu: add reference to ETH connectors for A385-AP

Hi,

How about swapping the ethernet@ entries in the board DT files to gain following order:
ethernet at 70000
...
ethernet at 30000
...
ethernet at 34000

I know this would introduce deviation from epapr rules, but it always worked for me.

Best regards,
Marcin

2015-11-17 17:21 GMT+01:00 Russell King - ARM Linux <[email protected]>:

Quoted 49 lines · Arnd Bergmann
Quoted 17 lines · On Tuesday 17 November 2015 16:53:40 Thomas Petazzoni wrote:
Quoted 16 lines

This commit adds some comments to the Armada 385 AP Device Tree description to indicate which Ethernet interface matches which physical connector on the board.

This is especially useful on this board, since the mapping between the logical interface names and the physical ports is not very straightforward. It also doesn't match the numbering of the interfaces done by U-Boot:

U-Boot interface | Linux interface | Physical port
-----------------+-----------------+--------------

   egiga0         |     eth2        |   CON4
   egiga1         |     eth0        |   CON2
   egiga2         |     eth1        |   CON3

-----------------+-----------------+--------------

Quoted 6 lines
Quoted 3 lines

Would it be possible to use entries in /aliases to fix the order of the interfaces and make them match the physical ports?

Unfortunately not, and I believe davem is averse to "fixing" this problem in the kernel. It's really problematical, especially if you are running a debian based distro and want to be able to say "I want egiga0 configured like _this_". You're entirely at the mercy of the ordering that the DT compiler decides to place the nodes, and the ordering which the kernel decides to probe the interfaces, etc.

Yes, there's always the ethernet MAC which can be used to identify them, but debian at least doesn't have a way to identify interfaces in its /etc/network/interfaces file by ethernet MAC.

So, use the modern network-manager daemon... umm no, not if you want to use bridging or any of the other such facilities.

This whole area is really very annoying.

--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw

PATCH 1/1 ARM: mvebu: add reference to ETH connectors for A385-AP

Hi Marcin,

Quoted 10 lines · Marcin Wojtas

Hi,

How about swapping the ethernet@ entries in the board DT files to gain following order:
ethernet at 70000
...
ethernet at 30000
...
ethernet at 34000

Quoted 2 lines

I know this would introduce deviation from epapr rules, but it always worked for me.

Given there is no other solution, for my side I would agree on such change with the accurate comments inside the dts at the place we should fine the node.

Gregory

Quoted 54 lines

Best regards,
Marcin

2015-11-17 17:21 GMT+01:00 Russell King - ARM Linux <[email protected]>:

Quoted 49 lines · Arnd Bergmann
Quoted 17 lines · On Tuesday 17 November 2015 16:53:40 Thomas Petazzoni wrote:
Quoted 16 lines

This commit adds some comments to the Armada 385 AP Device Tree description to indicate which Ethernet interface matches which physical connector on the board.

This is especially useful on this board, since the mapping between the logical interface names and the physical ports is not very straightforward. It also doesn't match the numbering of the interfaces done by U-Boot:

U-Boot interface | Linux interface | Physical port
-----------------+-----------------+--------------

   egiga0         |     eth2        |   CON4
   egiga1         |     eth0        |   CON2
   egiga2         |     eth1        |   CON3

-----------------+-----------------+--------------

Quoted 6 lines
Quoted 3 lines

Would it be possible to use entries in /aliases to fix the order of the interfaces and make them match the physical ports?

Unfortunately not, and I believe davem is averse to "fixing" this problem in the kernel. It's really problematical, especially if you are running a debian based distro and want to be able to say "I want egiga0 configured like _this_". You're entirely at the mercy of the ordering that the DT compiler decides to place the nodes, and the ordering which the kernel decides to probe the interfaces, etc.

Yes, there's always the ethernet MAC which can be used to identify them, but debian at least doesn't have a way to identify interfaces in its /etc/network/interfaces file by ethernet MAC.

So, use the modern network-manager daemon... umm no, not if you want to use bridging or any of the other such facilities.

This whole area is really very annoying.

--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com