Skip to contentSkip to conversation

jack2: force host-python dependency for waf build-system

PATCH New Samuel Martin 2 participants 2 messages May 14, 2014 – May 16, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 jack2: force host-python dependency for waf build-system

jack2 uses Waf 1.6.11. The waf configure program combines a part of python script with a compiled blob. According to Waf documentation, waf currently supports python interpreter from version 2.3 to 3.1.

However, Buildroot provides python-3.4. So, let's uses host python2 interpreter for building jack2.

This patch also cleanup whitespace, replacing wrongly used spaces with tabs.

Fixed:
http://autobuild.buildroot.net/results/913/913bb1836076be9f201bf6641c7614708d6916bc/

Cc Thomas Petazzoni <[email protected]>
---
 package/jack2/jack2.mk | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
package/jack2/jack2.mk +7 -6
index f2ded00..68f6e42 100644
@@ -7,23 +7,24 @@
 JACK2_VERSION = ab409a65df95bc261ff72b52d6b3f4a65cf3266a
 JACK2_SITE = $(call github,jackaudio,jack2,$(JACK2_VERSION))
 JACK2_LICENSE = GPLv2+ (jack server), LGPLv2.1+ (jack library)
-JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib
+JACK2_DEPENDENCIES = libsamplerate libsndfile alsa-lib host-python
 
 define JACK2_CONFIGURE_CMDS
 	(cd $(@D); \
 		$(TARGET_CONFIGURE_OPTS)	\
-		./waf configure			\
+		$(HOST_DIR)/usr/bin/python2 ./waf configure \
 		--prefix=/usr			\
-                --alsa				\
-       )
+		--alsa				\
+	)
 endef
 
 define JACK2_BUILD_CMDS
-       (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+	(cd $(@D); $(HOST_DIR)/usr/bin/python2 ./waf build -j $(PARALLEL_JOBS))
 endef
 
 define JACK2_INSTALL_TARGET_CMDS
-       (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+	(cd $(@D); $(HOST_DIR)/usr/bin/python2 ./waf --destdir=$(TARGET_DIR) \
+		install)
 endef
 
 $(eval $(generic-package))
Signature · 1 line
1.9.2
#1 lore raw

PATCH 1/1 jack2: force host-python dependency for waf build-system

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Samuel" == Samuel Martin <[email protected]> writes:

jack2 uses Waf 1.6.11. The waf configure program combines a part of python script with a compiled blob. According to Waf documentation, waf currently supports python interpreter from version 2.3 to 3.1.

However, Buildroot provides python-3.4. So, let's uses host python2 interpreter for building jack2.

Quoted 8 lines

This patch also cleanup whitespace, replacing wrongly used spaces with tabs.

Fixed:
http://autobuild.buildroot.net/results/913/913bb1836076be9f201bf6641c7614708d6916bc/

Cc Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard