ARM: mvebu: Add DT entry for ReadyNAS 102 to use gpio-poweroff driver
PATCH 1/1 ARM: mvebu: Add DT entry for ReadyNAS 102 to use gpio-poweroff driver
Without that fix, at the end of the shutdown process, the board is still powered (led glowing, fan running, ...).
---
HI Jason and Andrew,
This is not per se a fix for a real problem, as the NAS runs as expected w/o it, it only solves a minor limitation of the shutdown process so I guess it can be queued for 3.13 if it is too late.
Additionally, I wonder if I should send another patch to either have ARCH_MVEBU select POWER_SUPPLY, POWER_RESET and POWER_RESET_GPIO, or have mvebu_defconfig modified to enable those, or keep things as they are until there are more users on mvebu.
arch/arm/boot/dts/armada-370-netgear-rn102.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm/boot/dts/armada-370-netgear-rn102.dts +12 -0
@@ -57,6 +57,11 @@ marvell,pins = "mpp56"; marvell,function = "gpio"; }; + + poweroff: poweroff { + marvell,pins = "mpp8"; + marvell,function = "gpio"; + }; }; mdio {
@@ -176,4 +181,11 @@ }; }; + gpio_poweroff { + compatible = "gpio-poweroff"; + pinctrl-0 = <&poweroff>; + pinctrl-names = "default"; + gpios = <&gpio0 8 1>; + }; + };
Signature · 1 line
1.8.4.rc3
Jason Cooper
AppliedPATCH 1/1 ARM: mvebu: Add DT entry for ReadyNAS 102 to use gpio-poweroff driver
Quoted 4 lines · Arnaud Ebalard
Without that fix, at the end of the shutdown process, the board is still powered (led glowing, fan running, ...).
Quoted 8 lines
Signed-off-by Arnaud Ebalard <[email protected]>---
HI Jason and Andrew,This is not per se a fix for a real problem, as the NAS runs as expected w/o it, it only solves a minor limitation of the shutdown process so I guess it can be queued for 3.13 if it is too late.
I consider a server not being able to automatically reboot unattended to be a regression. ;-)
Quoted 4 lines
Additionally, I wonder if I should send another patch to either have
ARCH_MVEBUselectPOWER_SUPPLY,POWER_RESETandPOWER_RESET_GPIO, or havemvebu_defconfigmodified to enable those, or keep things as they are until there are more users on mvebu.
I'm inclined towards select, but I also agree that there's no rush.
Quoted 2 lines
arch/arm/boot/dts/armada-370-netgear-rn102.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Applied to mvebu/fixes for v3.12.
thx,
Jason.