Skip to contentSkip to conversation

libtirpc: requires toolchain with threading support

PATCH New Samuel Martin 2 participants 2 messages Sep 13, 2013 – Sep 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 libtirpc: requires toolchain with threading support

Fixes:
http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f

---
changes v2 -> v3
* rebase on master
* minor wording fix

changes v1 -> v2
* propagate libtirpc dependency

---
 package/conntrack-tools/Config.in | 7 +++++--
 package/libtirpc/Config.in        | 4 ++++
 package/lmbench/Config.in         | 4 ++++
 package/nfs-utils/Config.in       | 6 ++++--
 package/quota/Config.in           | 7 +++++--
 package/rpcbind/Config.in         | 4 ++++
 6 files changed, 26 insertions(+), 6 deletions(-)
package/conntrack-tools/Config.in +5 -2
index 50f2000..64f18fe 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_CONNTRACK_TOOLS
 	depends on BR2_INET_IPV6
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_MMU # fork()
+	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc
 	select BR2_PACKAGE_LIBNETFILTER_CONNTRACK
 	select BR2_PACKAGE_LIBNETFILTER_CTHELPER
 	select BR2_PACKAGE_LIBNETFILTER_CTTIMEOUT
@@ -16,5 +17,7 @@ config BR2_PACKAGE_CONNTRACK_TOOLS
 
 	  http://www.netfilter.org/projects/conntrack-tools/
 
-comment "conntrack-tools requires a toolchain with IPV6 and LARGEFILE support"
-	depends on !BR2_INET_IPV6 || !BR2_LARGEFILE
+comment "conntrack-tools requires a toolchain with IPV6, LARGEFILE and threading support"
+	depends on !BR2_INET_IPV6 || \
+		!BR2_LARGEFILE || \
+		!(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
package/libtirpc/Config.in +4 -0
index b9db5aa..eab4f3e 100644
@@ -7,8 +7,12 @@ config BR2_PACKAGE_LIBTIRPC
 	# used instead of libtirpc.
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
 		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Libtirpc is a port of Sun's Transport-Independent RPC
 	  library to Linux.
 
 	  http://sourceforge.net/projects/libtirpc/
+
+comment "libtirpc requires a toolchain with threading support"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/lmbench/Config.in +4 -0
index d710e1f..c7b656c 100644
@@ -1,8 +1,12 @@
 config BR2_PACKAGE_LMBENCH
 	bool "lmbench"
+	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc
 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	help
 	  LMbench is a suite of simple, portable,
 	  ANSI/C microbenchmarks for UNIX/POSIX.
 
 	  http://sourceforge.net/projects/lmbench/
+
+comment "lmbench requires a toolchain with threading support"
+	depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
package/nfs-utils/Config.in +4 -2
index fa35f35..8f61f2b 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_NFS_UTILS
 	bool "nfs-utils"
+	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc
 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	depends on BR2_LARGEFILE
 	help
@@ -9,8 +10,9 @@ config BR2_PACKAGE_NFS_UTILS
 
 	  http://sourceforge.net/projects/nfs
 
-comment "nfs-utils requires a toolchain with LARGEFILE support"
-	depends on !BR2_LARGEFILE
+comment "nfs-utils requires a toolchain with LARGEFILE and threading support"
+	depends on !BR2_LARGEFILE || \
+		!(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
 
 menu "NFS utilities selection"
 	depends on BR2_PACKAGE_NFS_UTILS
package/quota/Config.in +5 -2
index 5127a9a..57cf57d 100644
@@ -4,6 +4,7 @@ config BR2_PACKAGE_QUOTA
 	depends on BR2_USE_WCHAR
 	depends on BR2_USE_MMU # fork()
 	depends on !(BR2_microblazeel || BR2_microblazebe) # util-linux
+	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC || BR2_TOOLCHAIN_HAS_THREADS # libtirpc
 	select BR2_PACKAGE_UTIL_LINUX
 	select BR2_PACKAGE_UTIL_LINUX_BINARIES
 	select BR2_PACKAGE_UTIL_LINUX_MOUNT
@@ -14,5 +15,7 @@ config BR2_PACKAGE_QUOTA
 
 	  http://sourceforge.net/projects/linuxquota/
 
-comment "quota requires a toolchain with LARGEFILE + WCHAR support"
-	depends on !(BR2_LARGEFILE && BR2_USE_WCHAR)
+comment "quota requires a toolchain with LARGEFILE, WCHAR and threading support"
+	depends on !BR2_LARGEFILE || \
+		!BR2_USE_WCHAR || \
+		!(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
package/rpcbind/Config.in +4 -0
index cbe53af..663313b 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_RPCBIND
 	bool "rpcbind"
 	# We really need libtirpc and can't work with the native RPC
 	# implementation of toolchains.
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libtirpc
 	select BR2_PACKAGE_LIBTIRPC
 	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
 	# support, needed for libtirpc
@@ -10,3 +11,6 @@ config BR2_PACKAGE_RPCBIND
 	help
 	  The rpcbind utility is a server that converts RPC program numbers
 	  into universal addresses.
+
+comment "rpcbind requires a toolchain with threading support"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.4
#1 lore raw

PATCH v3 1/1 libtirpc: requires toolchain with threading support

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Samuel" == Samuel Martin <[email protected]> writes:

Samuel> Fixes:
Samuel> http://autobuild.buildroot.org/results/8ba720f47f74df94b8c70ac4befd47c47ce65f2f

Samuel> Signed-off-by: Gilles Talis <[email protected]> Samuel> Signed-off-by: "Samuel Martin" <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard