Skip to contentSkip to conversation

config: make it possible to specify which config file to use for 'make defconfig'

PATCH RESEND New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Apr 28, 2012 – May 5, 2012 Kbuild

lore
Share & tools
lore

Arnout Vandecappelle (Essensium/Mind)

author
#0 lore raw

PATCH RESEND v3 1/1 config: make it possible to specify which config file to use for 'make defconfig'

So that this works:

% make defconfig BR2_DEFCONFIG=~/buildroot-defconfig

Right now we have to do:

% cp ~/buildroot-defconfig configs/buildroot_defconfig % make buildroot_defconfig

That would dirty the buildroot tree and requires it to be writable.

Signed-off-by Felipe Contreras <[email protected]>
Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Acked-by Luca Ceresoli <[email protected]>
Acked-by Thomas Petazzoni <[email protected]>

---
v3:
* Acked by ThomasP

v2:
* Use $(if...) instead of $(patsubst...)
* Add help text
* Fix commit message

 Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Makefile +2 -1
index cc8124a..a7625ba 100644
@@ -540,7 +540,7 @@ silentoldconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 
 defconfig: $(BUILD_DIR)/buildroot-config/conf outputmakefile
 	@mkdir -p $(BUILD_DIR)/buildroot-config
-	@$(COMMON_CONFIG_ENV) $< --defconfig $(CONFIG_CONFIG_IN)
+	@$(COMMON_CONFIG_ENV) $< --defconfig$(if $(BR2_DEFCONFIG),=$(BR2_DEFCONFIG)) $(CONFIG_CONFIG_IN)
 
 %_defconfig: $(BUILD_DIR)/buildroot-config/conf $(TOPDIR)/configs/%_defconfig outputmakefile
 	@mkdir -p $(BUILD_DIR)/buildroot-config

@@ -603,6 +603,7 @@ help:
 	@echo '  oldconfig              - resolve any unresolved symbols in .config'
 	@echo '  randconfig             - New config with random answer to all options'
 	@echo '  defconfig              - New config with default answer to all options'
+	@echo '                             BR2_DEFCONFIG, if set, is used as input'
 	@echo '  savedefconfig          - Save current config as ./defconfig (minimal config)'
 	@echo '  allyesconfig           - New config where all options are accepted with yes'
 	@echo '  allnoconfig            - New config where all options are answered with no'
Signature · 1 line
tg: (524a8ab..) t/defconfig (depends on: master)
#1 lore raw

PATCH RESEND v3 1/1 config: make it possible to specify which config file to use for 'make defconfig'

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:

Arnout> So that this works:
Arnout> % make defconfig BR2_DEFCONFIG=~/buildroot-defconfig

Arnout> Right now we have to do:

Arnout> % cp ~/buildroot-defconfig configs/buildroot_defconfig Arnout> % make buildroot_defconfig

Arnout> That would dirty the buildroot tree and requires it to be writable.

Arnout> Signed-off-by: Felipe Contreras <[email protected]> Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout> Acked-by: Luca Ceresoli <[email protected]>
Arnout> Acked-by: Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard