Skip to contentSkip to conversation

Make vgscan behaviour consistent with pvscan

PATCH New Petr Rockai 1 participant 1 message Mar 26, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 Make vgscan behaviour consistent with pvscan

Hi,

Quoted 4 lines · Peter Rajnoha

Just this minor thing... Are you OK with this?

If using "--cache" opt, we directly scan and update lvmetad if running. If not using "--cache" opt, we get the info from lvmetad if running.

yes, I think this is good for UI consistency. One thing to watch out for though is on-disk metadata inconsistencies. Before the patch, any "vgscan" would notice those, but afterwards, only "vgscan --cache" can be used to detect bad on-disk metadata.

We could also want to extend pvscan --cache to report (and maybe fix?) any metadata inconsistencies it may find.

[snip; patch looks OK]

Petr

Signature · 1 line
id' Ash = Ash; id' Dust = Dust; id' _ = undefined