OMAP2+: OPP: allow OPP enumeration to continue if device is not present
Subsystems (3)
PATCH 1/1 OMAP2+: OPP: allow OPP enumeration to continue if device is not present
On platforms such as OMAP3, certain variants may not have IVA, SGX or some specific component. We currently have a check to aid fixing wrong population of OPP entries for issues such as typos. This however causes a conflict with valid requirement where the SoC variant does not actually have the module present.
So, reduce the severity of the print to a debug statement and skip registering that specific OPP, but continue down the list.
---
Discussion: http://marc.info/?t=133174689300002&r=1&w=2
arch/arm/mach-omap2/opp.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/opp.c +2 -2
@@ -64,10 +64,10 @@ int __init omap_init_opp_table(struct omap_opp_def *opp_def, } oh =omap_hwmod_lookup (opp_def->hwmod_name);if (!oh || !oh->od) { -pr_warn ("%s: no hwmod or odev for %s, [%d] " +pr_debug ("%s: no hwmod or odev for %s, [%d] " "cannot add OPPs.\n" , __func__, opp_def->hwmod_name, i); -return -EINVAL ; +continue ; } dev = &oh->od->pdev->dev;
Signature · 1 line
1.7.0.4
PATCH 1/1 OMAP2+: OPP: allow OPP enumeration to continue if device is not present
Quoted 6 lines · Nishanth Menon
On platforms such as OMAP3, certain variants may not have IVA, SGX or some specific component. We currently have a check to aid fixing wrong population of OPP entries for issues such as typos. This however causes a conflict with valid requirement where the SoC variant does not actually have the module present.
Quoted 8 lines
So, reduce the severity of the print to a debug statement and skip registering that specific OPP, but continue down the list.
Reported-by Steve Sakoman <[email protected]>Reported-by Maximilian Schwerin <[email protected]>Acked-by Steve Sakoman <[email protected]>Tested-by Maximilian Schwerin <[email protected]>Signed-off-by Nishanth Menon <[email protected]>
Thanks, queuing as a fix for for v3.4-rc (branch: for_3.4/fixes/pm)
Kevin