Skip to contentSkip to conversation

OMAP: GPIO: Correct IP version message during boot

PATCH New Varadarajan, Charulatha 2 participants 4 messages Dec 16, 2010 – Dec 20, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP: GPIO: Correct IP version message during boot

With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]), the IP version information for all the banks are shown during bootup, but it does not show the bank number.

Use dev_info instead of printk in omap_gpio_show_rev() so that the bank id is displayed along with the IP version

[1] http://www.spinics.net/lists/arm-kernel/msg105872.html

---
 arch/arm/plat-omap/gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/gpio.c +1 -1
index 8d493b9..47aeaeb 100644
@@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
 	else
 		return;
 
-	printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
+	dev_info(bank->dev, "hardware version %d.%d\n",
 		(rev >> 4) & 0x0f, rev & 0x0f);
 }
 
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 OMAP: GPIO: Correct IP version message during boot

Quoted 9 lines · Charulatha

With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]), the IP version information for all the banks are shown during bootup, but it does not show the bank number.

Use dev_info instead of printk in omap_gpio_show_rev() so that the bank id is displayed along with the IP version

[1] http://www.spinics.net/lists/arm-kernel/msg105872.html

A related question, the commit above also changed the GPIO revision display from one-time to once per bank. Do we need to know the GPIO HW revision for each bank, or can we assume it's the same for all banks?

Kevin

Quoted 18 lines
---
 arch/arm/plat-omap/gpio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/gpio.c +1 -1
index 8d493b9..47aeaeb 100644
@@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)
 	else
 		return;
 
-	printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
+	dev_info(bank->dev, "hardware version %d.%d\n",
 		(rev >> 4) & 0x0f, rev & 0x0f);
 }
#2 lore raw

PATCH 1/1 OMAP: GPIO: Correct IP version message during boot

Kevin,

Quoted 7 lines · Kevin Hilman
Quoted 5 lines · Charulatha

With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]), the IP version information for all the banks are shown during bootup, but it does not show the bank number.

Quoted 8 lines
Quoted 4 lines

Use dev_info instead of printk in omap_gpio_show_rev() so that the bank id is displayed along with the IP version

[1] http://www.spinics.net/lists/arm-kernel/msg105872.html

A related question, the commit above also changed the GPIO revision display from one-time to once per bank. ?Do we need to know the GPIO HW revision for each bank, or can we assume it's the same for all banks?

The IP version is the same for all the gpio banks in all OMAP2+ CPUs. But I am not sure about OMAP16xx.

Quoted 22 lines

Kevin

Quoted 18 lines

---
?arch/arm/plat-omap/gpio.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/plat-omap/gpio.c +0 -0
index 8d493b9..47aeaeb 100644
@@ -1554,7 +1554,7 @@ static void __init omap_gpio_show_rev(struct gpio_bank *bank)

? ? ? else
? ? ? ? ? ? ? return;

- ? ? printk(KERN_INFO "OMAP GPIO hardware version %d.%d\n",
+ ? ? dev_info(bank->dev, "hardware version %d.%d\n", ? ? ? ? ? ? ? (rev >> 4) & 0x0f, rev & 0x0f);
?}

#3 lore raw

PATCH 1/1 OMAP: GPIO: Correct IP version message during boot

Quoted 13 lines · Charulatha

Kevin,

Quoted 10 lines · Kevin Hilman
Quoted 8 lines · Charulatha

With the commit 9a748053f5f58a77cd71864f1d7b804175b0e47d whose subject is "OMAP: GPIO: Make omap_gpio_show_rev bank specific" (see [1]), the IP version information for all the banks are shown during bootup, but it does not show the bank number.

Use dev_info instead of printk in omap_gpio_show_rev() so that the bank id is displayed along with the IP version

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

[1] http://www.spinics.net/lists/arm-kernel/msg105872.html

A related question, the commit above also changed the GPIO revision display from one-time to once per bank. ?Do we need to know the GPIO HW revision for each bank, or can we assume it's the same for all banks?

The IP version is the same for all the gpio banks in all OMAP2+ CPUs. But I am not sure about OMAP16xx.

OK, then I suggest we switch this back to just printing the GPIO
revision once. Maybe after all banks are found, just print the
revision for bank 1.

Kevin