ffmpeg: allow customization of codecs, (de)muxers and other components
PATCH 3/4 ffmpeg: allow customization of codecs, (de)muxers and other components
Quoted 9 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Luca" == Luca Ceresoli <[email protected]> writes:
Hi,
Luca> +ifneq ($(BR2_PACKAGE_FFMPEG_DECODERS),"all")
Quoted 3 lines
Quoted 3 lines
I would suggest you use qstrip + strip here as well, so it doesn't break if the user accidently added extra spaces or so.
Quoted 6 lines
Luca> How can foreach break with extra spaces? I've been trying things as:
Quoted 1 line
Quoted 1 line
BR2_PACKAGE_FFMPEG_ENCODERS=" vorbis flac "
Luca> and they work ok.
Not the foreach, but the ifneq (....,"all") would break if the user ended up setting it to "all " or " all" or similar.
Sorry, now I got what you mean.
Why do you say qstrip+strip anyway? qstrip does strip itself:
Quoted 3 lines
# Strip quotes and then whitespaces
qstrip=$(strip $(subst ",,$(1)))
#"))
So I would do:
-ifneq ($(BR2_PACKAGE_FFMPEG_ENCODERS),"all") +ifneq ($(call qstrip,$(BR2_PACKAGE_FFMPEG_ENCODERS)),all)
If that's ok, it will be in the re-submitted patches.
Quoted 4 lines
Signature · 2 lines
-- Bye, Peter Korsgaard
Luca
PATCH 3/4 ffmpeg: allow customization of codecs, (de)muxers and other components
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Luca" == Luca Ceresoli <[email protected]> writes:
Hi,
Quoted 2 lines
Quoted 2 lines
Not the foreach, but the ifneq (....,"all") would break if the user ended up setting it to "all " or " all" or similar.
Luca> Sorry, now I got what you mean.
Luca> Why do you say qstrip+strip anyway? qstrip does strip itself:
Ahh yes, then just qstrip.
Luca> So I would do:
Luca> -ifneq ($(BR2_PACKAGE_FFMPEG_ENCODERS),"all") Luca> +ifneq ($(call qstrip,$(BR2_PACKAGE_FFMPEG_ENCODERS)),all)
Luca> If that's ok, it will be in the re-submitted patches.
Yes please.
Signature · 1 line
Bye, Peter Korsgaard