Skip to contentSkip to conversation

Problem loopmounting CD on 2.6.0

DISCUSSION Niels Elgaard Larsen 3 participants 3 messages Dec 19, 2003 – Dec 22, 2003 Block layer

lore
Share & tools
lore
#0 lore raw

A similar (probably the same) problem have been reported for cryptoloop. With a ISO9660 CD (actually Knoppix) in drive /dev/hdc, no SCSI emulation:

amigos20:/mnt# losetup /dev/loop5 /dev/hdc
amigos20:/mnt# mount -r /dev/loop5 /mnt/foo

Gives kernel output:

===
hdc: cdrom_read_intr: data underrun (2 blocks)
end_request: I/O error, dev hdc, sector 64
isofs_fill_super: bread failed, dev=loop5, iso_blknum=16, block=32
===

It works in 2.4.20

Also

dd if=/dev/hdc of=/tmp/foo
losetup /dev/loop5 /tmp/foo
mount -r /dev/loop5 /mnt/foo

works

Signature · 3 lines
Niels Elgaard Larsen
[email protected]
http://www.agol.dk/elgaard
#1 lore raw

On Fri, 19 Dec 2003 14:10:44 +0100 Niels Elgaard Larsen <[email protected]> wrote:

| A similar (probably the same) problem have been reported for cryptoloop.
| With a ISO9660 CD (actually Knoppix) in drive /dev/hdc, no SCSI emulation:
| 
| amigos20:/mnt# losetup /dev/loop5 /dev/hdc
| amigos20:/mnt# mount -r /dev/loop5 /mnt/foo
| 
| Gives kernel output:
| 
| ===
| hdc: cdrom_read_intr: data underrun (2 blocks)
| end_request: I/O error, dev hdc, sector 64
| isofs_fill_super: bread failed, dev=loop5, iso_blknum=16, block=32
| ===
| 
| It works in 2.4.20
| 
| Also
| 
| dd if=/dev/hdc of=/tmp/foo
| losetup /dev/loop5 /tmp/foo
| mount -r /dev/loop5 /mnt/foo
| 
| works

I see differing sector size and block size reports by blockdev as follows. Is this OK/expected or does it hint at a problem?

(all without ide-scsi:)

2.6.0, non-loopback case:

# mount
/dev/hdd on /mnt/disk type iso9660 (ro)

[root@gargoyle rddunlap]# blockdev --getss /dev/hdd 2048
[root@gargoyle rddunlap]# blockdev --getbsz /dev/hdd 2048

2.6.0, loopback case:

I usually see the same error that you reported.
I did mount the cdrom successfully one time, with about 50 error messages like below[1], and saw this blocksize difference:
Is this OK or indicative of a (the) problem?

[root@gargoyle rddunlap]# blockdev --getss /dev/hdd 2048
[root@gargoyle rddunlap]# blockdev --getbsz /dev/hdd 4096

[1]
hdd: cdrom_read_intr: data underrun (2 blocks)
end_request: I/O error, dev hdd, sector 64
hdd: cdrom_read_intr: data underrun (2 blocks)
end_request: I/O error, dev hdd, sector 68
hdd: cdrom_read_intr: data underrun (2 blocks)
end_request: I/O error, dev hdd, sector 72
...
hdd: cdrom_read_intr: data underrun (2 blocks)
end_request: I/O error, dev hdd, sector 388
hdd: cdrom_read_intr: data underrun (2 blocks)
end_request: I/O error, dev hdd, sector 392
hdd: cdrom_read_intr: data underrun (2 blocks)
end_request: I/O error, dev hdd, sector 396

2.4.2x:

[root@gargoyle rddunlap]# blockdev --getss /dev/hdd 512
[root@gargoyle rddunlap]# blockdev --getbsz /dev/hdd 2048

--
~Randy
MOTD: Always include version info.

#2 lore raw
Quoted 26 lines · Randy.Dunlap

On Fri, 19 Dec 2003 14:10:44 +0100 Niels Elgaard Larsen <[email protected]> wrote:

| A similar (probably the same) problem have been reported for cryptoloop.
| With a ISO9660 CD (actually Knoppix) in drive /dev/hdc, no SCSI emulation:
| 
| amigos20:/mnt# losetup /dev/loop5 /dev/hdc
| amigos20:/mnt# mount -r /dev/loop5 /mnt/foo
| 
| Gives kernel output:
| 
| ===
| hdc: cdrom_read_intr: data underrun (2 blocks)
| end_request: I/O error, dev hdc, sector 64
| isofs_fill_super: bread failed, dev=loop5, iso_blknum=16, block=32
| ===
| 
| It works in 2.4.20
| 
| Also
| 
| dd if=/dev/hdc of=/tmp/foo
| losetup /dev/loop5 /tmp/foo
| mount -r /dev/loop5 /mnt/foo
| 
| works
Quoted 2 lines

I see differing sector size and block size reports by blockdev as follows. Is this OK/expected or does it hint at a problem?

Probably we need to set the hardsect_size of real device to loop. At least, it seems this problem was fixed.

What do you think of the following patch?

 drivers/block/loop.c |    1 +
 1 files changed, 1 insertion(+)
drivers/block/loop.c renamed from drivers/block/loop.c~loop-fix-hardsect_size +1 -0
diff -puN drivers/block/loop.c~loop-fix-hardsect_size drivers/block/loop.c
@@ -752,6 +752,7 @@ static int loop_set_fd(struct loop_devic
 		blk_queue_max_sectors(lo->lo_queue, q->max_sectors);
 		blk_queue_max_phys_segments(lo->lo_queue,q->max_phys_segments);
 		blk_queue_max_hw_segments(lo->lo_queue, q->max_hw_segments);
+		blk_queue_hardsect_size(lo->lo_queue, queue_hardsect_size(q));
 		blk_queue_max_segment_size(lo->lo_queue, q->max_segment_size);
 		blk_queue_segment_boundary(lo->lo_queue, q->seg_boundary_mask);
 		blk_queue_merge_bvec(lo->lo_queue, q->merge_bvec_fn);

_

Signature · 1 line
OGAWA Hirofumi <[email protected]>