Skip to contentSkip to conversation

x86/stacktrace: export save_stack_trace_tsk_reliable

PATCH In review Joe Lawrence 2 participants 4 messages Feb 27, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/stacktrace: export save_stack_trace_tsk_reliable

The ppc64le implementation of save_stack_trace_tsk_reliable() is exported, so do the same with x86.

---
 arch/x86/kernel/stacktrace.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/kernel/stacktrace.c +0 -0
index 5c2d71a1dc06..ad9b38dabf6a 100644

We could do the inverse and remove the symbol export from arch/powerpc/kernel/stacktrace.c, but I figured the other save_stack_trace_tsk variants are already exported for both arches, so add this one, too. -- JL

arch/x86/kernel/stacktrace.c +1 -0
@@ -163,6 +163,7 @@ int save_stack_trace_tsk_reliable(struct task_struct *tsk,
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(save_stack_trace_tsk_reliable);
 #endif /* CONFIG_HAVE_RELIABLE_STACKTRACE */
 
 /* Userspace stacktrace - based on kernel/trace/trace_sysprof.c */
Signature · 1 line
2.20.1
#1 lore raw
Quoted 2 lines · Joe Lawrence

The ppc64le implementation of save_stack_trace_tsk_reliable() is exported, so do the same with x86.

And what's the in tree module user of this? I can't find one and just because PPC has an export with no user is not a convincing argument to add another one. The proper solution is to remove the unused PPC export.

Thanks,

tglx

#2 lore raw
Quoted 9 lines · Thomas Gleixner
Quoted 2 lines · Joe Lawrence

The ppc64le implementation of save_stack_trace_tsk_reliable() is exported, so do the same with x86.

And what's the in tree module user of this? I can't find one and just because PPC has an export with no user is not a convincing argument to add another one. The proper solution is to remove the unused PPC export.

Good point.

For that matter, I do see in-tree modules making use of save_stack_trace, but who is calling save_stack_trace_tsk (exported by most arches) and save_stack_trace_regs (exported by openrisc, powerpc, s390)?

-- Joe

#3 lore raw
Quoted 11 lines · Joe Lawrence
Quoted 9 lines · Thomas Gleixner
Quoted 2 lines · Joe Lawrence

The ppc64le implementation of save_stack_trace_tsk_reliable() is exported, so do the same with x86.

And what's the in tree module user of this? I can't find one and just because PPC has an export with no user is not a convincing argument to add another one. The proper solution is to remove the unused PPC export.

Quoted 6 lines

Good point.

For that matter, I do see in-tree modules making use of save_stack_trace, but who is calling save_stack_trace_tsk (exported by most arches) and save_stack_trace_regs (exported by openrisc, powerpc, s390)?

Well, at least for save_stack_trace_tsk there is the out-of-tree kpatch core module[1]. (Kpatch drops that call if the kernel provides livepatch functionality.)

[1] https://github.com/dynup/kpatch/blob/master/kmod/core/core.c#L275

-- Joe