ALSA: hda/via: Apply runtime PM workaround for ASUS X55A
PATCH 1/1 ALSA: hda/via: Apply runtime PM workaround for ASUS X55A
ASUS X55A requires the same workaround like other machines with VT1802, otherwise it loses the codec power on a few nodes and the sound stays silent.
--- sound/hda/codecs/via.c | 1 + 1 file changed, 1 insertion(+)
sound/hda/codecs/via.c +1 -0
@@ -933,6 +933,7 @@ static const struct hda_fixup via_fixups[] = {static const struct hda_quirk vt2002p_fixups[] = {SND_PCI_QUIRK (0x1043 ,0x13f7 ,"Asus B23E" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x1487 ,"Asus G75" ,VIA_FIXUP_ASUS_G75 ), +SND_PCI_QUIRK (0x1043 ,0x1c33 ,"Asus X55A" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x8532 ,"Asus X202E" ,VIA_FIXUP_INTMIC_BOOST ),SND_PCI_QUIRK_VENDOR (0x1558 ,"Clevo" ,VIA_FIXUP_POWER_SAVE ), {}
Signature · 1 line
2.50.1
Quoted 10 lines · Vasiliy Kovalev
ASUS X55A requires the same workaround like other machines with VT1802, otherwise it loses the codec power on a few nodes and the sound stays silent.
Fixes a0645daf1610 ("ALSA: HDA: Early Forbid of runtime PM")Cc <[email protected]>Tested-by Nikita Maksimov <[email protected]>Signed-off-by Vasiliy Kovalev <[email protected]>
The addition of a quirk is OK, but is Fixes tag really pointing to the culprit? The commit is for forbidding the runtime PM, and I see no clear reason how this commit breaks.
thanks,
Takashi
Quoted 19 lines
--- sound/hda/codecs/via.c | 1 + 1 file changed, 1 insertion(+)sound/hda/codecs/via.c +1
-0@@ -933,6 +933,7 @@ static const struct hda_fixup via_fixups[] = {static const struct hda_quirk vt2002p_fixups[] = {SND_PCI_QUIRK (0x1043 ,0x13f7 ,"Asus B23E" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x1487 ,"Asus G75" ,VIA_FIXUP_ASUS_G75 ), +SND_PCI_QUIRK (0x1043 ,0x1c33 ,"Asus X55A" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x8532 ,"Asus X202E" ,VIA_FIXUP_INTMIC_BOOST ),SND_PCI_QUIRK_VENDOR (0x1558 ,"Clevo" ,VIA_FIXUP_POWER_SAVE ), {}Signature · 1 line
2.50.1
Hi,
Quoted 13 lines · Takashi Iwai
Quoted 10 lines · Vasiliy Kovalev
ASUS X55A requires the same workaround like other machines with VT1802, otherwise it loses the codec power on a few nodes and the sound stays silent.
Fixes a0645daf1610 ("ALSA: HDA: Early Forbid of runtime PM")Cc <[email protected]>Tested-by Nikita Maksimov <[email protected]>Signed-off-by Vasiliy Kovalev <[email protected]>
Quoted 3 lines
The addition of a quirk is OK, but is Fixes tag really pointing to the culprit? The commit is for forbidding the runtime PM, and I see no clear reason how this commit breaks.
I followed the precedent of your B23E patch[1], which carried the same Fixes tag. If you don't think it applies here, happy to drop it - let me know if you'd rather remove it yourself or have me send a v2 without it (keeping Cc: stable).
[1] https://lore.kernel.org/all/[email protected]/
Quoted 24 lines
thanks,
Takashi
Quoted 19 lines
--- sound/hda/codecs/via.c | 1 + 1 file changed, 1 insertion(+)sound/hda/codecs/via.c +1
-0@@ -933,6 +933,7 @@ static const struct hda_fixup via_fixups[] = {static const struct hda_quirk vt2002p_fixups[] = {SND_PCI_QUIRK (0x1043 ,0x13f7 ,"Asus B23E" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x1487 ,"Asus G75" ,VIA_FIXUP_ASUS_G75 ), +SND_PCI_QUIRK (0x1043 ,0x1c33 ,"Asus X55A" ,VIA_FIXUP_POWER_SAVE ),SND_PCI_QUIRK (0x1043 ,0x8532 ,"Asus X202E" ,VIA_FIXUP_INTMIC_BOOST ),SND_PCI_QUIRK_VENDOR (0x1558 ,"Clevo" ,VIA_FIXUP_POWER_SAVE ), {}Signature · 1 line
2.50.1
Signature · 2 lines
Thanks, Vasiliy
Quoted 21 lines · Vasiliy Kovalev
Hi,
Quoted 13 lines · Takashi Iwai
Quoted 10 lines · Vasiliy Kovalev
ASUS X55A requires the same workaround like other machines with VT1802, otherwise it loses the codec power on a few nodes and the sound stays silent.
Fixes a0645daf1610 ("ALSA: HDA: Early Forbid of runtime PM")Cc <[email protected]>Tested-by Nikita Maksimov <[email protected]>Signed-off-by Vasiliy Kovalev <[email protected]>Quoted 3 lines
The addition of a quirk is OK, but is Fixes tag really pointing to the culprit? The commit is for forbidding the runtime PM, and I see no clear reason how this commit breaks.
Quoted 6 lines
I followed the precedent of your B23E patch[1], which carried the same Fixes tag. If you don't think it applies here, happy to drop it - let me know if you'd rather remove it yourself or have me send a v2 without it (keeping Cc: stable).
OK, that looks like a failure in the previous commit, then. I applied to for-next branch now without Fixes tag.
thanks,
Takashi