Replace the macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
Subsystems (3)
cover Replace the macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
This patch replaces the macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig as discussed here
https://lore.kernel.org/lkml/CA+55aFxDk9_cmo4SPYMgG_WQ+_g5e_v6O-HEtQ_nTs-q1zjykg@mail.gmail.com/
It is a pre-requisite patch for the review
https://lore.kernel.org/lkml/[email protected]/
I have split this patch as suggested in the review comment
https://lore.kernel.org/lkml/[email protected]/
Vignesh Balasubramanian (1):
Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
arch/Kconfig | 9 +++++++++ arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/elf.h | 2 -- include/linux/elf.h | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/1 Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
"ARCH_HAVE_EXTRA_ELF_NOTES" enables an extra note section in the core dump. Kconfig variable is preferred over ARCH_HAVE_* macro.
--- arch/Kconfig | 9 +++++++++ arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/elf.h | 2 -- include/linux/elf.h | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-)
arch/Kconfig +9 -0
@@ -502,6 +502,15 @@ config MMU_LAZY_TLB_SHOOTDOWN config ARCH_HAVE_NMI_SAFE_CMPXCHG bool +config ARCH_HAVE_EXTRA_ELF_NOTES + bool + help + An architecture should select this in order to enable adding an + arch-specific ELF note section to core files. It must provide two + functions: elf_coredump_extra_notes_size() and + elf_coredump_extra_notes_write() which are invoked by the ELF core + dumper. + config ARCH_HAS_NMI_SAFE_THIS_CPU_OPS bool
arch/powerpc/Kconfig +1 -0
@@ -156,6 +156,7 @@ config PPC select ARCH_HAS_UACCESS_FLUSHCACHE select ARCH_HAS_UBSAN select ARCH_HAVE_NMI_SAFE_CMPXCHG + select ARCH_HAVE_EXTRA_ELF_NOTES if SPU_BASE select ARCH_KEEP_MEMBLOCK select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE if PPC_RADIX_MMU select ARCH_MIGHT_HAVE_PC_PARPORT
arch/powerpc/include/asm/elf.h +0 -2
@@ -127,8 +127,6 @@ extern int arch_setup_additional_pages(struct linux_binprm *bprm,/* Notes used in ET_CORE. Note name is "SPU/<fd>/<filename>". */ #define NT_SPU 1 -#define ARCH_HAVE_EXTRA_ELF_NOTES -#endif /* CONFIG_SPU_BASE */ #ifdef CONFIG_PPC64
include/linux/elf.h +1 -1
@@ -65,7 +65,7 @@ extern Elf64_Dyn _DYNAMIC [];struct file ;struct coredump_params ; -#ifndef ARCH_HAVE_EXTRA_ELF_NOTES +#ifndef CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES static inline int elf_coredump_extra_notes_size (void ) {return 0 ; }static inline int elf_coredump_extra_notes_write (struct coredump_params *cprm) {return 0 ; }#else
Signature · 1 line
2.34.1
Re: [PATCH 1/1] Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
Quoted 6 lines · Vignesh Balasubramanian
"
ARCH_HAVE_EXTRA_ELF_NOTES" enables an extra note section in the core dump.Kconfigvariable is preferred over ARCH_HAVE_* macro.Co-developed-by Jini Susan George <[email protected]>Signed-off-by Jini Susan George <[email protected]>Signed-off-by Vignesh Balasubramanian <[email protected]>
Quoted 6 lines
--- arch/Kconfig | 9 +++++++++ arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/elf.h | 2 -- include/linux/elf.h | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-)
cheers
Quoted 60 lines
arch/Kconfig +9
-0@@ -502,6 +502,15 @@ config MMU_LAZY_TLB_SHOOTDOWN config ARCH_HAVE_NMI_SAFE_CMPXCHG bool +config ARCH_HAVE_EXTRA_ELF_NOTES + bool + help + An architecture should select this in order to enable adding an + arch-specific ELF note section to core files. It must provide two + functions: elf_coredump_extra_notes_size() and + elf_coredump_extra_notes_write() which are invoked by the ELF core + dumper. + config ARCH_HAS_NMI_SAFE_THIS_CPU_OPS boolarch/powerpc/Kconfig +1
-0@@ -156,6 +156,7 @@ config PPC select ARCH_HAS_UACCESS_FLUSHCACHE select ARCH_HAS_UBSAN select ARCH_HAVE_NMI_SAFE_CMPXCHG + select ARCH_HAVE_EXTRA_ELF_NOTES if SPU_BASE select ARCH_KEEP_MEMBLOCK select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE if PPC_RADIX_MMU select ARCH_MIGHT_HAVE_PC_PARPORTarch/powerpc/include/asm/elf.h +0
-2@@ -127,8 +127,6 @@ extern int arch_setup_additional_pages(struct linux_binprm *bprm,/* Notes used in ET_CORE. Note name is "SPU/<fd>/<filename>". */ #define NT_SPU 1 -#define ARCH_HAVE_EXTRA_ELF_NOTES -#endif /* CONFIG_SPU_BASE */ #ifdef CONFIG_PPC64 include/linux/elf.h +1
-1@@ -65,7 +65,7 @@ extern Elf64_Dyn _DYNAMIC [];struct file ;struct coredump_params ; -#ifndef ARCH_HAVE_EXTRA_ELF_NOTES +#ifndef CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES static inline int elf_coredump_extra_notes_size (void ) {return 0 ; }static inline int elf_coredump_extra_notes_write (struct coredump_params *cprm) {return 0 ; }#else Signature · 1 line
2.34.1
Re: [PATCH 1/1] Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
In reply to Vignesh Balasubramanian* Vignesh Balasubramanian:
include/linux/elf.h extern Elf64_Dyn _DYNAMIC []; · line 68
Quoted 10 lines
include/linux/elf.h +1
-1@@ -65,7 +65,7 @@ extern Elf64_Dyn _DYNAMIC [];struct file ;struct coredump_params ; -#ifndef ARCH_HAVE_EXTRA_ELF_NOTES +#ifndef CONFIG_ARCH_HAVE_EXTRA_ELF_NOTES
You could add
#pragma GCC poison ARCH_HAVE_EXTRA_ELF_NOTES
to a central header, to let GCC and Clang flag uses that have not been converted.
Thanks,
Florian
Kees Cook
AppliedQuoted 9 lines · Vignesh Balasubramanian
This patch replaces the macro "
ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig as discussed here
https://lore.kernel.org/lkml/CA+55aFxDk9_cmo4SPYMgG_WQ+_g5e_v6O-HEtQ_nTs-q1zjykg@mail.gmail.com/
It is a pre-requisite patch for the review
https://lore.kernel.org/lkml/[email protected]/
I have split this patch as suggested in the review comment
https://lore.kernel.org/lkml/[email protected]/[...]
Applied to for-next/execve, thanks!
[1/1] Replace macro "ARCH_HAVE_EXTRA_ELF_NOTES" with kconfig
https://git.kernel.org/kees/c/a9c3475dd67b
Take care,
Signature · 1 line
Kees Cook