Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync"
Thomas Zimmermann
maintainerPATCH 1/1 Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync"
This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4.
Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit.
To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so.
--- drivers/firmware/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/firmware/sysfb.c +1 -1
@@ -128,4 +128,4 @@ static __init int sysfb_init(void) }/* must execute after PCI subsystem for EFI quirks */ -subsys_initcall_sync (sysfb_init); +device_initcall (sysfb_init);
Signature · 1 line
2.43.0
I'm very sorry to hear that, If Jaak can respond, I think I can find the root cause and fix that...
Huacai
Quoted 39 lines · Thomas Zimmermann
This reverts commit
60aebc9559492cea6a9625f514a8041717e3a2e4.Commit
60aebc9559492cea("drivers/firmware: Movesysfb_init()fromdevice_initcalltosubsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit.To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so.
Reported-by Jaak Ristioja <[email protected]>Reported-by Huacai Chen <[email protected]>Signed-off-by Thomas Zimmermann <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Thorsten Leemhuis <[email protected]>Cc Jani Nikula <[email protected]>--- drivers/firmware/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/sysfb.c +1
-2@@ -128,4 +128,4 @@ static __init int sysfb_init(void) }/* must execute after PCI subsystem for EFI quirks */ -subsys_initcall_sync (sysfb_init); +device_initcall (sysfb_init); --2.43.0
Thomas Zimmermann
maintainerHi
Am 23.01.24 um 14:12 schrieb Huacai Chen:
Quoted 2 lines
I'm very sorry to hear that, If Jaak can respond, I think I can find the root cause and fix that...
No problem, don't worry. We wanted to revert that patch anyway. And the *real* fix here is to track the framebuffer ownership more closely.
Best regards
Thomas
Quoted 43 lines
Huacai
Quoted 39 lines · Thomas Zimmermann
This reverts commit
60aebc9559492cea6a9625f514a8041717e3a2e4.Commit
60aebc9559492cea("drivers/firmware: Movesysfb_init()fromdevice_initcalltosubsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit.To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so.
Reported-by Jaak Ristioja <[email protected]>Reported-by Huacai Chen <[email protected]>Signed-off-by Thomas Zimmermann <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Thorsten Leemhuis <[email protected]>Cc Jani Nikula <[email protected]>--- drivers/firmware/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/sysfb.c +1
-2@@ -128,4 +128,4 @@ static __init int sysfb_init(void) }/* must execute after PCI subsystem for EFI quirks */ -subsys_initcall_sync (sysfb_init); +device_initcall (sysfb_init); --2.43.0
Signature · 6 lines
Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Quoted 21 lines · Thomas Zimmermann
This reverts commit
60aebc9559492cea6a9625f514a8041717e3a2e4.Commit
60aebc9559492cea("drivers/firmware: Movesysfb_init()fromdevice_initcalltosubsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit.To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so.
Reported-by Jaak Ristioja <[email protected]>Reported-by Huacai Chen <[email protected]>Signed-off-by Thomas Zimmermann <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Thorsten Leemhuis <[email protected]>Cc Jani Nikula <[email protected]>
Quoted 1 line
---
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 12 lines · Thomas Zimmermann
This reverts commit
60aebc9559492cea6a9625f514a8041717e3a2e4.Commit
60aebc9559492cea("drivers/firmware: Movesysfb_init()fromdevice_initcalltosubsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit.To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so.
Quoted 5 lines
FWIW,
but would be great to get a Tested-by from Jaak or from the gitlab issue reporter.
Thanks.
Quoted 18 lines
Signed-off-by Thomas Zimmermann <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Thorsten Leemhuis <[email protected]>Cc Jani Nikula <[email protected]>--- drivers/firmware/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/firmware/sysfb.c +1
-1@@ -128,4 +128,4 @@ static __init int sysfb_init(void) }/* must execute after PCI subsystem for EFI quirks */ -subsys_initcall_sync (sysfb_init); +device_initcall (sysfb_init);
Signature · 1 line
Jani Nikula, Intel
Quoted 19 lines · Jani Nikula
Quoted 12 lines · Thomas Zimmermann
This reverts commit
60aebc9559492cea6a9625f514a8041717e3a2e4.Commit
60aebc9559492cea("drivers/firmware: Movesysfb_init()fromdevice_initcalltosubsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit.To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so.
Quoted 5 lines
Quoted 6 lines
FWIW,
Acked-by Jani Nikula <[email protected]>but would be great to get a Tested-by from Jaak or from the gitlab issue reporter.
The revert works for the gitlab issue reporter.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel