Skip to contentSkip to conversation

package/quickjs: disable on microblaze

PATCH Applied Bernd Kuhls 3 participants 5 messages Jun 25, 2023 – Jul 16, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/quickjs: disable on microblaze

quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on microblaze since its addition in commit 5d50793659acb95050c110d5fc05399df20ce30b

Fixes:
http://autobuild.buildroot.net/results/3b1/3b1b1f91998bfdec65f3e6fb8931df9c8871b953/

---
 package/quickjs/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/quickjs/Config.in +2 -0
index dc466241ba..292dba86d0 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QUICKJS
 	bool "quickjs"
+	depends on !BR2_microblaze # fenv.h lacks FE_{DOWN,UP}WARD
 	depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
 	depends on !BR2_STATIC_LIBS
 	# No way to check for fenv support.
@@ -15,6 +16,7 @@ config BR2_PACKAGE_QUICKJS
 	  https://bellard.org/quickjs/
 
 comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
+	depends on !BR2_microblaze
 	depends on !BR2_nios2
 	depends on BR2_USE_MMU
 	depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/quickjs: disable on sh*

quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on sh* since its addition in commit 5d50793659acb95050c110d5fc05399df20ce30b

Fixes:

sh4:    http://autobuild.buildroot.net/results/46d/46d7da58a857939ee3a33f60ab64ad278157c3bd/
sh4a:   http://autobuild.buildroot.net/results/b1d/b1db05e79e5505c6606524e54e159224b633eac2/
sh4aeb: http://autobuild.buildroot.net/results/c30/c307a1b67142405f81c9276056b28bea366f2ccf/
sh4eb:  http://autobuild.buildroot.net/results/945/945b508385ba5aa25f982f8a8493628fa828e472/
---
 package/quickjs/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/quickjs/Config.in +2 -0
index 292dba86d0..fd174bc657 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_QUICKJS
 	bool "quickjs"
 	depends on !BR2_microblaze # fenv.h lacks FE_{DOWN,UP}WARD
 	depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
+	depends on !BR2_sh # fenv.h lacks FE_{DOWN,UP}WARD
 	depends on !BR2_STATIC_LIBS
 	# No way to check for fenv support.
 	depends on !BR2_TOOLCHAIN_USES_UCLIBC
@@ -18,6 +19,7 @@ config BR2_PACKAGE_QUICKJS
 comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
 	depends on !BR2_microblaze
 	depends on !BR2_nios2
+	depends on !BR2_sh
 	depends on BR2_USE_MMU
 	depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_HOST_GCC_AT_LEAST_4_9
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 2/2] package/quickjs: disable on sh*

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on sh* since its addition in commit 5d50793659acb95050c110d5fc05399df20ce30b

Quoted 7 lines

Fixes:

sh4:    http://autobuild.buildroot.net/results/46d/46d7da58a857939ee3a33f60ab64ad278157c3bd/
sh4a:   http://autobuild.buildroot.net/results/b1d/b1db05e79e5505c6606524e54e159224b633eac2/
sh4aeb: http://autobuild.buildroot.net/results/c30/c307a1b67142405f81c9276056b28bea366f2ccf/
sh4eb:  http://autobuild.buildroot.net/results/945/945b508385ba5aa25f982f8a8493628fa828e472/

Committed to 2023.02.x and 2023.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
In reply to Bernd Kuhls
Quoted 8 lines · Bernd Kuhls

quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on microblaze since its addition in commit 5d50793659acb95050c110d5fc05399df20ce30b

Fixes:
http://autobuild.buildroot.net/results/3b1/3b1b1f91998bfdec65f3e6fb8931df9c8871b953/

Applied both to master, thanks.

Regards,
Arnout

Quoted 16 lines
---
  package/quickjs/Config.in | 2 ++
  1 file changed, 2 insertions(+)
package/quickjs/Config.in +1 -0
index dc466241ba..292dba86d0 100644
@@ -1,5 +1,6 @@
  config BR2_PACKAGE_QUICKJS
  	bool "quickjs"
+	depends on !BR2_microblaze # fenv.h lacks FE_{DOWN,UP}WARD
  	depends on !BR2_nios2 # fenv.h lacks FE_{DOWN,UP}WARD on nios2
  	depends on !BR2_STATIC_LIBS
  	# No way to check for fenv support.

package/quickjs/Config.in config BR2_PACKAGE_QUICKJS · line 22

Quoted 7 lines
package/quickjs/Config.in +1 -0
@@ -15,6 +16,7 @@ config BR2_PACKAGE_QUICKJS
  	  https://bellard.org/quickjs/
 
  comment "quickjs needs a glibc or musl toolchain w/ gcc >= 4.9, host gcc >= 4.9, dynamic library"
+	depends on !BR2_microblaze
  	depends on !BR2_nios2
  	depends on BR2_USE_MMU
  	depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC || \

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw
In reply to Bernd Kuhls
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

quickjs unconditionally uses FE_{DOWN,UP}WARD and so fails to build on microblaze since its addition in commit 5d50793659acb95050c110d5fc05399df20ce30b

Fixes:
http://autobuild.buildroot.net/results/3b1/3b1b1f91998bfdec65f3e6fb8931df9c8871b953/

Committed to 2023.02.x and 2023.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot