mt76: mt7915: fix info leak in mt7915_mcu_set_pre_cal()
Subsystems (3)
PATCH 1/1 mt76: mt7915: fix info leak in mt7915_mcu_set_pre_cal()
Zero out all the unused members of "req" so that we don't disclose stack information.
Fixes 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c +1 -1
@@ -3481,7 +3481,7 @@ static int mt7915_mcu_set_pre_cal(struct mt7915_dev *dev, u8 idx,u8 idx;u8 rsv[4 ];__le32 len; - } req; + } req = {};struct sk_buff *skb; skb =mt76_mcu_msg_alloc (&dev->mt76,NULL ,sizeof (req) + len);
Signature · 7 lines
2.30.2 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 5 lines · Dan Carpenter
Zero out all the unused members of "req" so that we don't disclose stack information.
Fixes 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")Signed-off-by Dan Carpenter <[email protected]>
Felix, should I take this directly to wireless-drivers? If yes, please ack.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 5 lines · Dan Carpenter
Zero out all the unused members of "req" so that we don't disclose stack information.
Fixes 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")Signed-off-by Dan Carpenter <[email protected]>
Acked-by Felix Fietkau <[email protected]>
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek