package/openvpn: set OPENVPN_CPE_ID_VENDOR
PATCH 1/1 package/openvpn: set OPENVPN_CPE_ID_VENDOR
--- package/openvpn/openvpn.mk | 1 + 1 file changed, 1 insertion(+)
package/openvpn/openvpn.mk +1 -0
@@ -10,6 +10,7 @@ OPENVPN_SITE = http://swupdate.openvpn.net/community/releases OPENVPN_DEPENDENCIES = host-pkgconf OPENVPN_LICENSE = GPL-2.0 OPENVPN_LICENSE_FILES = COPYRIGHT.GPL +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME) OPENVPN_CONF_OPTS = \ --disable-unit-tests \ $(if $(BR2_STATIC_LIBS),--disable-plugins)
Signature · 1 line
2.29.2
PATCH 1/1 package/openvpn: set OPENVPN_CPE_ID_VENDOR
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
Signed-off-by Fabrice Fontaine <[email protected]>--- package/openvpn/openvpn.mk | 1 + 1 file changed, 1 insertion(+)package/openvpn/openvpn.mk +0
-0
package/openvpn/openvpn.mk OPENVPN_SITE = http://swupdate.openvpn.net/community/releases · line 13
Quoted 4 lines
package/openvpn/openvpn.mk +1
-0@@ -10,6 +10,7 @@ OPENVPN_SITE = http://swupdate.openvpn.net/community/releases OPENVPN_DEPENDENCIES = host-pkgconf OPENVPN_LICENSE = GPL-2.0 OPENVPN_LICENSE_FILES = COPYRIGHT.GPL +OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
I am not sure why we do this obfuscation with the _NAME variable instead of just "openvpn" - But ok, a bunch of other packages do so as well.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/openvpn: set OPENVPN_CPE_ID_VENDOR
Quoted 4 lines · On Sat, 09 Jan 2021 16:08:24 +0100 Peter Korsgaard <[email protected]> wrote:
Quoted 1 line
+OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
I am not sure why we do this obfuscation with the
_NAMEvariable instead of just "openvpn" - But ok, a bunch of other packages do so as well.
Yes, it was done like this in the original patch from Matt, and I kept it as-is, but I also wasn't too sure about it. But since nobody complained when I posted the patch, I applied it as-is.
I definitely wouldn't oppose to changing this to not use the <pkg>_NAME variable, as it find this indirection to not be very useful.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/openvpn: set OPENVPN_CPE_ID_VENDOR
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Quoted 4 lines · On Sat, 09 Jan 2021 16:08:24 +0100 Peter Korsgaard <[email protected]> wrote:
Quoted 1 line
+OPENVPN_CPE_ID_VENDOR = $(OPENVPN_NAME)
I am not sure why we do this obfuscation with the
_NAMEvariable instead of just "openvpn" - But ok, a bunch of other packages do so as well.
Quoted 6 lines
Yes, it was done like this in the original patch from Matt, and I kept it as-is, but I also wasn't too sure about it. But since nobody complained when I posted the patch, I applied it as-is.
I definitely wouldn't oppose to changing this to not use the <pkg>_NAME variable, as it find this indirection to not be very useful.
Ok, good. It may make sense to default _CPE_ID_VENDOR to $($(PKG)_NAME), which is perhaps where this comes from?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 package/openvpn: set OPENVPN_CPE_ID_VENDOR
Quoted 2 lines · On Sat, 09 Jan 2021 22:18:04 +0100 Peter Korsgaard <[email protected]> wrote:
Ok, good. It may make sense to default
_CPE_ID_VENDORto $($(PKG)_NAME), which is perhaps where this comes from?
CPE_ID_VENDOR already has a default, which is:
$(2)_CPE_ID_VENDOR = $$($(2)_RAWNAME)_project
Indeed, for a large number of packages, the CPE vendor ID follows that <foo>_project scheme.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com