Skip to contentSkip to conversation

drm/i915: fix build error without ACPI

PATCH In review Chen Zhou 2 participants 2 messages Jan 13, 2020

Subsystems (2)
lore
Share & tools
lore

Chen Zhou

author
#0 lore raw

PATCH 1/1 drm/i915: fix build error without ACPI

If CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=m, compilation complains with undefined references:

drivers/gpu/drm/i915/display/intel_panel.o: In function `intel_backlight_device_register':
intel_panel.c:(.text+0x4dd9): undefined reference to backlight_device_register' drivers/gpu/drm/i915/display/intel_panel.o: In function intel_backlight_device_unregister':
intel_panel.c:(.text+0x4e96): undefined reference to `backlight_device_unregister'

This patch select BACKLIGHT_CLASS_DEVICE directly.

---
 drivers/gpu/drm/i915/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/Kconfig +1 -1
index ba95959..6b69dab 100644
@@ -16,7 +16,7 @@ config DRM_I915
 	select IRQ_WORK
 	# i915 depends on ACPI_VIDEO when ACPI is enabled
 	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
-	select BACKLIGHT_CLASS_DEVICE if ACPI
+	select BACKLIGHT_CLASS_DEVICE
 	select INPUT if ACPI
 	select ACPI_VIDEO if ACPI
 	select ACPI_BUTTON if ACPI
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 9 lines · Chen Zhou

If CONFIG_ACPI=n and CONFIG_BACKLIGHT_CLASS_DEVICE=m, compilation complains with undefined references:

drivers/gpu/drm/i915/display/intel_panel.o: In function `intel_backlight_device_register':
intel_panel.c:(.text+0x4dd9): undefined reference to backlight_device_register' drivers/gpu/drm/i915/display/intel_panel.o: In function intel_backlight_device_unregister':
intel_panel.c:(.text+0x4e96): undefined reference to `backlight_device_unregister'

This patch select BACKLIGHT_CLASS_DEVICE directly.

i915 does not unconditionally require backlight.

See e.g. [1] for the details.

BR,
Jani.

[1] http://lore.kernel.org/r/[email protected]

Quoted 20 lines
---
 drivers/gpu/drm/i915/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/Kconfig +1 -1
index ba95959..6b69dab 100644
@@ -16,7 +16,7 @@ config DRM_I915
 	select IRQ_WORK
 	# i915 depends on ACPI_VIDEO when ACPI is enabled
 	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
-	select BACKLIGHT_CLASS_DEVICE if ACPI
+	select BACKLIGHT_CLASS_DEVICE
 	select INPUT if ACPI
 	select ACPI_VIDEO if ACPI
 	select ACPI_BUTTON if ACPI
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx