Skip to contentSkip to conversation

host-genimage: add host-mtools to dependency list

PATCH New Alexandru Ardelean 3 participants 4 messages Feb 1, 2019 – Feb 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 host-genimage: add host-mtools to dependency list

From: Alexandru Ardelean <[email protected]>

The mcopy command is needed to generate vfat images.
If the host system has mtools installed, all is fine, since genimage would use it.

But since there is already a host-mtools build in the buildroot packages, then this can be used instead.

---
 package/genimage/genimage.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/genimage/genimage.mk +1 -1
index 393c3e9b94..18eea58af2 100644
@@ -7,7 +7,7 @@
 GENIMAGE_VERSION = 10
 GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
 GENIMAGE_SITE = https://github.com/pengutronix/genimage/releases/download/v$(GENIMAGE_VERSION)
-HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
+HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse host-mtools
 GENIMAGE_LICENSE = GPL-2.0
 GENIMAGE_LICENSE_FILES = COPYING
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 host-genimage: add host-mtools to dependency list

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexandru" == Alexandru Ardelean <[email protected]> writes:

From: Alexandru Ardelean <[email protected]>
The mcopy command is needed to generate vfat images.
If the host system has mtools installed, all is fine, since genimage would use it.

But since there is already a host-mtools build in the buildroot packages, then this can be used instead.

There are use cases for genimage that does not require mcopy, so this isn't really nice.

But it is indeed true that a lot of genimage use cases require host-dosfstools and host-mtools:

E.G. from raspberrypi_defconfig:

# Required tools to create the SD image
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y

Quoted 24 lines
---
 package/genimage/genimage.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/genimage/genimage.mk +1 -1
index 393c3e9b94..18eea58af2 100644
@@ -7,7 +7,7 @@
 GENIMAGE_VERSION = 10
 GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
 GENIMAGE_SITE = https://github.com/pengutronix/genimage/releases/download/v$(GENIMAGE_VERSION)
-HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
+HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse host-mtools
 GENIMAGE_LICENSE = GPL-2.0
 GENIMAGE_LICENSE_FILES = COPYING
 
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 host-genimage: add host-mtools to dependency list

Quoted 11 lines · Peter Korsgaard
Quoted 10 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Alexandru" == Alexandru Ardelean <[email protected]> writes:

From: Alexandru Ardelean <[email protected]>
The mcopy command is needed to generate vfat images.
If the host system has mtools installed, all is fine, since genimage would use it.

But since there is already a host-mtools build in the buildroot packages, then this can be used instead.

Quoted 8 lines
Quoted 1 line

There are use cases for genimage that does not require mcopy, so this isn't really nice.

But it is indeed true that a lot of genimage use cases require host-dosfstools and host-mtools:

Another idea I was thinking of [in case this one wasn't very popular], is to add in Config.in.host a symbol that adds/selects host-mtools if enabled.

Personally, I don't mind if we leave this as-is and manually select host-mtools for genimage.

For a use-case I encountered, adding host-mtools like this change seemed useful.

Thanks
Alex

Quoted 35 lines

E.G. from raspberrypi_defconfig:

# Required tools to create the SD image
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y

Quoted 20 lines
---
 package/genimage/genimage.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/genimage/genimage.mk +1 -2
index 393c3e9b94..18eea58af2 100644
@@ -7,7 +7,7 @@
 GENIMAGE_VERSION = 10
 GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
 GENIMAGE_SITE = https://github.com/pengutronix/genimage/releases/download/v$(GENIMAGE_VERSION)
-HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
+HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse host-mtools
 GENIMAGE_LICENSE = GPL-2.0
 GENIMAGE_LICENSE_FILES = COPYING
 
--

2.17.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
Bye, Peter Korsgaard

#3 lore raw

PATCH 1/1 host-genimage: add host-mtools to dependency list

Alexandru, All,

On 2019-02-01 15:07 +0200, Alexandru Ardelean spake thusly:

Quoted 17 lines · Peter Korsgaard
Quoted 16 lines
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Alexandru" == Alexandru Ardelean <[email protected]> writes:

From: Alexandru Ardelean <[email protected]>
The mcopy command is needed to generate vfat images.
If the host system has mtools installed, all is fine, since genimage would use it.

Quoted 4 lines

But since there is already a host-mtools build in the buildroot packages, then this can be used instead.

There are use cases for genimage that does not require mcopy, so this isn't really nice.

Quoted 7 lines
Quoted 3 lines

But it is indeed true that a lot of genimage use cases require host-dosfstools and host-mtools:

Another idea I was thinking of [in case this one wasn't very popular], is to add in Config.in.host a symbol that adds/selects host-mtools if enabled.

That would give the same outcome: host-mtools would be buiklt, even in situations they are nto needed.

Quoted 4 lines

Personally, I don't mind if we leave this as-is and manually select host-mtools for genimage.

For a use-case I encountered, adding host-mtools like this change seemed useful.

A few other tools could be usefull as wel, like host-e2fsprogs or such.

But we do not want to build all of them in all cases, so I side with Peter here: we have to rely on the user selecting what they need.

So, I've marked this as rejected in patchwork.

Thanks!

Regards,
Yann E. MORIN.

Quoted 42 lines

Thanks
Alex

Quoted 28 lines

E.G. from raspberrypi_defconfig:

# Required tools to create the SD image
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y

Quoted 19 lines
---
 package/genimage/genimage.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/genimage/genimage.mk +1 -2
index 393c3e9b94..18eea58af2 100644
@@ -7,7 +7,7 @@
 GENIMAGE_VERSION = 10
 GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
 GENIMAGE_SITE = https://github.com/pengutronix/genimage/releases/download/v$(GENIMAGE_VERSION)
-HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
+HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse host-mtools
 GENIMAGE_LICENSE = GPL-2.0
 GENIMAGE_LICENSE_FILES = COPYING
 
--

2.17.1

Quoted 7 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

--
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'