Skip to contentSkip to conversation

utils/genrandconfig: add missing new line when creating the configuration

PATCH New Thomas Petazzoni 2 participants 3 messages Nov 15, 2018 – Nov 26, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 utils/genrandconfig: add missing new line when creating the configuration

When adding the custom BR2_WGET value in the configuration, genrandconfig forgets to add a newline. Due to this, the next option that is added is printed on the same line as BR2_WGET="", which causes it to be ignored.

Due to this, in all builds, the line right after BR2_WGET was ignored. It could have been BR2_ENABLE_DEBUG, BR2_INIT_BUSYBOX, BR2_INIT_SYSTEMD, BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV, BR2_STATIC_LIBS or BR2_PACKAGE_PYTHON_PY_ONLY depending on the randomization.

Fix that by adding a proper newline at the end of the BR2_WGET option.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 utils/genrandconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/genrandconfig +1 -1
index 27f84ea555..1d6ff990f5 100755
@@ -351,7 +351,7 @@ def gen_config(args):
         configlines += minimalf.readlines()
 
     # Allow hosts with old certificates to download over https
-    configlines.append("BR2_WGET=\"wget --passive-ftp -nd -t 3 --no-check-certificate\"")
+    configlines.append("BR2_WGET=\"wget --passive-ftp -nd -t 3 --no-check-certificate\"\n")
 
     # Amend the configuration with a few things.
     if randint(0, 20) == 0:
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 utils/genrandconfig: add missing new line when creating the configuration

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

When adding the custom BR2_WGET value in the configuration, genrandconfig forgets to add a newline. Due to this, the next option that is added is printed on the same line as BR2_WGET="", which causes it to be ignored.

Due to this, in all builds, the line right after BR2_WGET was ignored. It could have been BR2_ENABLE_DEBUG, BR2_INIT_BUSYBOX, BR2_INIT_SYSTEMD, BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV, BR2_STATIC_LIBS or BR2_PACKAGE_PYTHON_PY_ONLY depending on the randomization.

Quoted 3 lines

Fix that by adding a proper newline at the end of the BR2_WGET option.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 utils/genrandconfig: add missing new line when creating the configuration

In reply to Thomas Petazzoni
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

When adding the custom BR2_WGET value in the configuration, genrandconfig forgets to add a newline. Due to this, the next option that is added is printed on the same line as BR2_WGET="", which causes it to be ignored.

Due to this, in all builds, the line right after BR2_WGET was ignored. It could have been BR2_ENABLE_DEBUG, BR2_INIT_BUSYBOX, BR2_INIT_SYSTEMD, BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV, BR2_STATIC_LIBS or BR2_PACKAGE_PYTHON_PY_ONLY depending on the randomization.

Quoted 3 lines

Fix that by adding a proper newline at the end of the BR2_WGET option.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard