Skip to contentSkip to conversation

bird: new package

PATCH Superseded Adrien Gallouët 3 participants 5 messages Sep 27, 2018 – Oct 9, 2018

lore
Share & tools
lore

Adrien Gallouët

author
#0 lore raw

PATCH 1/1 bird: new package

The BIRD project aims to develop a dynamic IP routing daemon with full support of all modern routing protocols, easy to use configuration interface and powerful route filtering language

Signed-off-by Adrien Gallou?t <[email protected]>
---
 DEVELOPERS             |  1 +
 package/Config.in      |  1 +
 package/bird/Config.in | 12 ++++++++++++
 package/bird/bird.hash |  2 ++
 package/bird/bird.mk   | 14 ++++++++++++++
 5 files changed, 30 insertions(+)
 create mode 100644 package/bird/Config.in
 create mode 100644 package/bird/bird.hash
 create mode 100644 package/bird/bird.mk
DEVELOPERS +1 -0
index 0335aef3b1..a256067004 100644
@@ -72,6 +72,7 @@ F:	package/woff2/
 
 N:	Adrien Gallou?t <[email protected]>
 F:	package/glorytun/
+F:	package/bird/
 
 N:	Aleksander Morgado <[email protected]>
 F:	package/libmbim/
package/Config.in +1 -0
index 52f11c407a..73bb209c66 100644
@@ -1743,6 +1743,7 @@ menu "Networking applications"
 	source "package/batctl/Config.in"
 	source "package/bcusdk/Config.in"
 	source "package/bind/Config.in"
+	source "package/bird/Config.in"
 	source "package/bluez-tools/Config.in"
 	source "package/bluez_utils/Config.in"
 	source "package/bluez5_utils/Config.in"
package/bird/Config.in new file +12 -0
new file mode 100644
index 0000000000..6e4e43505a
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_BIRD
+	bool "bird"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_READLINE
+	help
+	  BIRD Internet Routing Daemon
+
+	  The BIRD project aims to develop a dynamic IP routing daemon with full support
+	  of all modern routing protocols, easy to use configuration interface and
+	  powerful route filtering language
+
+	  http://bird.network.cz/
package/bird/bird.hash new file +2 -0
new file mode 100644
index 0000000000..88dea503c9
@@ -0,0 +1,2 @@
+sha256 bd42d48fbcc2c0046d544f1183cd98193ff15b792d332ff45f386b0180b09335  v2.0.2.tar.gz
+sha256 f018596a97af0108efc446320631e2fddc0c1d1f3ffab3129327ccdb4f0c29ed  README
package/bird/bird.mk new file +14 -0
new file mode 100644
index 0000000000..959021f94f
@@ -0,0 +1,14 @@
+################################################################################
+#
+# bird
+#
+################################################################################
+
+BIRD_VERSION = 2.0.2
+BIRD_SOURCE = v$(BIRD_VERSION).tar.gz
+BIRD_SITE = https://github.com/BIRD/bird/archive
+BIRD_LICENSE = GPL-2.0+
+BIRD_LICENSE_FILES = README
+BIRD_AUTORECONF = YES
+
+$(eval $(autotools-package))
Signature · 1 line
2.19.0
#1 lore raw

PATCH 1/1 bird: new package

Hi Adrien,

Quoted 6 lines · Adrien Gallou?t
package/bird/bird.mk new file +0 -0
new file mode 100644
index 0000000000..959021f94f

package/bird/bird.mk line 9

Quoted 9 lines
package/bird/bird.mk new file +9 -0
@@ -0,0 +1,14 @@
+################################################################################
+#
+# bird
+#
+################################################################################
+
+BIRD_VERSION = 2.0.2
+BIRD_SOURCE = v$(BIRD_VERSION).tar.gz
+BIRD_SITE = https://github.com/BIRD/bird/archive

Please use the github helper:

  BIRD_SITE = $(call github,BIRD,bird,$(BIRD_VERSION))

BIRD_SOURCE should not be needed.

package/bird/bird.mk line 12

Quoted 3 lines
package/bird/bird.mk new file +3 -0
+BIRD_LICENSE = GPL-2.0+
+BIRD_LICENSE_FILES = README
+BIRD_AUTORECONF = YES

Please mention in a comment that autoreconf is needed since the package is fetched from github so there is no configure script.

package/bird/bird.mk line 14

Quoted 2 lines
package/bird/bird.mk new file +2 -0
+
+$(eval $(autotools-package))

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

author
#2 lore raw

PATCH v2 1/1 bird: new package

In reply to Adrien Gallouët

The BIRD project aims to develop a dynamic IP routing daemon with full support of all modern routing protocols, easy to use configuration interface and powerful route filtering language

Signed-off-by Adrien Gallou?t <[email protected]>

---
Changes v1 -> v2 (after Baruch Siach review)
- Add a comment for the use of autoreconf
- Use github helper

DEVELOPERS +1 -0
index 0335aef3b1..a256067004 100644
@@ -72,6 +72,7 @@ F:	package/woff2/
 
 N:	Adrien Gallou?t <[email protected]>
 F:	package/glorytun/
+F:	package/bird/
 
 N:	Aleksander Morgado <[email protected]>
 F:	package/libmbim/
package/Config.in +1 -0
index 52f11c407a..73bb209c66 100644
@@ -1743,6 +1743,7 @@ menu "Networking applications"
 	source "package/batctl/Config.in"
 	source "package/bcusdk/Config.in"
 	source "package/bind/Config.in"
+	source "package/bird/Config.in"
 	source "package/bluez-tools/Config.in"
 	source "package/bluez_utils/Config.in"
 	source "package/bluez5_utils/Config.in"
package/bird/Config.in new file +12 -0
new file mode 100644
index 0000000000..6e4e43505a
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_BIRD
+	bool "bird"
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_READLINE
+	help
+	  BIRD Internet Routing Daemon
+
+	  The BIRD project aims to develop a dynamic IP routing daemon with full support
+	  of all modern routing protocols, easy to use configuration interface and
+	  powerful route filtering language
+
+	  http://bird.network.cz/
package/bird/bird.hash new file +2 -0
new file mode 100644
index 0000000000..449e8afd8d
@@ -0,0 +1,2 @@
+sha256 bd42d48fbcc2c0046d544f1183cd98193ff15b792d332ff45f386b0180b09335  bird-v2.0.2.tar.gz
+sha256 f018596a97af0108efc446320631e2fddc0c1d1f3ffab3129327ccdb4f0c29ed  README
package/bird/bird.mk new file +15 -0
new file mode 100644
index 0000000000..f45baadab2
@@ -0,0 +1,15 @@
+################################################################################
+#
+# bird
+#
+################################################################################
+
+BIRD_VERSION = v2.0.2
+BIRD_SITE = $(call github,BIRD,bird,$(BIRD_VERSION))
+BIRD_LICENSE = GPL-2.0+
+BIRD_LICENSE_FILES = README
+
+# autoreconf is needed since the package is fetched from github
+BIRD_AUTORECONF = YES
+
+$(eval $(autotools-package))
Signature · 1 line
2.19.0
#3 lore raw

PATCH v2 1/1 bird: new package

Hello Adrien,

Quoted 9 lines · Adrien Gallou?t

The BIRD project aims to develop a dynamic IP routing daemon with full support of all modern routing protocols, easy to use configuration interface and powerful route filtering language

Signed-off-by Adrien Gallou?t <[email protected]>

---
Changes v1 -> v2 (after Baruch Siach review)
- Add a comment for the use of autoreconf
- Use github helper

I've applied your patch, after doing a number of changes:

[Thomas:
- Do not make ncurses/readline mandatory dependencies, since they are not. They are only needed when building the BIRD client. Added a Config.in sub-option to enable/disable the client. As part of this, added ncurses/readline to <pkg>_DEPENDENCIES.
- Add a patch to fix the installation when the BIRD client is disabled, the patch has been submitted upstream.
- Added host-flex and host-bison to <pkg>_DEPENDENCIES since flex/bison are used during the build process.
- Add BR2_USE_MMU dependency, the code uses fork()
- Fix alphabetic ordering in DEVELOPERS file.]

Thanks for this contribution!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#4 lore raw

PATCH v2 1/1 bird: new package

Hi Thomas,

Thanks a lot :)

Quoted 35 lines · Thomas Petazzoni

Hello Adrien,

Quoted 9 lines · Adrien Gallou?t

The BIRD project aims to develop a dynamic IP routing daemon with full support of all modern routing protocols, easy to use configuration interface and powerful route filtering language

Signed-off-by Adrien Gallou?t <[email protected]>

---
Changes v1 -> v2 (after Baruch Siach review)
- Add a comment for the use of autoreconf
- Use github helper

I've applied your patch, after doing a number of changes:

[Thomas:
- Do not make ncurses/readline mandatory dependencies, since they are not. They are only needed when building the BIRD client. Added a Config.in sub-option to enable/disable the client. As part of this, added ncurses/readline to <pkg>_DEPENDENCIES.
- Add a patch to fix the installation when the BIRD client is disabled, the patch has been submitted upstream.
- Added host-flex and host-bison to <pkg>_DEPENDENCIES since flex/bison are used during the build process.
- Add BR2_USE_MMU dependency, the code uses fork()
- Fix alphabetic ordering in DEVELOPERS file.]

Thanks for this contribution!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com