Skip to contentSkip to conversation

odroid-c2: change ramdisk_addr_r

PATCH New Heinrich Schuchardt 5 participants 7 messages Apr 14, 2017 – May 1, 2017 Arm/Amlogic Meson SoC support

lore
Share & tools
lore

Heinrich Schuchardt

author
#0 lore raw

PATCH 1/1 odroid-c2: change ramdisk_addr_r

0x10000000 is the start of a 2 MiB area used by
ARM Trusted Firmware (BL31).

So we should not load the ramdisk here.

The legacy Ubuntu image comes with the following line in boot.ini:
setenv initrd_loadaddr "0x13000000"

See
http://odroid.in/ubuntu_16.04lts/ubuntu64-16.04-minimal-odroid-c2-20160815.img.xz
http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb

So let's use the same address.

With the patch booting Linux with booti succeeds,
without the patch Linux hangs.

Signed-off-by Heinrich Schuchardt <[email protected]>
---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/meson-gxbb-common.h +1 -1
index 3fbfcef..66b37a6 100644
@@ -50,7 +50,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x13000000\0" \
 	MESON_FDTFILE_SETTING \
 	BOOTENV
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 odroid-c2: change ramdisk_addr_r

Am 14.04.2017 um 19:34 schrieb Heinrich Schuchardt:

Quoted 14 lines

0x10000000 is the start of a 2 MiB area used by
ARM Trusted Firmware (BL31).

So we should not load the ramdisk here.

The legacy Ubuntu image comes with the following line in boot.ini:
setenv initrd_loadaddr "0x13000000"

See
http://odroid.in/ubuntu_16.04lts/ubuntu64-16.04-minimal-odroid-c2-20160815.img.xz
http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb

So let's use the same address.

Quoted 7 lines

With the patch booting Linux with booti succeeds,
without the patch Linux hangs.

Signed-off-by Heinrich Schuchardt <[email protected]>
---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Again, this is not an Odroid-C2 change. It does look generally okay though.

Regards,
Andreas

Quoted 15 lines
include/configs/meson-gxbb-common.h +1 -1
index 3fbfcef..66b37a6 100644
@@ -50,7 +50,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x13000000\0" \
 	MESON_FDTFILE_SETTING \
 	BOOTENV
Signature · 3 lines
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
author
#2 lore raw

PATCH v2 1/1 meson: gxbb: change ramdisk_addr_r

0x10000000 is the start of a 2 MiB area used by the ARM Trusted Firmware (BL31).

See
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/arm64/boot/dts/amlogic/meson-gx.dtsi?id=refs/tags/v4.10.10

So we should not load the ramdisk here.

The legacy Ubuntu image for the Odroid C2 comes with the following line in boot.ini:
setenv initrd_loadaddr "0x13000000"

See
http://odroid.in/ubuntu_16.04lts/ubuntu64-16.04-minimal-odroid-c2-20160815.img.xz
http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb

So let's use the same address.

With the patch booting Linux with booti succeeds on an Odroid C2, without the patch Linux hangs.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>

---
v2:
Title and commit message changed to reflect that this patch applies to all Meson GXBB systems.
v1:
Initial patch
[PATCH 1/1] odroid-c2: change ramdisk_addr_r
https://lists.denx.de/pipermail/u-boot/2017-April/287373.html

---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/meson-gxbb-common.h +1 -1
index 3fbfcef..66b37a6 100644
@@ -50,7 +50,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x13000000\0" \
 	MESON_FDTFILE_SETTING \
 	BOOTENV
Signature · 1 line
2.1.4
#3 lore raw

PATCH v2 1/1 meson: gxbb: change ramdisk_addr_r

Quoted 31 lines · Heinrich Schuchardt

0x10000000 is the start of a 2 MiB area used by the ARM Trusted Firmware (BL31).

See
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/arm64/boot/dts/amlogic/meson-gx.dtsi?id=refs/tags/v4.10.10

So we should not load the ramdisk here.

The legacy Ubuntu image for the Odroid C2 comes with the following line in boot.ini:
setenv initrd_loadaddr "0x13000000"

See
http://odroid.in/ubuntu_16.04lts/ubuntu64-16.04-minimal-odroid-c2-20160815.img.xz
http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb

So let's use the same address.

With the patch booting Linux with booti succeeds on an Odroid C2, without the patch Linux hangs.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>

---
v2:
Title and commit message changed to reflect that this patch applies to all Meson GXBB systems.
v1:
Initial patch
[PATCH 1/1] odroid-c2: change ramdisk_addr_r
https://lists.denx.de/pipermail/u-boot/2017-April/287373.html

Quoted 3 lines
---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Simon Glass <[email protected]>
#4 lore raw

PATCH v2 1/1 meson: gxbb: change ramdisk_addr_r

In reply to Heinrich Schuchardt
Quoted 16 lines · xypron.glpk at gmx.de

0x10000000 is the start of a 2 MiB area used by the ARM Trusted Firmware (BL31).

See
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/arm64/boot/dts/amlogic/meson-gx.dtsi?id=refs/tags/v4.10.10

So we should not load the ramdisk here.

The legacy Ubuntu image for the Odroid C2 comes with the following line in boot.ini:
setenv initrd_loadaddr "0x13000000"

See
http://odroid.in/ubuntu_16.04lts/ubuntu64-16.04-minimal-odroid-c2-20160815.img.xz
http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb

Quoted 8 lines

So let's use the same address.

With the patch booting Linux with booti succeeds on an Odroid C2, without the patch Linux hangs.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Tested booting kernel+devicetree+ramdisk on an odroid-c2.

Tested-by Vagrant Cascadian <[email protected]>

live well,
vagrant

Quoted 17 lines

---
v2:
Title and commit message changed to reflect that this patch applies to all Meson GXBB systems.
v1:
Initial patch
[PATCH 1/1] odroid-c2: change ramdisk_addr_r
https://lists.denx.de/pipermail/u-boot/2017-April/287373.html

---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/meson-gxbb-common.h +0 -0
index 3fbfcef..66b37a6 100644

include/configs/meson-gxbb-common.h line 56

Quoted 8 lines
include/configs/meson-gxbb-common.h +1 -1
@@ -50,7 +50,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x13000000\0" \
 	MESON_FDTFILE_SETTING \
 	BOOTENV

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170417/cb92c437/attachment.sig>

author
#5 lore raw

PATCH v2 1/1 meson: gxbb: change ramdisk_addr_r

Quoted 45 lines · Vagrant Cascadian
Quoted 16 lines · xypron.glpk at gmx.de

0x10000000 is the start of a 2 MiB area used by the ARM Trusted Firmware (BL31).

See
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/arm64/boot/dts/amlogic/meson-gx.dtsi?id=refs/tags/v4.10.10

So we should not load the ramdisk here.

The legacy Ubuntu image for the Odroid C2 comes with the following line in boot.ini:
setenv initrd_loadaddr "0x13000000"

See
http://odroid.in/ubuntu_16.04lts/ubuntu64-16.04-minimal-odroid-c2-20160815.img.xz
http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb

Quoted 8 lines

So let's use the same address.

With the patch booting Linux with booti succeeds on an Odroid C2, without the patch Linux hangs.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Simon Glass <[email protected]>

Tested booting kernel+devicetree+ramdisk on an odroid-c2.

Tested-by Vagrant Cascadian <[email protected]>

live well,
vagrant

Quoted 12 lines

---
v2:
Title and commit message changed to reflect that this patch applies to all Meson GXBB systems.
v1:
Initial patch
[PATCH 1/1] odroid-c2: change ramdisk_addr_r
https://lists.denx.de/pipermail/u-boot/2017-April/287373.html

---
 include/configs/meson-gxbb-common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

include/configs/meson-gxbb-common.h line 56

Quoted 13 lines
include/configs/meson-gxbb-common.h +1 -1
index 3fbfcef..66b37a6 100644
@@ -50,7 +50,7 @@
 	"scriptaddr=0x1f000000\0" \
 	"kernel_addr_r=0x01080000\0" \
 	"pxefile_addr_r=0x01080000\0" \
-	"ramdisk_addr_r=0x10000000\0" \
+	"ramdisk_addr_r=0x13000000\0" \
 	MESON_FDTFILE_SETTING \
 	BOOTENV

Hello Tom,

could you, please, merge this patch. It is needed to boot the Odroid C2.

Best regards

Heinrich Schuchardt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170501/38dc3a35/attachment.sig>

#6 lore raw

PATCH v2 1/1 meson: gxbb: change ramdisk_addr_r

In reply to Heinrich Schuchardt
Quoted 18 lines · xypron.glpk at gmx.de

0x10000000 is the start of a 2 MiB area used by the ARM Trusted Firmware (BL31).

See
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/arm64/boot/dts/amlogic/meson-gx.dtsi?id=refs/tags/v4.10.10

So we should not load the ramdisk here.

The legacy Ubuntu image for the Odroid C2 comes with the following line in boot.ini:
setenv initrd_loadaddr "0x13000000"

See
http://odroid.in/ubuntu_16.04lts/ubuntu64-16.04-minimal-odroid-c2-20160815.img.xz
http://deb.odroid.in/c2/pool/main/u/u-boot/u-boot_20170226-752a100-8_arm64.deb

So let's use the same address.

Quoted 7 lines

With the patch booting Linux with booti succeeds on an Odroid C2, without the patch Linux hangs.

Cc Andreas Färber <[email protected]>
Signed-off-by Heinrich Schuchardt <[email protected]>
Reviewed-by Simon Glass <[email protected]>
Tested-by Vagrant Cascadian <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170501/995db440/attachment.sig>