Skip to contentSkip to conversation

schifra: mark as broken

PATCH New Thomas Petazzoni 3 participants 3 messages Nov 9, 2014 – Nov 13, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 schifra: mark as broken

There are many build failures caused by schifra, due to upstream changing the tarball without doing new releases. Since has been an on-going problem for some time, and is now the #1 issue in the autobuilders. So let's mark this package broken, until someone cares enough to fix it, or until we remove it.

---
 package/schifra/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/schifra/Config.in +5 -0
index 486f92d..a3f699a 100644
@@ -1,6 +1,10 @@
 config BR2_PACKAGE_SCHIFRA
 	bool "schifra"
 	depends on BR2_INSTALL_LIBSTDCPP
+	# Upstream keep changing the tarball without doing new
+	# releases. This is not acceptable for Buildroot, as
+	# reproducible builds are very important.
+	depends on BR2_BROKEN
 	help
 	  Schifra is a very robust, highly optimized and extremely configurable
 	  Reed-Solomon error correcting code library for both software and IP
@@ -18,4 +22,5 @@ config BR2_PACKAGE_SCHIFRA_EXAMPLES
 endif
 
 comment "schifra needs a toolchain w/ C++"
+	depends on BR2_BROKEN
 	depends on !BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.0.0
#1 lore raw

PATCH 1/1 schifra: mark as broken

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

There are many build failures caused by schifra, due to upstream changing the tarball without doing new releases. Since has been an on-going problem for some time, and is now the #1 issue in the autobuilders. So let's mark this package broken, until someone cares enough to fix it, or until we remove it.

I've been discussing with schifra upstream and hope to have a fix very soon, so I prefer to wait a bit and get it fixed instead.

They already put versioned binaries up on http://schifra.com/buildroot/
but I would prefer them to not do anything special for buildroot (that they might forget to maintain in the future).

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 schifra: mark as broken

In reply to Thomas Petazzoni
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

There are many build failures caused by schifra, due to upstream changing the tarball without doing new releases. Since has been an on-going problem for some time, and is now the #1 issue in the autobuilders. So let's mark this package broken, until someone cares enough to fix it, or until we remove it.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard