Skip to contentSkip to conversation

rt-tests: disable for uclibc mips

PATCH New Ryan Barnett 3 participants 5 messages Feb 22, 2014 – Feb 23, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 rt-tests: disable for uclibc mips

rt-tests is not supported by a uclibc toolchain that does not implement _pid in struct sigevent. Currently this is all MIPS architectures in uclibc.

Fixes:
http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b

---
 package/rt-tests/Config.in | 7 +++++++
 1 file changed, 7 insertions(+)
package/rt-tests/Config.in +7 -0
index 58a88a8..a8cede0 100644
@@ -5,6 +5,9 @@ config BR2_PACKAGE_RT_TESTS
 	depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
 	# no NPTL for these archs
 	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
+	# no _tid field in 'struct sigevent'
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+		BR2_mips64 || BR2_mips64el)
 	help
 	  Set of utilities for testing the real-time behaviour of a
 	  Linux system.
@@ -27,3 +30,7 @@ comment "rt-tests needs a toolchain w/ threads"
 	depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
 	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "rt-tests needs an (e)glibc toolchain"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+		BR2_mips64 || BR2_mips64el)
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH v2 2/2 rt-tests: disable on bfin

rt-tests depends on NPTL which is not available on the bfin architecture.

Fixes:
http://autobuild.buildroot.net/results/ac9/ac95f73b2351d46d9a8c48caae7f6c3ea124e8bc

---
 package/rt-tests/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/rt-tests/Config.in +2 -2
index a8cede0..ff4284e 100644
@@ -4,7 +4,7 @@ config BR2_PACKAGE_RT_TESTS
 	# priority-inheritance mutex needs NPTL
 	depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
 	# no NPTL for these archs
-	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
+	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
 	# no _tid field in 'struct sigevent'
 	depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
 		BR2_mips64 || BR2_mips64el)
@@ -28,7 +28,7 @@ config BR2_PACKAGE_RT_TESTS
 
 comment "rt-tests needs a toolchain w/ threads"
 	depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
-	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
+	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 comment "rt-tests needs an (e)glibc toolchain"
Signature · 1 line
1.8.3.2
#2 lore raw

PATCH v2 1/2 rt-tests: disable for uclibc mips

In reply to Ryan Barnett
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ryan" == Ryan Barnett <[email protected]> writes:

rt-tests is not supported by a uclibc toolchain that does not implement _pid in struct sigevent. Currently this is all MIPS architectures in uclibc.

Fixes:
http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b

Committed both, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/2 rt-tests: disable for uclibc mips

In reply to Ryan Barnett

Ryan, Peter, All,

On 2014-02-23 00:07 +0100, Ryan Barnett spake thusly:

Quoted 17 lines

rt-tests is not supported by a uclibc toolchain that does not implement _pid in struct sigevent. Currently this is all MIPS architectures in uclibc.

Fixes:
http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b

---
 package/rt-tests/Config.in | 7 +++++++
 1 file changed, 7 insertions(+)
package/rt-tests/Config.in +0 -0
index 58a88a8..a8cede0 100644

package/rt-tests/Config.in config BR2_PACKAGE_RT_TESTS · line 10

Quoted 6 lines
package/rt-tests/Config.in +3 -0
@@ -5,6 +5,9 @@ config BR2_PACKAGE_RT_TESTS
 	depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
 	# no NPTL for these archs
 	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
+	# no _tid field in 'struct sigevent'
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+		BR2_mips64 || BR2_mips64el)

Gah! This is not correct Kconfig syntax and breaks:

    $ make menuconfig
    [...]
    package/rt-tests/Config.in:10: syntax error
    package/rt-tests/Config.in:9: invalid option
    package/rt-tests/Config.in:36: syntax error
    package/rt-tests/Config.in:35: invalid option
    make[1]: *** [oldconfig] Error 1

Peter, can we revert this change until we have a proper fix, please?

Ryan, what were you trying to do here? Why can you use something like (variable abbreviated for clarity):

    depends on ! ( UCLIBC && ( mips || mipsel || mips64 || mips64el ) )

package/rt-tests/Config.in comment "rt-tests needs a toolchain w/ threads" · line 36

Quoted 11 lines
package/rt-tests/Config.in +4 -0
 	help
 	  Set of utilities for testing the real-time behaviour of a
 	  Linux system.
@@ -27,3 +30,7 @@ comment "rt-tests needs a toolchain w/ threads"
 	depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
 	depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "rt-tests needs an (e)glibc toolchain"
+	depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+		BR2_mips64 || BR2_mips64el)

Ditto.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH v2 1/2 rt-tests: disable for uclibc mips

Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Gah! This is not correct Kconfig syntax and breaks:

    $ make menuconfig
    [...]
    package/rt-tests/Config.in:10: syntax error
    package/rt-tests/Config.in:9: invalid option
    package/rt-tests/Config.in:36: syntax error
    package/rt-tests/Config.in:35: invalid option
    make[1]: *** [oldconfig] Error 1
Quoted 1 line

Peter, can we revert this change until we have a proper fix, please?

Argh, indeed.

Quoted 4 lines

Ryan, what were you trying to do here? Why can you use something like (variable abbreviated for clarity):

    depends on ! ( UCLIBC && ( mips || mipsel || mips64 || mips64el ) )

Sorry, my fault. Ryan's first version wasn't correct, so I suggested something like the 2nd approach (but never tested it).

Signature · 1 line
Bye, Peter Korsgaard