Skip to contentSkip to conversation

ath10k: split way to long line of code

PATCH New Bartosz Markowski 2 participants 2 messages Apr 16, 2013 – Apr 17, 2013 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: split way to long line of code

split into functional blocks, to reduce almost 200 char line. Now it's easier to read both, the code and the logs produced.

---
 drivers/net/wireless/ath/ath10k/wmi.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
drivers/net/wireless/ath/ath10k/wmi.c +10 -4
index 1cb55bb..6f3223e 100644
@@ -794,15 +794,21 @@ static void wmi_service_ready_event_rx(struct ath10k *ar, struct sk_buff *skb)
 			    __le32_to_cpu(ev->num_mem_reqs));
 	}
 
-	ath10k_dbg(ATH10K_DBG_WMI,
-		   "wmi event service ready sw_ver 0x%08x sw_ver1 0x%08x abi_ver %u phy_cap 0x%08x ht_cap 0x%08x vht_cap 0x%08x vht_supp_msc 0x%08x sys_cap_info 0x%08x mem_reqs %u\n",
+	ath10k_dbg(ATH10K_DBG_WMI, "wmi event service ready\n");
+
+	ath10k_dbg(ATH10K_DBG_WMI, "- sw_ver 0x%08x sw_ver1 0x%08x abi_ver %u\n",
 		   __le32_to_cpu(ev->sw_version),
 		   __le32_to_cpu(ev->sw_version_1),
-		   __le32_to_cpu(ev->abi_version),
+		   __le32_to_cpu(ev->abi_version));
+
+	ath10k_dbg(ATH10K_DBG_WMI, "- phy_cap 0x%08x ht_cap 0x%08x vht_cap 0x%08x vht_supp_msc 0x%08x\n",
 		   __le32_to_cpu(ev->phy_capability),
 		   __le32_to_cpu(ev->ht_cap_info),
 		   __le32_to_cpu(ev->vht_cap_info),
-		   __le32_to_cpu(ev->vht_supp_mcs),
+		   __le32_to_cpu(ev->vht_supp_mcs));
+
+
+	ath10k_dbg(ATH10K_DBG_WMI, "- sys_cap_info 0x%08x mem_reqs %u\n",
 		   __le32_to_cpu(ev->sys_cap_info),
 		   __le32_to_cpu(ev->num_mem_reqs));
 
Signature · 1 line
1.7.10
#1 lore raw

PATCH 1/1 ath10k: split way to long line of code

Quoted 4 lines · Bartosz Markowski

split into functional blocks, to reduce almost 200 char line. Now it's easier to read both, the code and the logs produced.

Now the debug log output is four lines, I don't think that's any better either. I'll split the output into two lines.

Signature · 1 line
Kalle Valo