Skip to contentSkip to conversation

foomatic-filters: make location of enscript very clear

PATCH New Gustavo Zacarias 2 participants 2 messages Apr 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 foomatic-filters: make location of enscript very clear

Passing --with-file-converter=enscript isn't enough since the build system will try the fallback options (a2ps, mpage, texttops) if it's not found.
This has two bad effects: one of the tools leaking from the distribution making foomatic-filters think everything will be the same on the target (and failing when that's not the case), and failed builds when none is found (enscript is installed in the target directory, the build system doesn't look there).
So just avoid the test by stating explicitly where enscript will live in the target. Fixes:
http://autobuild.buildroot.net/results/37ad3d2c5c35f00c644a2c572f1429bafa4b7cf4/

---
 package/foomatic-filters/foomatic-filters.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/foomatic-filters/foomatic-filters.mk +1 -1
index ad7ab7a..6e13486 100644
@@ -9,8 +9,8 @@ FOOMATIC_FILTERS_SITE = http://www.openprinting.org/download/foomatic
 FOOMATIC_FILTERS_LICENSE = GPLv2+
 FOOMATIC_FILTERS_LICENSE_FILES = COPYING
 FOOMATIC_FILTERS_DEPENDENCIES = cups libusb enscript
-
 FOOMATIC_FILTERS_CONF_OPT = --with-file-converter=enscript
+FOOMATIC_FILTERS_CONF_ENV = ac_cv_path_ENSCRIPT="/usr/bin/enscript"
 
 ifeq ($(BR2_PACKAGE_DBUS),y)
 FOOMATIC_FILTERS_CONF_OPT += --enable-dbus
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 foomatic-filters: make location of enscript very clear

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Passing --with-file-converter=enscript isn't enough since the Gustavo> build system will try the fallback options (a2ps, mpage,
Gustavo> texttops) if it's not found. This has two bad effects: one of Gustavo> the tools leaking from the distribution making
Gustavo> foomatic-filters think everything will be the same on the Gustavo> target (and failing when that's not the case), and failed Gustavo> builds when none is found (enscript is installed in the target Gustavo> directory, the build system doesn't look there). So just Gustavo> avoid the test by stating explicitly where enscript will live Gustavo> in the target. Fixes:
Gustavo> http://autobuild.buildroot.net/results/37ad3d2c5c35f00c644a2c572f1429bafa4b7cf4/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard