Skip to contentSkip to conversation

ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off

PATCH Superseded Santosh Shilimkar 2 participants 4 messages Feb 13, 2013 – Mar 14, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off

Current CPU PM code code make use of common cpu_suspend() path for all the CPU power states which is not optimal. In fact cpu_suspend() path is needed only when we put CPU power domain to off state where the CPU context is lost.

Update the code accordingly so that the expensive cpu_suspend() path can be avoided for the shallow CPU power states like CPU PD INA/CSWR.

The patch has been tested on OMAP4430 and OMAP5430(with few out of tree patches) devices for suspend and CPUidle.

Cc Kevin Hilman <[email protected]>

---
Update changelog to include testing details as suggested by Kevin Hilman.

 arch/arm/mach-omap2/omap-mpuss-lowpower.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/arm/mach-omap2/omap-mpuss-lowpower.c +4 -1
index aac46bf..abdd0f6 100644
@@ -276,7 +276,10 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
 	/*
 	 * Call low level function  with targeted low power state.
 	 */
-	cpu_suspend(save_state, omap4_finish_suspend);
+	if (save_state)
+		cpu_suspend(save_state, omap4_finish_suspend);
+	else
+		omap4_finish_suspend(save_state);
 
 	/*
 	 * Restore the CPUx power state to ON otherwise CPUx
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off

Kevin,

Quoted 10 lines · Santosh Shilimkar

Current CPU PM code code make use of common cpu_suspend() path for all the CPU power states which is not optimal. In fact cpu_suspend() path is needed only when we put CPU power domain to off state where the CPU context is lost.

Update the code accordingly so that the expensive cpu_suspend() path can be avoided for the shallow CPU power states like CPU PD INA/CSWR.

The patch has been tested on OMAP4430 and OMAP5430(with few out of tree patches) devices for suspend and CPUidle.

Quoted 8 lines
Cc Kevin Hilman <[email protected]>

---
Update changelog to include testing details as suggested by Kevin Hilman.

Ping.
It can get into rc's but since it is not strict regression, and if it has to wait for 3.10 then I can add this one along with rest of the PM patches posted towards 3.10

Either way, let me know.

Regards,
Santosh

#2 lore raw

PATCH v2 1/1 ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off

Quoted 21 lines · Santosh Shilimkar

Kevin,

Quoted 10 lines · Santosh Shilimkar

Current CPU PM code code make use of common cpu_suspend() path for all the CPU power states which is not optimal. In fact cpu_suspend() path is needed only when we put CPU power domain to off state where the CPU context is lost.

Update the code accordingly so that the expensive cpu_suspend() path can be avoided for the shallow CPU power states like CPU PD INA/CSWR.

The patch has been tested on OMAP4430 and OMAP5430(with few out of tree patches) devices for suspend and CPUidle.

Quoted 8 lines
Cc Kevin Hilman <[email protected]>

---
Update changelog to include testing details as suggested by Kevin Hilman.

Quoted 6 lines

Ping.
It can get into rc's but since it is not strict regression, and if it has to wait for 3.10 then I can add this one along with rest of the PM patches posted towards 3.10

Either way, let me know.

I have this updated one queued for v3.10 in my PM cleanup branch (for_3.10/cleanup/pm)

Kevin

#3 lore raw

PATCH v2 1/1 ARM: OMAP4: PM: Avoid expensive cpu_suspend() path for all CPU power states except off

Quoted 28 lines · Kevin Hilman
Quoted 26 lines · Santosh Shilimkar

Kevin,

Quoted 10 lines · Santosh Shilimkar

Current CPU PM code code make use of common cpu_suspend() path for all the CPU power states which is not optimal. In fact cpu_suspend() path is needed only when we put CPU power domain to off state where the CPU context is lost.

Update the code accordingly so that the expensive cpu_suspend() path can be avoided for the shallow CPU power states like CPU PD INA/CSWR.

The patch has been tested on OMAP4430 and OMAP5430(with few out of tree patches) devices for suspend and CPUidle.

Quoted 8 lines
Cc Kevin Hilman <[email protected]>

---
Update changelog to include testing details as suggested by Kevin Hilman.

Ping.
It can get into rc's but since it is not strict regression, and if it has to wait for 3.10 then I can add this one along with rest of the PM patches posted towards 3.10

Quoted 5 lines
Quoted 1 line

Either way, let me know.

I have this updated one queued for v3.10 in my PM cleanup branch (for_3.10/cleanup/pm)

Thanks Kevin.

Regards,
Santosh