OMAP: omap_device: make latency autoadjust messages debug

PATCH New Grazvydas Ignotas 2 participants 2 messages Jul 25, 2011 – Aug 5, 2011

Subsystems (2)

Arm (32-bit) Arm sub-architectures

lore

Share & tools

lore

Grazvydas Ignotas

author

2011-07-25 13:18 UTC #0 lore raw

PATCH 1/1 OMAP: omap_device: make latency autoadjust messages debug

During normal system operation warning messages similar to this are appearing quite often:
omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035

This doesn't seem to be reporting a problem, nor is it very useful for non-developers, so reduce it to debug level.

Cc Steve Sakoman <[email protected]>

Signed-off-by Grazvydas Ignotas <[email protected]>

---
Applies on top of git://git.pwsan.com/linux-2.6 prcm-devel-3.1
+ Kevin's "OMAP: omap_device: replace pr_* prints with dev_*".

 arch/arm/plat-omap/omap_device.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

arch/arm/plat-omap/omap_device.c +8 -8

index 1914d7e..f363cbf 100644
@@ -146,10 +146,10 @@ static int _omap_device_activate(struct omap_device *od, u8 ignore_lat)
 			odpl->activate_lat_worst = act_lat;
 			if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
 				odpl->activate_lat = act_lat;
-				dev_warn(&od->pdev.dev,
-					 "new worst case activate latency "
-					 "%d: %llu\n",
-					 od->pm_lat_level, act_lat);
+				dev_dbg(&od->pdev.dev,
+					"new worst case activate latency "
+					"%d: %llu\n",
+					od->pm_lat_level, act_lat);
 			} else
 				dev_warn(&od->pdev.dev,
 					 "activate latency %d "

@@ -213,10 +213,10 @@ static int _omap_device_deactivate(struct omap_device *od, u8 ignore_lat)
 			odpl->deactivate_lat_worst = deact_lat;
 			if (odpl->flags & OMAP_DEVICE_LATENCY_AUTO_ADJUST) {
 				odpl->deactivate_lat = deact_lat;
-				dev_warn(&od->pdev.dev,
-					 "new worst case deactivate latency "
-					 "%d: %llu\n",
-					 od->pm_lat_level, deact_lat);
+				dev_dbg(&od->pdev.dev,
+					"new worst case deactivate latency "
+					"%d: %llu\n",
+					od->pm_lat_level, deact_lat);
 			} else
 				dev_warn(&od->pdev.dev,
 					 "deactivate latency %d "

Signature · 1 line

1.7.0.4

Kevin Hilman

2011-08-05 14:52 UTC #1 lore raw

PATCH 1/1 OMAP: omap_device: make latency autoadjust messages debug

Quoted 6 lines · Grazvydas Ignotas

During normal system operation warning messages similar to this are appearing quite often:
omap_device: omap4-keypad.-1: new worst case activate latency 0: 61035
This doesn't seem to be reporting a problem, nor is it very useful for non-developers, so reduce it to debug level.

Yeah, this is really only useful for PM developers, so making it debug is fine.

Quoted 5 lines

Cc Steve Sakoman <[email protected]>
Signed-off-by Grazvydas Ignotas <[email protected]>
---
Applies on top of git://git.pwsan.com/linux-2.6 prcm-devel-3.1
+ Kevin's "OMAP: omap_device: replace pr_* prints with dev_*".

Adding it to my omap_device queue for v3.2:
git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.2/omap_device

Kevin