Re-instate partial activation support in clustered mode.
PATCH 1/1 Re-instate partial activation support in clustered mode.
Hi,
the patch from September 2008 (partial activation revamp) broke clustered activation for the partial mode. This is currently more serious, since lvconvert --repair relies on this functionality (see BZ 504699).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cluster-partial.diff
Type: text/x-diff
Size: 2860 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20090610/8919d281/attachment.bin>
-------------- next part --------------
Yours,
Petr.
Signature · 6 lines
Peter Rockai | me()mornfall!net | prockai()redhat!com
http://blog.mornfall.net | http://web.mornfall.net
"In My Egotistical Opinion, most people's C programs should be
indented six feet downward and covered with dirt."
-- Blair P. Houghton on the subject of C program indentationPATCH 1/1 Re-instate partial activation support in clustered mode.
Quoted 3 lines · Petr Rockai
the patch from September 2008 (partial activation revamp) broke clustered activation for the partial mode. This is currently more serious, since lvconvert --repair relies on this functionality (see BZ 504699).
I am going to test it now, just one thing: when introducing new lock flags etc. please also fix debugging code, so in log new flags appear decoded.
I mean
@@ -145,7 +145,8 @@ static const char *decode_flags(unsigned char flags)
{
static char buf[128];
- sprintf(buf, "0x%x (%s%s)", flags,
+ sprintf(buf, "0x%x (%s%s%s)", flags,
+ flags & LCK_PARTIAL_MODE ? "PARTIAL_MODE " : "",
flags & LCK_MIRROR_NOSYNC_MODE ? "MIRROR_NOSYNC " : "",
flags & LCK_DMEVENTD_MONITOR_MODE ? "DMEVENTD_MONITOR " : "");
Also do_lock_lv() should clear cmd->partial_activation before releasing lvm_lock, (all flags are handled that way, so better do not change logic here).
Milan