Skip to contentSkip to conversation

package/webkitgtk: fix wrong config option

PATCH In review Thomas Devoogdt 3 participants 3 messages Aug 19 – Aug 23

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/webkitgtk: fix wrong config option

Commit 713d63b "package/webkitgtk: add option to enable MiniBrowser", added support to select BR2_PACKAGE_WEBKITGTK_MINIBROWSER, but forgot to drop the default -DENABLE_MINIBROWSER=ON entry.

---
 package/webkitgtk/webkitgtk.mk | 1 -
 1 file changed, 1 deletion(-)
package/webkitgtk/webkitgtk.mk +0 -1
index 6cab2c6a247..ee9e707cb55 100644
@@ -27,7 +27,6 @@ WEBKITGTK_CONF_OPTS = \
 	-DENABLE_API_TESTS=OFF \
 	-DENABLE_DOCUMENTATION=OFF \
 	-DENABLE_GEOLOCATION=OFF \
-	-DENABLE_MINIBROWSER=ON \
 	-DENABLE_SPELLCHECK=ON \
 	-DENABLE_WEB_RTC=OFF \
 	-DPORT=GTK \
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Acked-by on v1 1/1
#1 lore raw

Hi Thomas,

Good catch!

Quoted 5 lines · On Wed, 19 Aug 2026 14:38:11 +0200 Thomas Devoogdt <[email protected]> wrote:

Commit 713d63b "package/webkitgtk: add option to enable MiniBrowser", added support to select BR2_PACKAGE_WEBKITGTK_MINIBROWSER, but forgot to drop the default -DENABLE_MINIBROWSER=ON entry.

Quoted 24 lines
---
 package/webkitgtk/webkitgtk.mk | 1 -
 1 file changed, 1 deletion(-)
package/webkitgtk/webkitgtk.mk +0 -1
index 6cab2c6a247..ee9e707cb55 100644
@@ -27,7 +27,6 @@ WEBKITGTK_CONF_OPTS = \
 	-DENABLE_API_TESTS=OFF \
 	-DENABLE_DOCUMENTATION=OFF \
 	-DENABLE_GEOLOCATION=OFF \
-	-DENABLE_MINIBROWSER=ON \
 	-DENABLE_SPELLCHECK=ON \
 	-DENABLE_WEB_RTC=OFF \
 	-DPORT=GTK \
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Cheers,
—Adrián

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Thomas Devoogdt
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Devoogdt <[email protected]> writes:

Commit 713d63b "package/webkitgtk: add option to enable MiniBrowser", added support to select BR2_PACKAGE_WEBKITGTK_MINIBROWSER, but forgot to drop the default -DENABLE_MINIBROWSER=ON entry.

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot