spi: spi-qpic: fix common module build
Subsystems (2)
PATCH 1/1 spi: spi-qpic: fix common module build
From: Arnd Bergmann <[email protected]>
When the NAND driver is a loadable module, and the SPI driver is turned off, the common part is not built:
ERROR: modpost: "qcom_nandc_unalloc" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_write_reg_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_read_reg_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_nandc_dev_to_mem" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_nandc_alloc" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_submit_descs" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_clear_read_regs" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_clear_bam_transaction" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_read_data_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_write_data_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
Simplify the Makefile to just build the common bits for either of the two, so it will be built-in whenever one of them is, or otherwise a loadable module if needed.
--- drivers/mtd/nand/Makefile | 3 --- 1 file changed, 3 deletions(-)
drivers/mtd/nand/Makefile +0 -3
@@ -3,11 +3,8 @@ nandcore-objs := core.o bbt.o obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o obj-$(CONFIG_MTD_NAND_ECC_MEDIATEK) += ecc-mtk.o -ifeq ($(CONFIG_SPI_QPIC_SNAND),y) obj-$(CONFIG_SPI_QPIC_SNAND) += qpic_common.o -else obj-$(CONFIG_MTD_NAND_QCOM) += qpic_common.o -endif obj-y += onenand/ obj-y += raw/ obj-y += spi/
Signature · 1 line
2.39.5
Miquel Raynal
maintainerHi Arnd,
Quoted 16 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When the NAND driver is a loadable module, and the SPI driver is turned off, the common part is not built:
ERROR: modpost: "
qcom_nandc_unalloc" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_write_reg_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_read_reg_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_nandc_dev_to_mem" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_nandc_alloc" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_submit_descs" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_clear_read_regs" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_clear_bam_transaction" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_read_data_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
ERROR: modpost: "qcom_write_data_dma" [drivers/spi/spi-qpic-snand.ko] undefined!
Quoted 6 lines
Simplify the
Makefileto just build the common bits for either of the two, so it will be built-in whenever one of them is, or otherwise a loadable module if needed.Fixes 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")Signed-off-by Arnd Bergmann <[email protected]>
Thanks for the fix, I just applied Geert's identical patch this morning, I was waiting for -rc1 to synchronize everything again:
https://lore.kernel.org/linux-mtd/[email protected]/T/#t
Sorry for the delay.
Thanks,
Miquèl